00:00
<
meh` >
you're welcome
00:00
<
meh` >
I think we should go back to opal/opal/* no matter how ugly it is
00:01
<
meh` >
core/ is very common
00:01
<
meh` >
that's less likely
00:01
<
ryanstout >
its a super hard issue to figure out also
00:01
<
ryanstout >
or maybe raise an error on require 'core/*'
00:01
<
meh` >
well, at least it's not as bad as main.rb one :P
00:01
<
ryanstout >
yea, that would be bad
00:02
<
meh` >
ryanstout, what's your github username?
00:03
<
ryanstout >
ryanstout
00:55
fkchang has quit [Ping timeout: 252 seconds]
01:11
fkchang has joined #opal
01:38
ryanstout has quit [Quit: ryanstout]
01:46
kludge` has quit [Ping timeout: 272 seconds]
01:53
kludge` has joined #opal
03:54
meh` has quit [Ping timeout: 272 seconds]
05:43
ryanstout has joined #opal
05:43
ryanstout has quit [Client Quit]
05:44
ryanstout has joined #opal
05:45
ryanstout has quit [Client Quit]
06:17
fkchang has quit [Ping timeout: 248 seconds]
08:46
GitHub23 has joined #opal
08:46
GitHub23 has left #opal [#opal]
09:21
elia has joined #opal
09:32
elia has quit [Quit: Computer has gone to sleep.]
09:38
elia has joined #opal
09:46
GitHub58 has joined #opal
09:46
GitHub58 has left #opal [#opal]
09:46
<
GitHub58 >
opal/spec-paths-cleanup 68cd470 Elia Schito: Don't rely on local static files...
09:49
travis-ci has joined #opal
09:49
<
travis-ci >
[travis-ci] opal/opal#1482 (spec-paths-cleanup - 68cd470 : Elia Schito): The build was fixed.
09:49
travis-ci has left #opal [#opal]
09:58
adambeynon has joined #opal
10:14
GitHub31 has joined #opal
10:14
GitHub31 has left #opal [#opal]
10:14
<
GitHub31 >
opal/0.5.x 2c39115 Adam Beynon: Fix regression: Add lexer support for %i[] style words
10:16
GitHub61 has joined #opal
10:16
GitHub61 has left #opal [#opal]
10:16
<
GitHub61 >
opal/master 1b9f55f Adam Beynon: Fix regression: Add lexer support for %i[] style words
10:18
travis-ci has joined #opal
10:18
travis-ci has left #opal [#opal]
10:18
<
travis-ci >
[travis-ci] opal/opal#1484 (0.5.x - 2c39115 : Adam Beynon): The build passed.
10:19
travis-ci has joined #opal
10:19
<
travis-ci >
[travis-ci] opal/opal#1485 (master - 1b9f55f : Adam Beynon): The build passed.
10:19
travis-ci has left #opal [#opal]
10:21
<
elia >
adambeynon, good morning!
10:21
<
elia >
adambeynon, you think the spec dir cleanup branch can be merged now?
10:23
<
adambeynon >
elia: yo yo
10:23
<
adambeynon >
yes, its looking good :)
10:24
<
adambeynon >
elia: reluctantly, I have agreed with meh` that we should have master for 0.6.x targetted stuff, running as ruby 2.0.0, and the 0.5.x branch now for 1.9.3 and various bug fixes for that
10:24
<
adambeynon >
so I suppose we should/could apply the new spec stuff to both branches
10:25
<
adambeynon >
will make it easier than having specs in different locations
10:25
<
adambeynon >
Im imagining there will be lots of cherry-pick'ing commits between the two as we fix buggy methods
10:25
<
adambeynon >
I still see quite a few 0.5.x releases (once per week or so), so 0.5.x will still be very active
10:26
<
elia >
adambeynon, agree, I don't think 0.5 branch will live very long once 0.6 is out though
10:26
<
elia >
adambeynon, wait befor merging
10:27
<
elia >
adambeynon, meh will hate me if I let those commits go to master unsquashed
10:27
<
elia >
Once it's merged I'll rebase & merge on 0.5
10:30
<
adambeynon >
lol, sure
10:32
<
adambeynon >
elia: doing some work on source-maps today - due to the way we pickup line numbers, they are quite often 1 or 2 lines out
10:32
kludge` has quit [Ping timeout: 272 seconds]
10:32
<
adambeynon >
e.g. if you have "some_method\nbar"
10:32
<
elia >
adambeynon, noticed that
10:33
<
adambeynon >
elia: its going to involve a total rewrite of the lexer, but I think its worth it. I was trying to debug some rspec issues yesterday, and source-maps are a must
10:33
<
adambeynon >
I never used to use them, but yesterday has convinced me ;)
10:35
kludge` has joined #opal
11:10
GitHub62 has joined #opal
11:10
<
GitHub62 >
opal/master eddc8e7 Adam Beynon: Rewrite hardcoded lex_state checks in lexer to use helpers
11:10
GitHub62 has left #opal [#opal]
11:25
GitHub57 has joined #opal
11:25
<
GitHub57 >
opal/master bed157d Adam Beynon: Cleanup lexer.rb some more
11:25
GitHub57 has left #opal [#opal]
11:29
travis-ci has joined #opal
11:29
travis-ci has left #opal [#opal]
11:29
<
travis-ci >
[travis-ci] opal/opal#1487 (master - bed157d : Adam Beynon): The build passed.
11:31
GitHub141 has joined #opal
11:31
<
GitHub141 >
opal/master 9d970cb Adam Beynon: Add set_arg_state method to lexer to set after operator state
11:31
GitHub141 has left #opal [#opal]
11:33
GitHub13 has joined #opal
11:33
<
GitHub13 >
opal/master 614bcff Adam Beynon: Add Lexer#pushback() instead of manually setting scanner pos
11:33
GitHub13 has left #opal [#opal]
11:34
travis-ci has joined #opal
11:34
travis-ci has left #opal [#opal]
11:34
<
travis-ci >
[travis-ci] opal/opal#1488 (master - 9d970cb : Adam Beynon): The build passed.
11:36
<
adambeynon >
elia: not sure how much difference it makes to sourcemaps, but I think I've got columns (of original code) all worked out
11:36
<
elia >
adambeynon, sounds huge to me
11:37
<
adambeynon >
elia: looking on google, hovering over variables in the code should pop-up with an inspection HUD
11:37
<
adambeynon >
that would be awsome..
11:37
travis-ci has joined #opal
11:37
<
travis-ci >
[travis-ci] opal/opal#1489 (master - 614bcff : Adam Beynon): The build passed.
11:37
travis-ci has left #opal [#opal]
11:37
<
elia >
adambeynon, really, can become the best ruby debugging platform
11:38
<
elia >
adambeynon, I'm having some hard time squashing everything… I think I'll reword another couple commits and give green light for merging :)
11:43
<
adambeynon >
elia: Im not too bothered about the squashing - once they are in, its all good ^_^
11:43
GitHub168 has joined #opal
11:43
<
GitHub168 >
opal/spec-paths-cleanup 13b2bce Elia Schito: Move spec/corelib to spec/opal/corelib
11:43
GitHub168 has left #opal [#opal]
11:43
<
GitHub168 >
opal/spec-paths-cleanup e89a6a7 Elia Schito: Move every spec inside the spec dir...
11:43
<
GitHub168 >
opal/spec-paths-cleanup 4d0b452 Elia Schito: Cleanup rake tasks
11:44
GitHub186 has joined #opal
11:44
<
GitHub186 >
opal/spec-paths-cleanup 737e1f0 Elia Schito: Move spec/corelib to spec/opal/corelib
11:44
<
GitHub186 >
opal/spec-paths-cleanup be8626d Elia Schito: Cleanup rake tasks
11:44
<
GitHub186 >
opal/spec-paths-cleanup a2fddd7 Elia Schito: Move every spec inside the spec dir...
11:44
GitHub186 has left #opal [#opal]
11:44
GitHub196 has joined #opal
11:44
<
GitHub196 >
opal/master 8ebbaa2 Adam Beynon: Cleanup parsing '*' tokens
11:44
GitHub196 has left #opal [#opal]
11:44
<
elia >
adambeynon, ok, that was the last rebase
11:44
<
adambeynon >
ah, sorry,
11:44
<
adambeynon >
should have waitied on that commit :(
11:44
travis-ci has joined #opal
11:44
<
travis-ci >
[travis-ci] opal/opal#1490 (spec-paths-cleanup - 501e9d2 : Elia Schito): The build has errored.
11:44
travis-ci has left #opal [#opal]
11:45
<
elia >
spam incooming!
11:48
travis-ci has joined #opal
11:48
<
travis-ci >
[travis-ci] opal/opal#1492 (spec-paths-cleanup - 8314f0f : Elia Schito): The build passed.
11:48
travis-ci has left #opal [#opal]
11:51
GitHub47 has joined #opal
11:51
<
GitHub47 >
opal/spec-paths-cleanup fb40144 Elia Schito: Cleanup rake tasks
11:51
<
GitHub47 >
opal/spec-paths-cleanup 2c64a71 Elia Schito: Move spec/corelib to spec/opal/corelib
11:51
<
GitHub47 >
opal/spec-paths-cleanup ac6d691 Elia Schito: Move every spec inside the spec dir...
11:51
GitHub47 has left #opal [#opal]
11:52
<
elia >
adambeynon, ouch, the rebased branch will fail too
11:53
travis-ci has joined #opal
11:53
<
travis-ci >
[travis-ci] opal/opal#1494 (master - 8ebbaa2 : Adam Beynon): The build passed.
11:53
travis-ci has left #opal [#opal]
11:53
<
adambeynon >
<3 playing with git commits
11:54
<
adambeynon >
how did I miss those
11:55
travis-ci has joined #opal
11:55
travis-ci has left #opal [#opal]
11:55
<
travis-ci >
[travis-ci] opal/opal#1495 (spec-paths-cleanup - 3e30534 : Elia Schito): The build passed.
11:59
<
elia >
adambeynon, awesome anyway, used to use Enumerize for that
11:59
DouweM has joined #opal
12:08
<
adambeynon >
so, is that spec stuff good to go into master?
12:40
elia has quit [Quit: Computer has gone to sleep.]
13:07
elia has joined #opal
13:20
elia has quit [Quit: Computer has gone to sleep.]
13:20
travis-ci has joined #opal
13:20
<
travis-ci >
[travis-ci] Strech/opal#5 (split - b792742 : Strech (Sergey Fedorov)): The build was fixed.
13:20
travis-ci has left #opal [#opal]
13:27
elia has joined #opal
14:08
elia has quit [Quit: Computer has gone to sleep.]
14:12
elia has joined #opal
14:19
<
elia >
adambeynon, sorry, missed the notification
14:19
<
elia >
adambeynon, yeah, the branch is ok
14:25
e_dub has quit [Quit: It's a hard knock life]
15:01
GitHub129 has joined #opal
15:01
GitHub129 has left #opal [#opal]
15:01
<
GitHub129 >
opal/parser_tokens a65bfca Adam Beynon: Initial commit for parser tokens to store col, line info
15:07
GitHub179 has joined #opal
15:07
GitHub179 has left #opal [#opal]
15:07
<
adambeynon >
elia: awesome, merged in
15:07
<
adambeynon >
much better :D
15:11
GitHub182 has joined #opal
15:11
<
GitHub182 >
opal/parser_tokens 6205c7c Adam Beynon: Merge branch 'parser_tokens' of github.com:opal/opal into parser_tokens...
15:11
GitHub182 has left #opal [#opal]
15:11
<
GitHub182 >
opal/parser_tokens 2916024 Adam Beynon: Initial commit for parser tokens to store col, line info
15:11
travis-ci has joined #opal
15:11
<
travis-ci >
[travis-ci] opal/opal#1497 (master - 3e30534 : Elia Schito): The build passed.
15:11
travis-ci has left #opal [#opal]
15:17
GitHub120 has joined #opal
15:17
GitHub120 has left #opal [#opal]
15:18
GitHub188 has joined #opal
15:18
<
GitHub188 >
opal/parser-tokens 08db404 Adam Beynon: Parser tokens initial commit
15:18
GitHub188 has left #opal [#opal]
15:18
<
GitHub188 >
opal/parser-tokens bf3fa2c Adam Beynon: Initial commit for parser tokens to store col, line info...
15:21
elia has quit [Quit: Computer has gone to sleep.]
15:33
elia has joined #opal
15:34
GitHub175 has joined #opal
15:34
<
GitHub175 >
opal/spec-paths-cleanup d61a168 Elia Schito: Cleanup rake tasks
15:34
GitHub175 has left #opal [#opal]
15:34
<
GitHub175 >
opal/spec-paths-cleanup d8dfd50 Elia Schito: Move spec/corelib to spec/opal/corelib
15:34
<
GitHub175 >
opal/spec-paths-cleanup 66f6c72 Elia Schito: Move every spec inside the spec dir...
15:34
<
elia >
adambeynon, pushed the branch rebased on 0.5.x
15:38
travis-ci has joined #opal
15:38
<
travis-ci >
[travis-ci] opal/opal#1498 (spec-paths-cleanup - def172b : Elia Schito): The build passed.
15:38
travis-ci has left #opal [#opal]
15:43
<
adambeynon >
elia: thanks, forgot about that branch!
15:45
elia has quit [Quit: Computer has gone to sleep.]
15:50
fkchang has joined #opal
15:53
elia has joined #opal
15:54
<
elia >
adambeynon, merging into 0.5.x, ok?
15:55
<
adambeynon >
elia: yeap
15:58
GitHub115 has joined #opal
15:58
GitHub115 has left #opal [#opal]
16:00
GitHub192 has joined #opal
16:00
GitHub192 has left #opal [#opal]
16:03
travis-ci has joined #opal
16:03
<
travis-ci >
[travis-ci] opal/opal#1499 (0.5.x - def172b : Elia Schito): The build passed.
16:03
travis-ci has left #opal [#opal]
16:31
meh` has joined #opal
17:26
ryanstout has joined #opal
17:43
<
meh` >
adambeynon, thoughts on #421?
17:57
elia has quit [Ping timeout: 245 seconds]
18:08
<
adambeynon >
meh`: yeah, opal/opal or opal/corelib
18:08
<
adambeynon >
not sure which I prefer
18:08
<
meh` >
corelib seems less likely than core
18:08
<
meh` >
I'd go with corelib
18:08
<
meh` >
and put stdlib in opal/ too
18:09
<
meh` >
opal/corelib opal/stdlib
18:09
<
meh` >
and everyone's happy
18:09
<
meh` >
and I'm unhappy with the dir structure of spec now
18:09
<
meh` >
elia didn't do the changes I asked for :(
18:09
<
meh` >
oh well, with time
18:09
<
adambeynon >
meh`: we can't put stdlib into opal/stdlib, as stdlib/observer.rb etc will be requirable
18:10
<
meh` >
adambeynon, I don't see the problem with that
18:10
<
meh` >
why would that be an issue?
18:12
<
adambeynon >
I dont like it, why not just flatten opal/ ?
18:12
<
meh` >
adambeynon, how do you mean?
18:16
<
adambeynon >
opal/opal.rb
18:16
<
adambeynon >
opal/corelib/array.rb
18:16
<
adambeynon >
opal/observer.rb
18:17
e_dub has joined #opal
18:17
<
meh` >
adambeynon, that's even more confusing
18:17
<
meh` >
adambeynon, a good directory tree is helpful
18:17
<
meh` >
and having a thousand files in opal/ is a bad idea
18:17
<
meh` >
I don't see the problem with stdlib/* being requirable, nobody will do that
18:17
<
meh` >
and you don't even have to think it's there
18:17
<
meh` >
it keeps the structure clear
18:18
<
meh` >
same reason why the current spec/ tree is still wrong
18:19
mojavelinux has joined #opal
18:21
<
adambeynon >
meh`, whats wrong with it?
18:21
<
meh` >
adambeynon, most of the stuff in spec/opal/ should be in spec/
18:22
<
meh` >
spec/opal/ should only contain opal specific specs
18:23
<
adambeynon >
the way I see it, spec/opal for all specs running under opal, and spec/cli for all stuff running under mri/rspec
18:23
<
meh` >
adambeynon, that's a pointless separation
18:24
<
adambeynon >
it is the separation we need though...
18:24
<
adambeynon >
we have 2 runners, so we need 2 directories for the tests
18:24
<
meh` >
cli is its own directory, it's already a single one
18:25
<
meh` >
the mspec runner can just have the directories to look into
18:25
<
adambeynon >
why wouldnt we? it doesnt matter if specs come from rubyspec or our own custom specs
18:25
<
adambeynon >
when we test the runtime, we want all specs to apply
18:25
<
meh` >
of course, but meaningful separation helps to know what specs are for
18:25
<
meh` >
spec/opal/rubyspec should be spec/core
18:26
<
meh` >
compiler, parser and core should stay in spec/opal
18:26
<
meh` >
because they're opal specific
18:26
<
meh` >
and stdlib should be in spec/ where we add the sl-* spec submodules
18:28
<
meh` >
right now it's unclear what is what and for what purpose they are
19:12
DrShoggoth has joined #opal
19:31
DrShoggoth has quit [Quit: Leaving]
19:53
elia has joined #opal
19:56
_elia has joined #opal
19:58
elia has quit [Ping timeout: 245 seconds]
20:06
_elia has quit [Quit: Computer has gone to sleep.]
20:07
elia has joined #opal
20:14
elia has quit [Quit: Computer has gone to sleep.]
20:20
GitHub69 has joined #opal
20:20
GitHub69 has left #opal [#opal]
20:20
<
GitHub69 >
opal/parser-tokens 5e0f9c7 Adam Beynon: Handle a lot more sexp constructions
20:58
GitHub44 has joined #opal
20:58
GitHub44 has left #opal [#opal]
20:58
<
GitHub44 >
opal/parser-tokens f931afd Adam Beynon: Fix block args merging into sexps
21:06
elia has joined #opal
21:19
elia has quit [Quit: Computer has gone to sleep.]
21:20
DrShoggoth has joined #opal
21:26
elia has joined #opal
22:21
skofo has joined #opal
23:18
elia has quit [Quit: Computer has gone to sleep.]
23:48
elia has joined #opal