meh` changed the topic of #opal to: http://opalrb.org - Ruby runtime and library on top of Javascript | 1.0.0 is near | This channel is logged at https://botbot.me/freenode/opal/
f-3r has joined #opal
godd2 has quit [Ping timeout: 244 seconds]
godd2 has joined #opal
edza101 has joined #opal
godd2 is now known as godd2-away
boberetezeke has joined #opal
meh` has quit [Ping timeout: 255 seconds]
Livadi has quit [Ping timeout: 276 seconds]
e_dub has joined #opal
boberetezeke has quit [Ping timeout: 245 seconds]
godd2-away is now known as godd2
edza101 has quit [Changing host]
edza101 has joined #opal
edza101 has joined #opal
f-3r has quit [Ping timeout: 255 seconds]
edza101 has quit [Quit: Page closed]
supersym has joined #opal
elia has joined #opal
boberetezeke has joined #opal
boberetezeke has quit [Ping timeout: 240 seconds]
boberetezeke has joined #opal
boberetezeke has quit [Ping timeout: 240 seconds]
boberetezeke has joined #opal
boberetezeke has quit [Ping timeout: 240 seconds]
boberetezeke has joined #opal
boberetezeke has quit [Ping timeout: 240 seconds]
f-3r has joined #opal
boberetezeke has joined #opal
boberetezeke has quit [Ping timeout: 240 seconds]
f-3r has quit [Ping timeout: 245 seconds]
boberetezeke has joined #opal
boberetezeke has quit [Ping timeout: 264 seconds]
meh` has joined #opal
e_dub has quit [Quit: e_dub]
boberetezeke has joined #opal
boberetezeke has quit [Ping timeout: 264 seconds]
e_dub has joined #opal
boberetezeke has joined #opal
f-3r has joined #opal
f-3r has quit [Remote host closed the connection]
f-3r has joined #opal
boberetezeke has quit [Ping timeout: 245 seconds]
boberetezeke has joined #opal
ylluminarious has joined #opal
gabriel_1 has joined #opal
Guest31 has joined #opal
ylluminarious_ has joined #opal
<ylluminarious_> adambeynon, a couple of days ago, a friend of mine made this issue on the opal/opal repository: https://github.com/opal/opal/issues/680. i implemented your solution on that particular wrapper (opal-phaser) and made a pull request for it here: https://github.com/photonstorm/phaser/pull/1521. unfortunately, it looks like the developers of phaser don't know why or how this solution is fixing anything or what opal might be doing
gabriel_1 has quit [Quit: Lost terminal]
Guest31 is now known as grios
<adambeynon> ylluminarious_: what type of object is `frames`?
ylluminarious has quit [Ping timeout: 264 seconds]
<ylluminarious_> yes
<ylluminarious_> it's used in a method to parse the json data and extract the animation frame data from it
<ylluminarious_> here's where it is in the phaser source code, if you care to look at it more in-depth: https://github.com/photonstorm/phaser/blob/dev/src/animation/AnimationParser.js#L187
<adambeynon> http://opalrb.org/try/#code:some_array%20%3D%20%5B%5D%0A%0A%25x%7B%0A%20%20for(var%20prop%20in%20some_array)%20%7B%0A%20%20%20%20%23%7Bputs%20%60prop%60%7D%3B%0A%20%20%7D%0A%7D
<adambeynon> so `frames` is an array in this case?
<ylluminarious_> well, a comment in the code says that it is, but one of those phaser devs is talking about it like it's not an array :-/
<adambeynon> from that example json it looks like it is showing up as an array, in which case `for (var key in frames)` would includes these additional keys from opal. But its not just opal, it would also include any added functions to Array.prototype, which is quite common
<adambeynon> polyfills etc
<grios> yes, right, when parsing from opal it add those keys (https://gist.github.com/gabrielrios/4e7440f868337ebbfa8e)
<grios> so, this is probably phaser handling it wrong, should be iterating with for(i=0;i<len;i++), as the other dev commented
<adambeynon> yep. for-in isnt a safe assumption for arrays anymore. polyfills are used all the time which would break them
<ylluminarious_> yeah, i think you guys are right
elia has quit [Quit: Computer has gone to sleep.]
<ylluminarious_> adambeynon, alright, well, thanks for the help. i'm gonna wait and see what those phaser devs say.
<adambeynon> ylluminarious_: no problem. I will try and have a look through their code, and the wrapper, later on incase its something obvious im missing
boberetezeke has quit [Ping timeout: 252 seconds]
e_dub has quit [Quit: e_dub]
e_dub has joined #opal
e_dub has quit [Client Quit]
supersym has quit [Quit: WeeChat 1.0.1]
shack4 has quit [Quit: Connection closed for inactivity]
grios has quit [Read error: Connection reset by peer]
Guest31 has joined #opal
Guest31 is now known as grios
grios has quit [Read error: Connection reset by peer]
boberetezeke has joined #opal
e_dub has joined #opal
Guest31 has joined #opal
elia has joined #opal
elia has quit [Quit: Computer has gone to sleep.]
kings has joined #opal
kings is now known as dragonkh
elia has joined #opal
boberetezeke has quit [Ping timeout: 244 seconds]
elia has quit [Quit: Computer has gone to sleep.]
boberetezeke has joined #opal
elia has joined #opal
dragonkh has quit [Quit: Leaving...]
grios has quit [Quit: Textual IRC Client: www.textualapp.com]
boberetezeke has quit [Ping timeout: 244 seconds]
boberetezeke has joined #opal
boberetezeke1 has joined #opal
boberetezeke has quit [Ping timeout: 264 seconds]
jpdo has joined #opal
fkchang has joined #opal
dragonkh has joined #opal
dragonkh has quit [Client Quit]
dragonkh has joined #opal
dragonkh has left #opal [#opal]
e_dub has quit [Quit: e_dub]
fkchang has quit [Remote host closed the connection]
boberetezeke has joined #opal
boberetezeke1 has quit [Ping timeout: 245 seconds]