<shadeslayer>
and I'm a bit lost on how to hook this into the label vfunc now
<bbrezillon>
shadeslayer: because of the extra copy this might generate?
<shadeslayer>
bbrezillon: well, the extra copy is going to be generated anyway, I'm a bit unhappy about the aesthetics of that function signature :P
<shadeslayer>
where I'm copying args->label and the kernel space label
<shadeslayer>
we *could* allocate a new drm_label_object in the ioctl and populate it with the copied string/handle/lenght
<shadeslayer>
*length
<shadeslayer>
and pass that instead
<bbrezillon>
you can just pass the string directly
<bbrezillon>
nevermind, you need the BO handle too
<shadeslayer>
^^
<bbrezillon>
well, maybe letting drivers deal with the copy is fine for now
<bbrezillon>
it's likely to be discussed on the ML anyway
<shadeslayer>
yeah
<bbrezillon>
so just send what you have
<shadeslayer>
bbrezillon: we're still missing the vfunc hook assignment
<bbrezillon>
should be done by drivers
NeuroScr has quit [Quit: NeuroScr]
<shadeslayer>
ohh, so each *driver* would need to allocate that :(
<shadeslayer>
oh well
<bbrezillon>
allocate what?
<shadeslayer>
the vfunc assignment?
<bbrezillon>
the vtable shouldn't be allocated
<bbrezillon>
maybe I'm missing something
<shadeslayer>
bbrezillon: what I meant was that this won't be available to the drivers 'for free'
<shadeslayer>
and that they'd have to opt in
<bbrezillon>
yes, that's pretty much was Thomas was asking for
<shadeslayer>
aha, I see
<bbrezillon>
if you start adding this feature for everyone, that means you ignore the risk reported by Thomas
<shadeslayer>
things make more sense now
<shadeslayer>
right
<bbrezillon>
alyssa, tomeu: what should we do if we find a bug in a deqp test?
<shadeslayer>
rejoice? :P
<bbrezillon>
I just realized some dEQP-GLES2.functional.color_clear.* tests are failing because they don't disable the scissor test
<bbrezillon>
at the end of the ->iterate() method
<bbrezillon>
I mean ColorClearCase::iterate()
<bbrezillon>
and then they do a clear that they expect to cover the whole FB
fysa has joined #panfrost
<shadeslayer>
bbrezillon: v2 sent
davidlt has joined #panfrost
<alyssa>
bbrezillon: ...nice
enunes has quit [Ping timeout: 265 seconds]
enunes has joined #panfrost
<bbrezillon>
alyssa: well, I think it a mix of a bug in panfrost and a bug in deqp
<bbrezillon>
we re-use batches with pre-existing draws in the clear path
<bbrezillon>
but we should probably freeze the existing batch and create a new one in that case
<bbrezillon>
alyssa: doing that fixes 78 tests, but regresses one :-(
<bbrezillon>
weird, the test is NotSupported, but deqp-volt reports it as failed
<bbrezillon>
tomeu: ^
Elpaulo has joined #panfrost
davidlt has quit [Ping timeout: 245 seconds]
davidlt has joined #panfrost
<shadeslayer>
mmmm .... everyone jumping on the labelling bandwagon
<shadeslayer>
confused by what Thomas wants though, surely he could just call drm_gem_set_label with the relevant args?
<bbrezillon>
warpme_: Hi
<bbrezillon>
I tried to compile mythtv
<bbrezillon>
mythtv-setup seems to work here
<bbrezillon>
can you help me reproduce the problem you have?
pH5 has quit [Quit: bye]
jernej has quit [Remote host closed the connection]
jernej has joined #panfrost
fysa has quit [Read error: Connection reset by peer]
raster has quit [Remote host closed the connection]
pH5 has joined #panfrost
yann|work has joined #panfrost
yann|work is now known as yann
<bbrezillon>
warpme_: the commit has been reverted, but I'd still like to understand why the new logic doesn't work
davidlt has quit [Remote host closed the connection]
davidlt has joined #panfrost
stikonas has joined #panfrost
<warpme_>
bbrezillon: regarding mythtv testbed: to reproduce You need: running mythtv backend (server) and mythfrontend (client). For testing on arm he You need compile special branch of mythfrontend (with revorked OpenGL stuff, etc). All this is quite complicated process... To save Your precious time - maybe I can help i.e. by remote testing code changes on my environment (minimyth2 cross-compile build system)?
<bbrezillon>
warpme_: you'll have to revert the revert if you update mesa
<warpme_>
sure. pls give me few min (i'm fixing gstreamer html5 playback on x86_64 arch). Will return to You soon ;-p
belgin has quit [Quit: Leaving]
<warpme_>
bbrezillon: as baseline I compiled current master. it works ok. next i'm trying to apply change You propose and I'm getting: checking file src/panfrost/midgard/midgard_schedule.c
<warpme_>
Hunk #2 FAILED at 687.
<warpme_>
Hunk #1 FAILED at 672.
<warpme_>
2 out of 2 hunks FAILED
davidlt has quit [Ping timeout: 268 seconds]
NeuroScr has joined #panfrost
<warpme_>
bbrezillon: ok I compiled master, revert the revert and applied change: nok (screen is white)
belgin has joined #panfrost
fysa has quit [Read error: Connection reset by peer]