<
triangle345>
also i want to give you guys props for making the windows build so flawless ;)
<
SeanTAllen>
triangle345: every is welcome to open pull requests
<
SeanTAllen>
there is no guarantee that they will be accepted. we might ask for changes etc.
<
SeanTAllen>
but certainly, please yes.
<
SeanTAllen>
we have hoped someone would take this on for a while.
<
SeanTAllen>
triangle345: are you familiar with the GitHub Pull Request workflow?
<
triangle345>
yes i've done it a few times
<
triangle345>
but through github web front end
<
triangle345>
so i have the repo checked out
<
triangle345>
i just push to ponyc right?
<
SeanTAllen>
if you arent a committer, no
<
SeanTAllen>
you want to fork the ponylang/ponyc repo
<
SeanTAllen>
make your changes in your fork
<
triangle345>
ah i see
<
SeanTAllen>
on a branch in your fork
<
SeanTAllen>
and then use the GitHub UI to open a pull request to ponylang/ponyc
<
SeanTAllen>
the reason you want to do it on a branch is so that you can respond to requests for changes easily
<
triangle345>
i see. that makes sense
<
SeanTAllen>
pull requests arent at a point in time
<
SeanTAllen>
but rather, by branch
<
SeanTAllen>
so when you open a PR for a branch, any subsequent changes on that branch will automagically become part of the PR
<
triangle345>
i'l take a look
<
SeanTAllen>
if you have any questions about rebasing, commit comments, etc, let me know
<
triangle345>
sure, thanks for the info. As usual; you are very helpful
<
SeanTAllen>
you're welcome
Matthias247 has quit [Read error: Connection reset by peer]
jemc has quit [Ping timeout: 255 seconds]
prettyvanilla_ has quit [Ping timeout: 240 seconds]
prettyvanilla has joined #ponylang
_whitelogger has joined #ponylang
kr1shnak has quit [Ping timeout: 260 seconds]
kr1shnak has joined #ponylang
kr1shnak has quit [Quit: bye bye]
_whitelogger has joined #ponylang
dougmacdoug has joined #ponylang
jemc has joined #ponylang
IRCFrEAK has joined #ponylang
IRCFrEAK has left #ponylang [#ponylang]
jemc has quit [Ping timeout: 260 seconds]
jemc has joined #ponylang
jemc has quit [Ping timeout: 260 seconds]
graaff has joined #ponylang
jemc has joined #ponylang
<
dougmacdoug>
is there a way to map an actor? my current technique is to wrap it with an id in a 2 element class
<
doublec>
dougmacdoug: do you mean use it as a key in a map?
<
doublec>
dougmacdoug: use digestof
<
doublec>
dougmacdoug: so "digestof anactor" returns an identifier for it
jemc has quit [Ping timeout: 268 seconds]
triangle345 has quit [Ping timeout: 260 seconds]
dougmacdoug has quit [Read error: Connection reset by peer]
Matthias247 has joined #ponylang
prettyvanilla_ has joined #ponylang
prettyvanilla has quit [Ping timeout: 260 seconds]
ChatSharp has joined #ponylang
ChatSharp has left #ponylang [#ponylang]
<
SeanTAllen>
dougmacdoug: you can also use a tag to the actor as the key
jmg_200809701 has joined #ponylang
jmg_200809701 has quit [Max SendQ exceeded]
jmg_20080970 has joined #ponylang
jmg_20080970 has left #ponylang [#ponylang]
Matthias247 has quit [Read error: Connection reset by peer]
jemc has joined #ponylang
jemc has quit [Quit: WeeChat 1.4]
jemc has joined #ponylang
jemc has quit [Ping timeout: 268 seconds]
Matthias247 has joined #ponylang
jemc has joined #ponylang
jemc has quit [Ping timeout: 255 seconds]
jemc has joined #ponylang
jemc has quit [Ping timeout: 255 seconds]
graaff has quit [Quit: Leaving]
K4rolis has joined #ponylang
triangle345 has joined #ponylang
K4rolis has quit [Quit: WeeChat 1.5]