<arigato>
It's a minor change that makes sense so it should be accepted, will do so
<RemoteFox>
oh, thanks
jcea has joined #pypy
Taggnostr has quit [Remote host closed the connection]
Taggnostr has joined #pypy
moei has joined #pypy
<arigato>
RemoteFox: can I still pester you to add a test? it goes to rpython/rlib/test/test_rfile.py in class TestFile, with self.interpret(), to make sure that there are no translation errors (unlikely, but we make very little use of properties in general so better to test that one)
<arigato>
it's fine to insert it into an existing test, too, like test_with_statement(): "assert not f.closed" and "assert f.closed" before and after the with statement, for example
<arigato>
(...before and after the end of the with statement)
<RemoteFox>
arigato: sure, I'll add a test
<RemoteFox>
I've tried translation errors on my own interpreter, but I agree that it is always better to add automated test