solnic changed the topic of #rom-rb to: Ruby Object Mapper | Mailing List: https://groups.google.com/forum/?fromgroups#!forum/rom-rb | Logs: http://irclog.whitequark.org/rom-rb
cored has quit [Ping timeout: 260 seconds]
lfox has quit [Quit: ZZZzzz…]
lfox has joined #rom-rb
lfox has quit [Max SendQ exceeded]
rikai has quit [Read error: Connection reset by peer]
rikai has joined #rom-rb
rikai has joined #rom-rb
rikai has quit [Changing host]
rikai has quit [Ping timeout: 252 seconds]
CraigBuchek has quit [Quit: Leaving.]
rikai has joined #rom-rb
rikai has quit [Changing host]
rikai has joined #rom-rb
rikai has quit [Ping timeout: 248 seconds]
lfox has joined #rom-rb
rikai has joined #rom-rb
rikai has quit [Ping timeout: 246 seconds]
rikai has joined #rom-rb
rikai has joined #rom-rb
namelessjon has quit [Ping timeout: 264 seconds]
namelessjon has joined #rom-rb
lfox has quit [Quit: ZZZzzz…]
skade has joined #rom-rb
skade has quit [Quit: Computer has gone to sleep.]
skade has joined #rom-rb
rikai has quit [Ping timeout: 252 seconds]
rikai has joined #rom-rb
rikai has quit [Changing host]
rikai has joined #rom-rb
rikai has quit [Read error: Connection reset by peer]
rikai has joined #rom-rb
xargoon has quit [Ping timeout: 272 seconds]
postmodern has quit [Quit: Leaving]
xargoon has joined #rom-rb
skade has quit [Read error: Connection reset by peer]
skade has joined #rom-rb
cored has joined #rom-rb
cored has joined #rom-rb
CraigBuchek has joined #rom-rb
bffff has joined #rom-rb
rikai_ has joined #rom-rb
rikai has quit [Ping timeout: 260 seconds]
skade has quit [Quit: Computer has gone to sleep.]
cored has quit [Ping timeout: 252 seconds]
lfox has joined #rom-rb
skade has joined #rom-rb
skade has quit [Read error: Connection reset by peer]
lfox has quit [Quit: ZZZzzz…]
lfox has joined #rom-rb
jgaskins has joined #rom-rb
cored has joined #rom-rb
cored has joined #rom-rb
skade has joined #rom-rb
skade has quit [Read error: Connection reset by peer]
skade has joined #rom-rb
skade has quit [Read error: Connection reset by peer]
skade has joined #rom-rb
skade has quit [Read error: Connection reset by peer]
skade has joined #rom-rb
skade has quit [Read error: Connection reset by peer]
lfox has quit [Quit: ZZZzzz…]
postmodern has joined #rom-rb
rikai_ has quit [Remote host closed the connection]
rikai has joined #rom-rb
cored has quit [Ping timeout: 248 seconds]
cored has joined #rom-rb
cored has joined #rom-rb
cored has quit [Changing host]
jgaskins has quit [Quit: This computer has gone to sleep]
mbj has joined #rom-rb
skade has joined #rom-rb
<postmodern> looking at virtus, it has gotten too complex
<postmodern> ModelBuilder and ModuleBuilder don't seem to add anything
<postmodern> in fact Virtus::Builder can probably be replaced with self.included/self.inherited hooks
<postmodern> also i think it would be more idiomatic to use constant methods
<postmodern> Virtus::Module(options...)
<mbj> postmodern: Just for my interest: How do anima internals look for you?
<mbj> postmodern: For my style virtus does to much, morpher + anima is all I need. But this will not hold for others.
<postmodern> mbj, it looks ok at first
<postmodern> mbj, confused why you use #set/#get methods in the Attribute class
<postmodern> mbj, seems like all anima needs to do is define attr_readers and the #initialize/#eql? methods
<postmodern> mbj, and it appears you copied Virtus::Builder
<mbj> postmodern: no
<mbj> postmodern: I'm not the author of Anima::Builder
skade has quit [Quit: Computer has gone to sleep.]
<mbj> postmodern: I snusnu / dkubb refactored it.
<mbj> postmodern: It was simpler before.
<postmodern> mbj, ah, i would try to refactor Builder into a simple method
<postmodern> mbj, or split it into modules that you inject
<mbj> postmodern: But I did not reviewed that code. I'll take a look.
<mbj> postmodern: BTW IMHO Virtus still has to much responsibilty.
<postmodern> yeah i agree
<mbj> postmodern: to model a domain anima should be enough.
<postmodern> i keep trying to give ideas on how it could be designed differently, since I wrote something similar (parameters)
<mbj> postmodern: Convert external data to domain should not be bound 1:1 to your domain model.
<postmodern> coercions are nice though
<mbj> postmodern: But I think virtus is not only there to model domains. Its mostly used to build form methods.
<postmodern> right virtus is only for defining attributes
<mbj> postmodern: Here it makes sense to have a 1:1 relationship between raw type and domain type.
<mbj> postmodern: You should ping me about a morpher pairing ;)
<postmodern> mbj, take a look at parameters: https://github.com/postmodern/parameters/tree/master/lib/parameters
<mbj> Anyhow, I have to run now (focus on clients work). I took a note to look on parameters.
<postmodern> mbj, most of it is ugly, but i think i nailed how it's injected into modules vs. classes
<postmodern> mbj, for modules, i inject additional included/extended, so it re-includes it self, https://github.com/postmodern/parameters/blob/master/lib/parameters/module_methods.rb
<mbj> postmodern: I'd love to look on it or discuss it now. But I have to run, sorry
mbj has quit [Quit: leaving]
CraigBuchek has quit [Quit: Leaving.]