00:16
TheComrade has joined #rubygems
00:22
DanKnox is now known as DanKnox_away
00:31
vertis has joined #rubygems
01:04
envygeeks has joined #rubygems
01:04
<
envygeeks >
drbrain: Github doesn't support multiple CNAMES in the CNAME file
01:04
<
drbrain >
envygeeks: ok
01:04
<
drbrain >
what should I do?
01:05
<
drbrain >
I reverted the CNAME change so it only has one now
01:06
<
drbrain >
I guess we need a Real Host that can redirect?
01:06
<
envygeeks >
drbrain: if you guys need I can provide a proxy for you via my servers otherwise it might be easier just to have rubygems servers to do it?
01:06
<
drbrain >
probably easier to have the rubygems servers do it
01:06
<
drbrain >
I'll ask evan about setting that up tomorrow
01:07
<
drbrain >
judging by his tweets he's either eating delicious pastries or watching sportsball
01:09
<
envygeeks >
you could also use the nginx buildpack for heroku and do a proxy that way using a custom configuration and avoid needing to use rubygems server
01:09
<
envygeeks >
drbrain: ^
01:09
<
drbrain >
envygeeks: cool
01:10
<
drbrain >
the server hosting docs.rubygems.org died, and I was going to retire it tomorrow anyhow (as guides. has all that now)
01:10
<
drbrain >
I could also host the redirector on my other server, but I'd rather have all this in a rubygems repo somewhere
01:11
<
envygeeks >
that would be mighty easy to fix then, you could setup a repo with gh-pages and do a meta redirect with a simple index.html
01:12
<
drbrain >
but then we'd need a useless docs.rubygems.org repo hanging out in the rubygems org
01:12
<
envygeeks >
I don't mind having useless repos hanging about for a few weeks while ya'll work on more important things and figure out what you want, if docs.rubygems.org already points to github I'll do that up for ya'll
01:13
<
envygeeks >
I mean I'll put it on my account :P
01:13
<
drbrain >
envygeeks: since docs.rubygems.org has been up and down for the past 4 days, I don't think one more will hurt anything :D
01:13
<
envygeeks >
oh fair enough then, if nobody has filed a ticket it's not even worth it
01:13
<
drbrain >
it would be best to have it be 410 Gone with a pointer to guides.rubygems.org than redirecting
01:34
dwradcliffe has joined #rubygems
01:42
dwradcliffe has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
01:44
<
drbrain >
I like that somebody found an important bug the day before an important release
01:44
<
drbrain >
I especially like that the important bug had a very simple fix
02:05
<
envygeeks >
I wish most of the bugs I had to fix were that easy, I've been working on a bug this guy introduced into this software for 7 hours now
02:06
<
drbrain >
fortunately evan's resolver is very clean
02:06
<
drbrain >
so I was able to walk my way back to its source
02:06
<
drbrain >
then over to the test where I was all: oh! … Oh! … OH‼
02:08
<
envygeeks >
It's those kind of moments that make me smile a bit, you know that rare crack in my expressionless face
02:09
<
drbrain >
"we didn't have to do X to the expected value, so why are we doing it to Y?" flashed across my mind
02:09
jcaudle has joined #rubygems
02:45
DanKnox_away is now known as DanKnox
03:08
kgrz has joined #rubygems
03:08
kgrz has quit [Client Quit]
03:08
DanKnox is now known as DanKnox_away
03:10
hakunin has joined #rubygems
03:28
TheComrade has quit [Quit: TheComrade]
03:34
lsegal` has joined #rubygems
03:34
lsegal has quit [Read error: Connection reset by peer]
03:39
lsegal` has quit [Read error: Connection reset by peer]
03:40
lsegal has joined #rubygems
04:11
lsegal` has joined #rubygems
04:11
lsegal has quit [Read error: Connection reset by peer]
04:27
lsegal` has quit [Read error: Connection reset by peer]
04:27
lsegal has joined #rubygems
04:28
envygeeks has left #rubygems [#rubygems]
04:46
randym_ has quit [Quit: Connection closed for inactivity]
04:53
DanKnox_away is now known as DanKnox
04:58
lsegal` has joined #rubygems
04:58
lsegal has quit [Read error: Connection reset by peer]
05:00
jonahR has quit [Quit: jonahR]
05:00
lsegal` has quit [Client Quit]
05:49
JonathanT has joined #rubygems
05:56
yanap_ has joined #rubygems
07:17
dangerousdave has joined #rubygems
07:20
vertis has quit [Ping timeout: 264 seconds]
07:56
dangerousdave has quit [Quit: Leaving...]
08:20
dangerousdave has joined #rubygems
08:42
dangerousdave has quit [Quit: Leaving...]
08:47
adambeynon has joined #rubygems
08:48
vertis has joined #rubygems
08:53
dangerousdave has joined #rubygems
09:39
vertis has quit [Ping timeout: 256 seconds]
09:40
vertis has joined #rubygems
09:42
Elhu has joined #rubygems
10:38
yanap_ has quit [Remote host closed the connection]
11:21
dwradcliffe has joined #rubygems
11:25
tcopeland has quit [Quit: Leaving.]
12:41
jcaudle has quit [Quit: jcaudle]
12:42
huoxito has joined #rubygems
13:01
jcaudle has joined #rubygems
13:20
tcopeland has joined #rubygems
14:06
marpaia has joined #rubygems
14:51
DanKnox is now known as DanKnox_away
15:16
jfoy has joined #rubygems
15:26
rhythm_and_code has quit [Quit: rhythm_and_code]
15:42
rhythm_and_code has joined #rubygems
16:58
Elhu has quit [Quit: Computer has gone to sleep.]
16:59
Elhu has joined #rubygems
16:59
Elhu has quit [Client Quit]
17:13
DanKnox_away is now known as DanKnox
17:24
DanKnox is now known as DanKnox_away
17:35
jfoy has quit [Quit: jfoy]
17:35
dwradcliffe has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
17:38
DanKnox_away is now known as DanKnox
17:38
havenwood has joined #rubygems
17:43
dangerousdave has quit [Read error: Connection reset by peer]
17:43
dangerousdave has joined #rubygems
17:45
dangerousdave has quit [Client Quit]
17:49
dangerousdave has joined #rubygems
17:49
jaimef has quit [Excess Flood]
17:51
rhythm_and_code has quit [Quit: rhythm_and_code]
17:51
jaimef has joined #rubygems
18:07
Elhu has joined #rubygems
18:14
huoxito has quit [Quit: Leaving]
18:16
rhythm_and_code has joined #rubygems
18:27
TheComrade has joined #rubygems
18:28
sferik has joined #rubygems
18:36
dangerousdave has quit [Quit: Leaving...]
18:51
havenwood has quit [Remote host closed the connection]
18:51
DanKnox is now known as DanKnox_away
18:51
havenwood has joined #rubygems
18:53
DanKnox_away is now known as DanKnox
18:55
havenwood has quit [Read error: Connection reset by peer]
18:56
havenwood has joined #rubygems
18:56
havenwood has quit [Read error: Connection reset by peer]
18:56
havenwood has joined #rubygems
18:58
jonahR has joined #rubygems
19:02
dangerousdave has joined #rubygems
19:07
dangerousdave has quit [Read error: Connection reset by peer]
19:07
Dave-_ has joined #rubygems
19:23
tbuehlmann has joined #rubygems
19:27
Elhu has quit [Quit: Computer has gone to sleep.]
19:29
dangerousdave has joined #rubygems
19:29
Dave-_ has quit [Read error: Connection reset by peer]
19:29
jfoy has joined #rubygems
19:32
jfoy has quit [Client Quit]
19:46
Elhu has joined #rubygems
19:56
jonahR has quit [Quit: jonahR]
20:00
jonahR has joined #rubygems
20:00
jonahR has quit [Client Quit]
20:07
Elhu has quit [Quit: Computer has gone to sleep.]
20:10
Elhu has joined #rubygems
20:10
Elhu has quit [Client Quit]
20:18
mando has joined #rubygems
20:18
mando has quit [Remote host closed the connection]
20:19
mando has joined #rubygems
20:36
jonahR has joined #rubygems
20:39
tcopeland has quit [Quit: Leaving.]
20:56
jfoy has joined #rubygems
21:02
jcaudle has quit [Quit: jcaudle]
21:14
martinisoft has joined #rubygems
21:21
marpaia has quit [Quit: WeeChat 0.4.1]
21:21
marpaia has joined #rubygems
21:26
huoxito has joined #rubygems
21:27
tbuehlmann has quit [Remote host closed the connection]
21:47
sferik has joined #rubygems
21:49
<
drbrain >
evan: ping
21:50
<
drbrain >
regarding #637, I'm inclined to lean towards headius
21:50
<
drbrain >
I think the contract should be around activation and modifying $LOAD_PATH
21:51
<
evan >
lean towards in what way? merge it?
21:51
<
drbrain >
if we have the lock cover "I want this gem" to "$LOAD_PATH is ready to require that gem" that should be enough, rigth?
21:51
<
drbrain >
yes, merge it
21:51
<
drbrain >
but I'm not sure my idea (above) is the one in the patch
21:52
<
drbrain >
the lock doesn't prevent some other party from modifying $LOAD_PATH anyhow, it just makes sure rubygems is consistent inside
21:52
vertis has quit [Quit: Leaving.]
21:52
<
evan >
his patch keeps $LOAD_PATH manipulation locked
21:52
<
evan >
so it's consistent
21:53
<
drbrain >
if we just want rubygems to not stomp itself the behavior change is just an implementation detail we're free to modify, correct?
21:53
<
evan >
the case he's talking about exposes where threads activate different gems
21:53
<
evan >
and because of the unlocking, they'd pick up files from eachothers paths
21:53
<
evan >
but thats not an issue
21:53
<
evan >
now that I think about it
21:54
<
evan >
because that can't happen with the way we manage $LOAD_PATH
21:54
<
drbrain >
yes ↑ that's what I was thinking
21:54
<
drbrain >
I'll summarize our discussion
21:54
<
drbrain >
then merge
22:00
marpaia has quit [Quit: WeeChat 0.4.1]
22:00
<
drbrain >
I am going to rename Gem.resolve! to Gem.resolve
22:05
<
drbrain >
hrm, test failure
22:09
tcopeland has joined #rubygems
22:16
tjbiddle has joined #rubygems
22:20
jstr has joined #rubygems
22:20
<
drbrain >
oh, I see what's wrong
22:21
<
drbrain >
the LoadError handler was moved out of Kernel#require
22:21
<
drbrain >
which it depends upon to work correctly
22:27
<
drbrain >
evan: I think we might need more use of the monitor
22:27
<
drbrain >
what about Gem.needs?
22:28
<
drbrain >
I think anywhere Gem::Specification#activate is called
22:28
<
evan >
I want to refactor things
22:28
<
drbrain >
I'm unsure
22:28
<
evan >
to make the locking much clearer
22:28
<
evan >
rather than ploping down monitors all over
22:28
<
evan >
basically, the global state needs to pulled out into something that contains the sychronization
22:28
<
drbrain >
I'm adding it to try_activate because we need to cover that for headius' refactor
22:28
<
evan >
I don't want to go back to SourceIndex
22:29
<
evan >
but just something that is internal only that can do the locking
22:29
<
drbrain >
SourceIndex was a five things in one class
22:29
<
evan >
it needs to be in try_activate.
22:30
<
evan >
what is the 2.1 timeframe?
22:30
<
drbrain >
just around the begin/rescue/end, or the whole method though?
22:30
<
evan >
I can carve out some time to start the refactoring
22:30
<
drbrain >
since the activated? flag is set after it's in $LOAD_PATH it seems fine
22:30
<
drbrain >
I want to release 2.1 today
22:31
<
evan >
then we should not to headius change.
22:31
<
evan >
we need to put it through more rigor
22:31
<
drbrain >
ok, I'll roll it back
22:31
<
evan >
given this is a non-API change, we can roll it out in 2.1.1
22:32
<
evan >
i'd rather we can futz with it
22:32
<
evan >
esp since you'll want to merge 2.1 to ruby-core I suspect
22:32
<
drbrain >
for the security issue, yes
22:33
<
drbrain >
at least I can commit this work and git format-patch it to add to #637
22:38
sferik has quit [Quit: Computer has gone to sleep.]
22:39
<
drbrain >
how do I revert this merge properly?
22:39
<
drbrain >
I'm reading git revert's -m option but it is only confusing me
22:40
<
drbrain >
or do I just revert the one commit?
22:41
<
evan >
-m takes the sha1 of the thing you want to revert to
22:41
<
evan >
it's actually a 0 or 1
22:41
<
evan >
you're selecting the parent
22:41
<
evan >
you want to select his commit
22:41
sferik has joined #rubygems
22:41
<
evan >
merge reversion is confusing
22:42
<
drbrain >
which one is 0 and which one is 1?
22:42
<
evan >
do 'git show'
22:42
<
evan >
the order they're listed
22:42
<
evan >
is the order.
22:43
<
evan >
git revert -m 1 HEAD
22:43
<
evan >
is what you want
22:43
<
evan >
it's 1 indexed
22:43
<
evan >
AND you select the branch you want to retain
22:43
<
evan >
not the one to revert
22:43
<
evan >
I just did it locally
22:43
<
evan >
I can push if you want.
22:44
<
drbrain >
I find it odd I can't pick the mainline by SHA
22:44
<
evan >
I think so that you can't pick random SHA1s
22:44
<
evan >
though it could just validate it
22:44
<
evan >
git be crazy that way.
22:45
jaimef has quit [Excess Flood]
22:50
jaimef has joined #rubygems
23:00
jonahR has quit [Quit: jonahR]
23:04
dangerousdave has quit [Ping timeout: 264 seconds]
23:05
mando has quit [Remote host closed the connection]
23:09
havenn has joined #rubygems
23:09
tjbiddle_ has joined #rubygems
23:09
havenn is now known as havenwood_
23:10
havenwood has quit [Read error: Connection reset by peer]
23:10
tjbiddle has quit [Read error: Connection reset by peer]
23:10
tjbiddle_ is now known as tjbiddle
23:10
akahn has quit [Ping timeout: 256 seconds]
23:10
ckrailo has quit [Ping timeout: 256 seconds]
23:10
havenwood_ is now known as havenwood
23:15
revans has joined #rubygems
23:23
tjbiddle_ has joined #rubygems
23:26
tjbiddle has quit [Ping timeout: 240 seconds]
23:26
tjbiddle_ is now known as tjbiddle
23:29
vertis has joined #rubygems
23:30
vertis has quit [Client Quit]
23:30
vertis has joined #rubygems
23:31
vertis1 has joined #rubygems
23:31
vertis has quit [Read error: Connection reset by peer]
23:46
jaimef has quit [Excess Flood]
23:54
jaimef has joined #rubygems