19:30 <systems_glitch> question about extending the base functionality of Cinch::IRC

19:30 <systems_glitch> i want to add support for LIST (numerics 321, 322, 323)

19:30 <systems_glitch> is this best done in a plugin, or should i submit a pull request with my changes?

19:42 <dominikh> depends what you maen by "add support for LIST"

19:42 <systems_glitch> i mean nothing responds to those numerics right now

19:43 <systems_glitch> i've implemented for my project by monkey patching Cinch::IRC and Cinch::Network to respond to LIST and store the results on the network

19:44 <dominikh> on the majority of networks, doing a "LIST" is a sure way to get yourself flooded off the network, so I probably don't want to provide a method to do that

19:45 <systems_glitch> that's a good point, you'd get swamped on freenode

19:56 <dominikh> also not sure what'd happen if someone ran LIST twice concurrently; we couldn't tell the lists apart

19:59 <systems_glitch> due to the way i implemented storage of the LIST results, it would just update existing entry in a channels hash, or add them if they didn't exist

20:00 <dominikh> and what about removing ones that disappeared?

20:01 <systems_glitch> it starts with a new hash when it received 321 RLP_LISTSTART

20:02 <systems_glitch> so i guess in the case of a double concurrent call, you might empty the hash after some channels had been inserted

20:02 <systems_glitch> but you'd end up with all of them in the end

20:02 <onewheelskyward> oi

20:03 <onewheelskyward> Given the time it takes to complete a list you should consider blocking concurrent calls.

20:03 <dominikh> multiple LIST calls should be coalesced, yeah. either way, I'm not sure it'd make sense to add that to Cinch itself, considering how rarely using LIST is desirable

20:18 <systems_glitch> we're using it for a stats page for the irc server

20:18 <systems_glitch> i'm trying to replace an ancient Perl bot

20:19 <dominikh> ah

20:19 <dominikh> well, it's easily doable as a plugin, giving your needs

20:20 <dominikh> *given

20:21 <systems_glitch> yep, i've started wrapping it up in a plugin

21:19 <systems_glitch> any recommendation on registering new numeric response handlers in Cinch::IRC without monkey patching?

21:19 <systems_glitch> looks like i could hook :catchall but that seems inefficient

21:31 <dominikh> systems_glitch: what do you mean?

21:31 <dominikh> you don't need to add anything to Cinch::IRC to handle numerics in your plugins.

21:42 <systems_glitch> no? how do i listen for them?

21:43 <dominikh> listen_to "123". or listen_to Cinch::Constants::RPL_WHATEVER.to_s

21:43 <systems_glitch> d'oh

21:43 <systems_glitch> so since i got a crash course in non-super-trivial Cinch today, i'll be submitting PRs for documentation :D

21:44 <dominikh> heh

21:44 <dominikh> make em good

23:55 <systems_glitch> https://github.com/chapmajs/cinch_channel_list

23:55 <systems_glitch> thanks for the help!

23:55 <dominikh> no problem

23:55 <dominikh> looks sensible enough

23:56 <systems_glitch> thanks...it replaces a pile of Perl that relied on Net::IRC (abandoned in 2004)