dominikh changed the topic of #cinch to: The IRC Framework | Latest version: Cinch 2.3.0
<dominikh>
leftylink: want to test the master branch and see if logging works properly?
Rickmasta has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
Rickmasta has joined #cinch
<leftylink>
ok, doing it
<leftylink>
dominikh: ok, good on exceptions (can see stack traces and stuff, unlike the stupid hack fix I was doing to fix my own stuff), I'm at least good on any incoming/outgoing log types, I'm not sure what else this code tests, I probably got info (the yellow exclamation marks that say [New thread] and [Thread done])
<leftylink>
oh wait info is probably the II, yeah I have thos etoo
<dominikh>
okay, thanks. yeah, it should all work now.
<leftylink>
I was being a bit silly in my "I can't determine whether I actualy tested all log message types", I realized. because you know what I can do? I can just call ALL THE METHODS
<leftylink>
let's go
<leftylink>
but really, I don't expect there will be any problems since the important ones have been attended to
<leftylink>
but just in case I guess
<leftylink>
well I will tell you that format_fatal is no good
<leftylink>
since there no such thing
<dominikh>
yeah, that one's an old bug. will probably turn it into a NOP eventually, as it won't be in Cinch 3
<dominikh>
#exception is also not working correctly, as it doesn't print a stacktrace. that's another unrelated bug and result of an underlying design issue
<leftylink>
#error is apparently not prefixed with anything
<leftylink>
well ok I get
<leftylink>
[ExceptionPlugin] error
<leftylink>
handler body is %i(debug error info warn incoming outgoing).each { |s| send(s, s.to_s) }
<dominikh>
I guess I can fix it in 2.3.1 while I'm at it
<leftylink>
yeah ok seeing what you mean with #exception not showing the stack traces. didn't test that one specifically, interesting
<leftylink>
I don't usually think about that because that `rescue_exceptions` thing is usually handling exception stuff I guess
<dominikh>
working on an experimental Cinch 3 rewrite of the logging right now, to show you how much simpler and more well-behaving the code could be.
<Lilian>
cinch!
<Lilian>
oh wow I'm totally in the wrong channel
<Lilian>
Thought someone in a completely unrelated channel was discussing cinch. >_>
<dominikh>
nope, not that popular :P
<leftylink>
I kind of want to wonder though - is it called cinch because "it's a cinch" or some other reason
<Lilian>
Ha, damn.
<Lilian>
All in due time, dominikh!
<dominikh>
leftylink: it's called Cinch because I forked Isaac (before realising it needed a complete rewrite) and called it Newton (ignoring that Isaac was named after the singer, not the physician). At the same time, Lee Jarvis had an IRC framework called Cinch. I convinced him to merge efforts. We took my code and his name. ANd now I'm stuck with this awful name ;)
<dominikh>
leftylink: but yes, he named it after "it's a cinch"
<dominikh>
and physicist, not physician, obviously.
<Lilian>
Ha, now I'm picturing Issac Newton giving a routine medical exam.
<dominikh>
no wonder he was so amazed by that apple, too.
<dominikh>
leftylink: http://sprunge.us/jECK this is a rough sketch of the first iteration of logger changes I'd do in Cinch 3
Guest80946 is now known as BlindSight
Rickmasta has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
Azure has quit [Ping timeout: 260 seconds]
Rickmasta has joined #cinch
Azure has joined #cinch
Rickmasta has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
<leftylink>
... this is going to be an interesting one to figure out. Specifically for a plugin named Alarm, enable_acl is not registering the hook (check_acl is most definitely not getting called). Does it matter that Alarm is alphabetically first of all the plugins? Well I don't know. No other plugin is affected, and when I remove Alarm from the list, still no other plugin is affected
<leftylink>
however... if I plugin reload Alarm... then the hook is there
<leftylink>
wat.
<dominikh>
a while ago, someone complained about hooks not working for one plugin; but couldn't reproduce it in a minimal example.
<leftylink>
this is pretty tough. I may have to break for now and revisit in a few hours
<leftylink>
next idea, what if I make Alarm the only plugin...
<leftylink>
ok, still no hook. we are getting somewhat closer...
Rickmasta has joined #cinch
waxjar has quit [Remote host closed the connection]
<tinnvec>
I'd be interested to help in 3.0 if there's a touch of direction, I'm somewhat new to ruby though I've been coding for almost 20 years
<tinnvec>
Mosly I'd like direction because I don't know quite enough about Cinch to know exactly what needs to be fixed/changed
<dominikh>
guys, don't take my request for help too seriously :) the coding part is insignificant, the real work is in the design; and I'd have to do that one myself anyway
<tinnvec>
But I'm happy to lend my keyboard to whatever will help, it's the least I can do as a thanks for the software
<tinnvec>
very true, dominikh, I just like to be helpful heh
<tinnvec>
plus a bit of ruby practice won't hurt
<dominikh>
on the contrary, too much ruby can hurt your sanity :)
<tinnvec>
lol, I'm a web developer by trade, not sure I have much of that left
<dominikh>
unlikely :P
<tinnvec>
at least here I get to use non-rails ruby
<dominikh>
I heard that some people use activerecord with their cinch bots
<tinnvec>
I use the activesupport for it's time stuff, but not activerecord
<tinnvec>
though I suppose if you wanted to do something like logging to a db for a searchable chat history from a web page
<tinnvec>
different strokes
<dominikh>
might as well just use a DB connector and write some SQL ;)
<tinnvec>
heh yeah
<tinnvec>
at least it's not entity framework
<tinnvec>
that's my hell every weekday, we're all C# here at work
<dominikh>
sounds like you're living a difficult life
<tinnvec>
wouldn't have it any other way, i suppose, I like solving problems/puzzles
<tinnvec>
probably why i enjoy coding in the first place
<tinnvec>
that and I'm just so lazy
<dominikh>
sure, but would be nicer if the puzzle isn't "how do I work around bad frameworks and languages"
<tinnvec>
lol, very true
<tinnvec>
I suppose that's a larger question of "why are there so many terrible frameworks?"
<dominikh>
and why do people use them.
<tinnvec>
bit of self deprecation?
<tinnvec>
(cinch being a framework and all)
<dominikh>
Cinch is pretty flawed, but I wouldn't call it terrible :P
<tinnvec>
haha yeah, definitely not terrible
<leftylink>
ok here we go
<leftylink>
http://sprunge.us/PXZO - response to !alarm is "BEEP BEEP BEEP. Did I check the ACL? NOPE"
<dominikh>
will take a look after I'm done with this Isaac run
<leftylink>
this is a deeper dive into the __hooks method than I had bargained for
<leftylink>
I think I am starting to get an idea of what's going on though.. the select! is clearing out an array
<leftylink>
yeeeeeeeeeeeeeeah
Rickmasta has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
<leftylink>
that... is... unfortunate.
<dominikh>
what is
<leftylink>
it's... just a nasty surprise
<leftylink>
just a second
<dominikh>
ah. stuff like that is why I hate Ruby.
<leftylink>
will send PR
<leftylink>
though really it's one line, so you could conceivably beat me to it. but I'm going to add supporting notes
<dominikh>
I hope the notes aren't in the form of comments :)
<leftylink>
well, perhaps it would be useful to have one line in comment saying "don't use #select!, use #select". I was going to put the rest in commit message
<dominikh>
no need for a comment. maybe need for a beating, or a saner language, but a comment would just be noise
<dominikh>
might as well have a comment saying "don't call exit" ;)
<leftylink>
veeery well
<leftylink>
well by this point you probably could have done it yourself. but there you go
<dominikh>
yes, yes I could have :P
<leftylink>
should hvae just let you do it
<dominikh>
yes, yes you should have
<dominikh>
merged.
<dominikh>
I'll probably cut a new release when I wake up
<leftylink>
let's see... that select! has been around for a little over 2 years now. that's fun. guess nobody used event-specific hooks enough to notice
<leftylink>
I'm just on master all the time!!!
<leftylink>
okay not really, only recently. I usually just stay on releases
<dominikh>
let's hope so. it's quite the security issue if used in combination with ACLs
<dominikh>
recently, master and releases tend to be the same ;)
<leftylink>
so I guess what was happening when I did the plugin reload was...
<leftylink>
the acl hook was killing the connect hook instead of the other way around
<leftylink>
so my reconnect behavior would have been broken... well... not very likely that I'd notice that
<leftylink>
and kinda random chance that I noticed the acl thing - just hard to notice because well, I'm on the acl, so I see no difference