<
anarsoul>
MoeIcenowy: are you OK with me merging it?
<
anarsoul>
I preserved commit authorship for your changes
<
MoeIcenowy>
anarsoul: it's okay
<
MoeIcenowy>
but did we really fix nothing?
<
anarsoul>
it fixed 21 tests
<
anarsoul>
see the diff
<
anarsoul>
depth/stencil reload now works fine
<
anarsoul>
Z16 doesn't work but blob uses Z24 for the same tests, so I just dropped Z16 support for now
<
MoeIcenowy>
anarsoul: mesa will fake Z16 for us, right?
<
anarsoul>
yes, it promotes it to Z24
<
MoeIcenowy>
okay this MR looks good
<
MoeIcenowy>
do you want my Rb at Z16 patch?
<
anarsoul>
I wonder what's wrong with dEQP-GLES2.functional.fbo.render.shared_depthbuffer.* tests...
<
anarsoul>
they don't need depth/stencil reload
<
anarsoul>
could be missing dependency
<
MoeIcenowy>
do they fail on blob?
<
anarsoul>
they pass
<
MoeIcenowy>
BTW, how do we know `Blob uses L16 for Z16` ?
<
anarsoul>
err, check for texture format in corresponding test?
<
anarsoul>
we dump texture descriptors thanks to rellla :)
<
anarsoul>
L16 and Z16 are identical for sampling
<
MoeIcenowy>
I do not want to verify it now
<
MoeIcenowy>
I just wonder why we think so
<
MoeIcenowy>
(if we see Z24S8 in Z16 tests)
<
anarsoul>
both return (L,L,L,1.0) or (Z,Z,Z,1.0)
<
anarsoul>
MoeIcenowy: IIRC I saw it with glmark2 -b shadow
<
anarsoul>
with r6p2 blob
<
anarsoul>
MoeIcenowy: btw please also review my changes to your commit
<
anarsoul>
looks like it's necessary to initialize clear->depth with 0xffffff when we reload depth
<
anarsoul>
otherwise it doesn't work
<
anarsoul>
guess it still does depth test?
<
anarsoul>
depth func is 'always' (0x7)
<
anarsoul>
I'll let !4197 sit for a day in case if others want to take a look
<
anarsoul>
btw q3a is definitely pp-bound
marcodiego has quit [Quit: Leaving]
buzzmarshall has quit [Remote host closed the connection]
dddddd has quit [Ping timeout: 240 seconds]
_whitelogger has joined #lima
wiewo has quit [Ping timeout: 240 seconds]
wiewo has joined #lima
_whitelogger has joined #lima
_whitelogger has joined #lima
kaspter has quit [Ping timeout: 255 seconds]
kaspter has joined #lima
chewitt has quit [Read error: Connection reset by peer]
chewitt has joined #lima
chewitt has quit [Read error: Connection reset by peer]
Elpaulo has quit [Quit: Elpaulo]
_whitelogger has joined #lima
kaspter has quit [Remote host closed the connection]
kaspter has joined #lima
camus1 has joined #lima
kaspter has quit [Ping timeout: 260 seconds]
camus1 is now known as kaspter
dddddd has joined #lima
drod has joined #lima
yann has quit [Ping timeout: 260 seconds]
buzzmarshall has joined #lima
<
anarsoul>
rellla: hey
<
anarsoul>
so regarding !4197 -- we don't dump rsw nor texture descriptor for reload
<
anarsoul>
I think I'll better fix it with a separate MR
<
anarsoul>
that adds rsw/td dumping of reload and iterates over td array to dump all the tds
yann has joined #lima
narmstrong has quit [*.net *.split]
romangg has quit [*.net *.split]
narmstrong has joined #lima
romangg has joined #lima
<
anarsoul>
see new commit
<
plaes>
there are no BIT(x) macros in mesa?
<
anarsoul>
plaes: quick grepping shows that vc4 defines its own
<
plaes>
yeah, all of them define their own :S
xexaxo1 has quit [*.net *.split]
xexaxo1 has joined #lima
<
plaes>
actually, it seems it's only freedreno and vc4
yann has quit [Ping timeout: 258 seconds]
yann has joined #lima
mmind00 has joined #lima
cwabbott has joined #lima
warpme_ has quit [Quit: Connection closed for inactivity]
drod has quit [Remote host closed the connection]