drbrain changed the topic of #rubygems to: RubyGems 2.1.11: http://bit.ly/rubygems-2-1-11 CVE-2013-4363: http://bit.ly/CVE-2013-4363 - Latest status: http://twitter.com/rubygems_status and http://status.rubygems.org
imperator has quit [Ping timeout: 246 seconds]
huoxito has joined #rubygems
<indirect> drbrain: no, bundler does not automatically include itself in a lockfile, but since eg Rails depends on bundler, it is in most lockfiles
huoxito has quit [Ping timeout: 246 seconds]
<ddd> indirect: what is the purpose of that? Correct me if my chain is wrong. You need bundler to read the Gemfile and install (unless you write your own script to do so.) any gems listed. Since you already have bundler installed, what's the purpose of bundler including itself in the Gemfile since bundler can read even older Gemfiles. (Not arguing or anything, genuinely curious as to the purpose)
<indirect> ddd: I just said that bundler doesn't include itself?
<ddd> seems like the cart before the horse or chicken and the egg
<ddd> no I meant in the lockfile
<ddd> whats the purpose of bundler being in the lockfile
<ddd> if i should 'get' this, i apologize in advance. i just don't
<indirect> I'm not even sure what the question is
<indirect> are you saying that you think we should have written code to explicitly drop bundler from the list of gems rails says it depends on?
<indirect> like, rails says it depends on bundler (and it does, rails new runs bundle install)
<indirect> bundler, in the lockfile, lists the dependencies of the gems
<indirect> including that rails says it needs bundler
<indirect> why would we go out of our way to remove it from the lockfile? :/
<ddd> ok, you reminded me of rails running bundler. that explains it. I was wondering why it was listed at all in the lockfile.
<ddd> indirect: wacky question to you, i realize. and sorry for that. you explained what i was wondering just didn't seem able to word it right to make sense.
<indirect> haha no worries
<indirect> just trying to explain
<indirect> like, we would have had to add special code to get rid of it
<indirect> and there is no special code that adds it
<indirect> so it seems fine to me
<ddd> yeah, wasn't arguing *against* it perse. was trying to figure out why it was there in the first place (in lock but not Gemfile directly)
<ddd> makes perfect sense once you reminded me rails automatically does a bundle install
baburdick has quit [Quit: Leaving.]
jonahR has joined #rubygems
havenwood has joined #rubygems
tcopeland has joined #rubygems
Briareos1 has quit [Remote host closed the connection]
josh-k has quit [Remote host closed the connection]
hone has quit [Ping timeout: 260 seconds]
josh-k_ has joined #rubygems
josh-k_ has quit [Remote host closed the connection]
baburdick has joined #rubygems
josh-k has joined #rubygems
josh-k has quit [Ping timeout: 240 seconds]
jfoy has quit [Quit: jfoy]
rafaelfranca has quit []
huoxito has joined #rubygems
lsegal has joined #rubygems
huoxito has quit [Remote host closed the connection]
arohner has quit [Remote host closed the connection]
arohner has joined #rubygems
arohner has quit [Ping timeout: 250 seconds]
coder_neo has joined #rubygems
coder_neo has quit [Client Quit]
arohner has joined #rubygems
hone has joined #rubygems
josh-k has joined #rubygems
arohner has quit [Remote host closed the connection]
arohner has joined #rubygems
havenwood has quit [Remote host closed the connection]
josh-k has quit [Remote host closed the connection]
arohner has quit [Ping timeout: 260 seconds]
havenwood has joined #rubygems
jonahR has quit [Quit: jonahR]
Who has joined #rubygems
Who_ has joined #rubygems
Who has quit [Ping timeout: 246 seconds]
Who_ is now known as Who
Who has quit [Read error: Connection reset by peer]
Who has joined #rubygems
baburdick has quit [Quit: Leaving.]
hone has quit [Ping timeout: 250 seconds]
Who has quit [Ping timeout: 240 seconds]
Who has joined #rubygems
josh-k has joined #rubygems
josh-k has quit [Remote host closed the connection]
josh-k has joined #rubygems
baburdick has joined #rubygems
tbuehlmann has joined #rubygems
baburdick has quit [Ping timeout: 246 seconds]
Who has quit [Quit: Who]
Who has joined #rubygems
Who has quit [Quit: Who]
Who has joined #rubygems
lsegal has quit [Read error: Connection reset by peer]
lsegal has joined #rubygems
Who has quit [Quit: Who]
baburdick has joined #rubygems
baburdick has quit [Client Quit]
Briareos1 has joined #rubygems
lsegal has quit [Quit: Quit: Quit: Quit: Stack Overflow.]
josh-k has quit [Remote host closed the connection]
baburdick has joined #rubygems
baburdick has quit [Ping timeout: 240 seconds]
havenwood has quit [Remote host closed the connection]
Briareos1 has quit [Read error: Connection reset by peer]
Briareos1 has joined #rubygems
Who has joined #rubygems
Who_ has joined #rubygems
Who has quit [Ping timeout: 240 seconds]
Who_ is now known as Who
mpapis has joined #rubygems
imperator has joined #rubygems
huoxito has joined #rubygems
Briareos1 has quit [Remote host closed the connection]
darix has quit [Ping timeout: 264 seconds]
darix has joined #rubygems
<Who> drbrain: there?
havenwood has joined #rubygems
bbrowning_away has quit [Quit: Leaving]
baburdick has joined #rubygems
baburdick has quit [Ping timeout: 240 seconds]
tbuehlmann has quit [*.net *.split]
danmcclain has quit [*.net *.split]
dvu has quit [*.net *.split]
marpaia has quit [*.net *.split]
sindork has quit [*.net *.split]
Alasdairr has quit [*.net *.split]
wizonesolutions_ has quit [*.net *.split]
huoxito has quit [Remote host closed the connection]
imperator has quit [Ping timeout: 246 seconds]
danmcclain has joined #rubygems
tbuehlmann has joined #rubygems
marpaia has joined #rubygems
sindork has joined #rubygems
Alasdairr has joined #rubygems
dvu has joined #rubygems
wizonesolutions_ has joined #rubygems
Who has quit [Quit: Who]
tcopeland1 has joined #rubygems
josh-k has joined #rubygems
tcopeland has quit [Ping timeout: 246 seconds]
Who has joined #rubygems
josh-k has quit [Ping timeout: 260 seconds]
graphex has quit [Quit: ZNC - http://znc.in]
Who has quit [Ping timeout: 240 seconds]
Who has joined #rubygems
Briareos1 has joined #rubygems
baburdick has joined #rubygems
graphex has joined #rubygems
baburdick has quit [Ping timeout: 252 seconds]
graphex has quit [Quit: ZNC - http://znc.in]
graphex has joined #rubygems
imperator2 has joined #rubygems
arohner has joined #rubygems
havenwood has quit [Remote host closed the connection]
huoxito has joined #rubygems
huoxito has quit [Ping timeout: 252 seconds]
imperator2 has quit [Quit: Leaving]
baburdick has joined #rubygems
baburdick has quit [Ping timeout: 240 seconds]
redmenace has joined #rubygems
josh-k has joined #rubygems
havenwood has joined #rubygems
havenwood has quit [Read error: Connection reset by peer]
hone has joined #rubygems
hone has quit [Ping timeout: 240 seconds]
havenwood has joined #rubygems
seanlinsley has quit [Quit: seanlinsley]
seanlinsley has joined #rubygems
hone has joined #rubygems
nomadic has quit [Ping timeout: 245 seconds]
nomadic has joined #rubygems
pglombardo has joined #rubygems
pglombar_ has joined #rubygems
pglombardo has quit [Ping timeout: 246 seconds]
ddd has quit [Ping timeout: 272 seconds]
<drbrain> Who: hello
hone has quit [Ping timeout: 252 seconds]
<Who> drbrain: hey, so I am trying to fix gem corruption bug in bundler 1.5rc
<Who> I heard you got reports of it
<drbrain> yes, but not enough to reproduce it
<drbrain> I've seen reports here of people having `gem install x` install gem y
<drbrain> and the common theme is that they are running 1.5rc
<Who> the thing is, I can figure out how it can happen on jruby
<Who> but I have been racking my brain for last few hours on how it can occur on the unix worker part
* drbrain nods
<drbrain> I haven't asked which ruby people are using
<Who> ah
<Who> because since forked processes are not using any threads at all (the parent is though), its quite bizarre how gem download is getting affected
<drbrain> yup
<Who> I looked if it was using global IO.pipe or something, but it wasn't.
<drbrain> could it be running multithread instead of multiprocess?
<Who> there is prepare_threads method but that's only used by the parent
<Who> the queues are thread-safe ones
baburdick has joined #rubygems
baburdick has quit [Client Quit]
<Who> drbrain:
<Who> maybe I found the problem
<drbrain> ?
<Who> worker = @workers[i]
<Who> this is under thread.start
<Who> arrays aren't thread safe
<Who> I wrote a small prog to test it
<Who> if I remove the print statement
<Who> it gives me the correct output
<Who> wonder if I am making some silly mistake
<drbrain> ↑ should be fine as the array is not being altered, just read
<Who> well can you look at my paste
<drbrain> yes, you're pushing items though
<drbrain> oh, I see
<drbrain> ontot he queue
<Who> yep
hone has joined #rubygems
<Who> so when print satement is there
<Who> #<Queue:0x007fd42c02e010 @que=[1, 0], @num_waiting=0, @mutex=#<Mutex:0x007fd42c02dfc0>, @cond=#<ConditionVariable:0x007fd42c02df70 @waiters={}, @waiters_mutex=#<Mutex:0x007fd42c02de
<Who> and when its not
<Who> #<Queue:0x007ffcda82d550 @que=[0, 1, 3, 4, 5, 6, 8, 7, 9, 10, 11, 12, 13, 15, 14, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99], @num_waiting=0,
<Who> @mutex=#<Mutex:0x007ffcda82d500>, @cond=#<ConditionVariable:0x007ffcda82d4b0 @waiters={}, @waiters_mutex=#<Mutex:0x007ffcda82d410>>>
<Who> though obviously there is no IO operation in that method
<drbrain> I don't think this matters
<drbrain> with the IO operation you stall the writing threads on IO
<drbrain> so you print the size of the queue before the IO is complete
<drbrain> without the IO operation you (probably) print the size of the queue after the threads are all complete
<drbrain> probably -> usually
<Who> ah correct
<Who> should have put it after the join
ddd has joined #rubygems
arohner has quit [Ping timeout: 240 seconds]
<Who> drbrain: so I guess its better to wait on MRI/UnixWorker part
<Who> get better information if this issue crops up again
arohner has joined #rubygems
hone has quit [Ping timeout: 260 seconds]
<drbrain> it could be some bug in the rubygems part, too
<drbrain> when the bundler code calls into the rubygems fetcher there are some shared variables there
<drbrain> I wonder if they got poisoned somehow
<Who> well, indirect wrote a work around that this morning https://github.com/bundler/bundler/commit/61deea74d10fe7b170790230671d8d170f139038
<Who> basically new fetcher for each download
* drbrain nods
<Who> I guess as soon as we notice someone reporting this bug, we need to ask for more info.
<drbrain> yeah
baburdick has joined #rubygems
Who has quit [Quit: Who]
pglombar_ has quit [Remote host closed the connection]
redmenace has quit [Ping timeout: 246 seconds]
redmenace has joined #rubygems
seanlinsley has quit [Quit: seanlinsley]
josh-k_ has joined #rubygems
josh-k has quit [Read error: Connection reset by peer]
seanlinsley has joined #rubygems
arohner has quit [Remote host closed the connection]
ddd has quit [Quit: Have to reboot. system problems]
Briareos1 has quit [Remote host closed the connection]
pglombardo has joined #rubygems
huoxito has joined #rubygems
arohner has joined #rubygems
arohner has quit [Remote host closed the connection]
josh-k_ has quit [Remote host closed the connection]
<drbrain> indirect: ping
<drbrain> what goes in the DEPENDENCIES section of a bundler lock file?
tbuehlmann has quit [Remote host closed the connection]
imperator has joined #rubygems
lsegal has joined #rubygems
redmenace has quit [Ping timeout: 246 seconds]
redmenace has joined #rubygems
huoxito has quit [Remote host closed the connection]
hone has joined #rubygems
pglombardo has quit [Remote host closed the connection]
pglombardo has joined #rubygems
hone has quit [Ping timeout: 250 seconds]
pglombardo has quit [Remote host closed the connection]
redmenace has quit [Ping timeout: 246 seconds]
arohner has joined #rubygems
huoxito has joined #rubygems
huoxito has quit [Ping timeout: 260 seconds]
josh-k has joined #rubygems
redmenace has joined #rubygems
imperator has quit [Ping timeout: 240 seconds]