00:20 <TimMc> With GitHub being (allegedly) acquired by Microsoft, we might see some more people coming in here for self-hosting gitlab.

05:52 <ocdtrekkie> TimMc: 'Tis plausible. Though I suspect the majority of people not currently self-hosting their Git probably want an alternative "just put it here" site.

05:53 <ocdtrekkie> The side of Microsoft that interacts with GitHub is pretty darn good (as opposed to the side that keeps screwing up Windows 10 even further), so I'll reserve judgment mostly until Microsoft gets its hands on it.

05:54 <ocdtrekkie> But I think for sure a bunch of big companies will leave at least. Can't imagine Google or Apple or the like preferring to distribute their open source projects via a Microsoft property.

13:06 <TimMc> ocdtrekkie: For that matter, the Sandstorm packages of Gitlab and Gogs leave a bit to be desired for casual usage.

13:06 <TimMc> What I'd like to see is a one-step git clone, not "add these credentials via a command you've never seen and then clone this high-entropy URL"

15:15 <ocdtr_web> TimMc: Yeah, I wouldn't say Sandstorm is the best possible Git experience for a couple reasons.

15:15 <ocdtr_web> I've seen a few people truly upset, for example, that using SSH wasn't an option.

15:16 <TimMc> yup

15:16 <ocdtr_web> As a related note though, https://github.com/sandstorm-io/sandstorm-app-market/pull/134

15:18 <TimMc> ooh, I like

15:18 <ocdtr_web> Did some checking, and /issues is definitely the URL in both those sites, which makes that pretty easy to support.

15:19 <ocdtr_web> I need to check, I think Sandstorm itself has the same logic in a template as well.

15:22 <ocdtr_web> So on the app market it's codeLink.startsWith() and on Sandstorm itself it's codeUrl.lastIndexOf()

15:23 <ocdtr_web> I feel like the Sandstorm version of this code is needlessly complicated because I actually have to decode what the heck it is doing.

15:25 <TimMc> lastIndexOf, that's weird...

15:32 <ocdtr_web> And apparently lastIndexOf(string, 0) basically should say it can search for it nowhere but the start of the URL.

15:35 <TimMc> Why not use indexOf and check if it's 0? Or... startsWith? I thought JS had that, at least as an extremely common polyfill.

15:39 <ocdtr_web> https://github.com/sandstorm-io/sandstorm/pull/3077 <- To add to my pile of untested PRs that "should work".

15:42 <ocdtr_web> I would play with changing it to startsWith, which I assume exists since the Sandstorm App Market uses it, and both are Meteor.js, but since I can't test anything, I'm sticking with changing as little as possible to get the intended functionality.