fche changed the topic of #systemtap to: http://sourceware.org/systemtap; email systemtap@sourceware.org if answers here not timely, conversations may be logged
_whitelogger has joined #systemtap
<irker971> systemtap: scox systemtap.git:scox/tls * release-4.3-79-g99f122c6d / loc2stap.cxx tapset/linux/errno.stpm tapset/linux/tls.stp testsuite/systemtap.base/tls.exp testsuite/systemtap.base/tls1.c testsuite/systemtap.base/tls1.stp testsuite/systemtap.base/tls1_.c testsuite/systemtap.base/tls2_.c testsuite/systemtap.base/tlserrno.c: Add support for external tls variables
derek0883 has joined #systemtap
derek0883 has quit [Remote host closed the connection]
<fche> agentzh, kerneltoast, our arm buildbots are reporting a build error from the rcu work
<fche> atomic_fetch_add_unless redefinition, duplicates include/linux/atomic.h:567:19
<fche> this is a 4.18.0-240.5.el8.aarch64 rhel8-track kernel I believe
<agentzh> fche: kerneltoast will check it out.
<agentzh> thanks for the report.
<fche> thanks
<fche> feel free to commit straight to the tree
<agentzh> sure, will do.
derek0883 has joined #systemtap
<agentzh> fche: okay, i could reproduce that error on rhel8, but not on centos8. will look into a fix.
<agentzh> rhel8 x86_64.
<fche> there too, ok
<fche> yeah must be some early-backported patch, it happens :(
<fche> we sometimes end up having to use the buildrun runtime/linux/autoconf-* mechanism for such things
derek0883 has quit [Remote host closed the connection]
<kerneltoast> yeah we need to use autoconf for this
hpt has joined #systemtap
derek0883 has joined #systemtap
sscox has quit [Ping timeout: 258 seconds]
sscox has joined #systemtap
derek0883 has quit [Remote host closed the connection]
derek0883 has joined #systemtap
<kerneltoast> fche, still around?
<kerneltoast> nvm
irker971 has quit [Quit: transmission timeout]
orivej has quit [Ping timeout: 240 seconds]
irker199 has joined #systemtap
<irker199> systemtap: sultan systemtap.git:master * release-4.3-89-g59fb02f0c / buildrun.cxx runtime/linux/autoconf-atomic_fetch_add_unless.c runtime/task_finder_vma.c: task_finder_vma: add autoconf check for atomic_fetch_add_unless()
<agentzh> fche: fixed.
przemoc has quit [Ping timeout: 256 seconds]
orivej has joined #systemtap
DTEIT has quit [Ping timeout: 258 seconds]
DTEIT has joined #systemtap
DTEIT has quit [Client Quit]
DTEIT has joined #systemtap
DTEIT has quit [Quit: ZNC 1.8.2 - https://znc.in]
DTEIT has joined #systemtap
tonyj has quit [Remote host closed the connection]
sscox has quit [Ping timeout: 260 seconds]
hpt has quit [Ping timeout: 246 seconds]
mjw has joined #systemtap
sscox has joined #systemtap
_whitelogger has joined #systemtap
<fche> thanks
khaled has joined #systemtap
orivej has quit [Ping timeout: 265 seconds]
amerey has joined #systemtap
tromey has joined #systemtap
khaled has quit [Quit: Konversation terminated!]
gregwork has joined #systemtap
khaled has joined #systemtap
xlei has quit [Quit: ZNC - https://znc.in]
xlei has joined #systemtap
<kerneltoast> fche, hello!
<kerneltoast> i heard you like reviewing patches
<fche> yo dawg
<kerneltoast> i got you a patch for your patch so you can review this patch
<fche> thank you!
<fche> hmmmm
<fche> it looks ... plausible? ... speaking as you know as a nonexpert in this code
<fche> how did you test it?
<fche> (lockdep, any memory leaks?)
<kerneltoast> I've only lightly tested it so far
<kerneltoast> I suspect you're gonna ask for a testsuite run
<irker199> systemtap: fche systemtap.git:azhang/pr13838 * release-4.3-95-g1a85bc090 / runtime/softfloat.c tapset/floatingpoint.stp testsuite/buildok/floatingpoint.stp: string_to_fp parse error handling
<kerneltoast> ok I'm running the testsuite on it
derek0883 has quit [Remote host closed the connection]
derek0883 has joined #systemtap
<irker199> systemtap: fche systemtap.git:master * release-4.3-90-g6ecb85fda / testsuite/buildok/pretty-print-untimed.stp translate.cxx: RHBZ1890702: fix pretty-print conflict with --suppress-time-limits
<irker199> systemtap: fche systemtap.git:master * release-4.3-91-g49e0a88d5 / testsuite/buildok/contextfuns.stp testsuite/buildok/nfs_proc-embedded-ver4.3.stp: testsuite: fix buildok perms
derek0883 has quit [Remote host closed the connection]
<irker199> systemtap: alizhang systemtap.git:azhang/pr13838 * release-4.3-96-gb4ab1f607 / testsuite/buildok/floatingpoint.stp: use try catch to handle NaN error
derek0883 has joined #systemtap
<kerneltoast> fche okay I've run the testsuite and diffed the .sums
<kerneltoast> this is a comparison of my first run before the rcu task_finder_vma patch, to the current systemtap master HEAD + this new rcu patch
derek0883 has quit [Remote host closed the connection]
<kerneltoast> dmesg was clean as well
derek0883 has joined #systemtap
derek0883 has quit [Remote host closed the connection]
derek0883 has joined #systemtap
derek0883 has quit [Remote host closed the connection]
przemoc has joined #systemtap
przemoc has joined #systemtap
przemoc has quit [Changing host]
derek0883 has joined #systemtap
tromey has quit [Quit: ERC (IRC client for Emacs 27.1.50)]
<fche> am curious whether there is a pattern to those syscall FAIL's ... could you glance at the respective .log parts?
derek088_ has joined #systemtap
derek0883 has quit [Remote host closed the connection]
<kerneltoast> fche, i don't really understand how to interpret the .log parts. How can I tell why a test failed?
derek088_ has quit [Remote host closed the connection]
derek0883 has joined #systemtap
<fche> the messages from the syscall tests indicate actual vs. expected outputs in an odd diff-like manner
<fche> if you fpaste just the clauses for one of the failing syscall tests, maybe we can make sense of them
derek0883 has quit [Remote host closed the connection]
mjw has quit [Quit: Leaving]
derek0883 has joined #systemtap
<kerneltoast> fpaste.org isn't loading for me :P
<fche> yeah they nuked the service
<fche> fedora /usr/bin/fpaste now directs content to a centos.org server
chasum has quit [Quit: quit]
derek0883 has quit [Remote host closed the connection]
thibaultcha has joined #systemtap
thibaultcha has joined #systemtap
thibaultcha has quit [Changing host]
derek0883 has joined #systemtap
<kerneltoast> speaking of which, i have been doing these tests on fedora 32
thibaultcha has quit [Client Quit]
<kerneltoast> so it strikes me as odd that these syscall failures are a surprise to you
<kerneltoast> since i'm guessing you also use fedora
<kerneltoast> unless you're really a secret bsd user
<fche> kerneltoast, yeah it looks as though that sync syscall didn't show up in the second run
thibaultcha has joined #systemtap
thibaultcha has quit [Changing host]
thibaultcha has joined #systemtap
<fche> there is sometimes some noise, with probes being missed for random momentary reasons
thibaultcha has quit [Client Quit]
<fche> this test suite is picky for that
derek0883 has quit [Remote host closed the connection]
derek0883 has joined #systemtap
thibaultcha has joined #systemtap
thibaultcha has quit [Changing host]
thibaultcha has joined #systemtap
thibaultcha has quit [Client Quit]
<kerneltoast> fche, picky as in it is trying to test for that, or it is just susceptible to random noise?
<fche> picky in that it detects randomness well
<kerneltoast> huh so i guess changes in code timing would influence that?
thibaultcha has joined #systemtap
thibaultcha has quit [Changing host]
thibaultcha has joined #systemtap
<fche> conceivable ...
<fche> but for that to be able to cause a missed probe, the change would not only have to slow things down (rather than improve), but slow things down a LOT, so stap or kernel side lock-timeouts are triggered
<fche> seems unlikely
<kerneltoast> hmm well the syscall failures have been consistently inconsistent across my testsuite runs
derek0883 has quit [Remote host closed the connection]
<kerneltoast> some of them were failing before which are now passing
derek0883 has joined #systemtap
thibaultcha has quit [Client Quit]
<kerneltoast> i could try an older, more well-known kernel
<fche> nah it should be fine
<fche> ok, if a lockdep kernel was happy, if there are no signs of memory leaks, go for it
<kerneltoast> k i'll test lockdep and do some mem leak checking
<fche> thansk
thibaultcha has joined #systemtap
thibaultcha has joined #systemtap
<kerneltoast> i don't think agentzh would push this for at least a couple days
<kerneltoast> since we need to do internal testing to see the performance improvement
<fche> ok!
<kerneltoast> maybe RCU is a scam and paul mckenney fooled us all
<fche> not for the first time
<kerneltoast> fche, speaking of which, there are some randomly strewn RCU read locks in stp_utrace.c that i don't quite understand the need for
<kerneltoast> for example:
<kerneltoast> rcu_read_lock();
<kerneltoast> rcu_read_unlock();
<kerneltoast> utrace->utrace_flags = flags;
<fche> could be cargo-culting
<fche> all hail st. mcpaul
<kerneltoast> haha
<kerneltoast> would you be opposed to a thorough rewrite of stp_utrace.c in the future?
<fche> hmmmmmmmmm
<kerneltoast> there's a lot of spaghetti in it
<kerneltoast> and some marinara
<kerneltoast> i wouldn't be doing this any time soon, but it'll be good to know whether or not you'd throw your computer at me for presenting you with such a thing
<fche> well
<fche> I wonder how much we need stp_utrace.c per se
<fche> as opposed to having task_finder build on something closer to the kernel api
<kerneltoast> oh that's a good point
orivej has joined #systemtap
irker199 has quit [Quit: transmission timeout]
derek0883 has quit [Remote host closed the connection]
derek0883 has joined #systemtap
derek0883 has quit [Remote host closed the connection]
derek0883 has joined #systemtap
tonyj has joined #systemtap
derek0883 has quit [Ping timeout: 260 seconds]
amerey has quit [Remote host closed the connection]
thibaultcha has quit [Quit: quit]