fche changed the topic of #systemtap to: http://sourceware.org/systemtap; email systemtap@sourceware.org if answers here not timely, conversations may be logged
khaled_ has quit [Quit: Konversation terminated!]
derek0883 has quit [Remote host closed the connection]
derek0883 has joined #systemtap
derek0883 has quit [Remote host closed the connection]
hpt has joined #systemtap
derek0883 has joined #systemtap
derek0883 has quit [Ping timeout: 264 seconds]
derek0883 has joined #systemtap
derek0883 has quit [Remote host closed the connection]
irker043 has quit [Quit: transmission timeout]
derek0883 has joined #systemtap
derek0883 has quit [Remote host closed the connection]
derek0883 has joined #systemtap
gregwork has quit [Quit: Connection closed for inactivity]
orivej has joined #systemtap
_whitelogger has joined #systemtap
irker448 has joined #systemtap
<irker448> systemtap: alizhang systemtap.git:azhang/pr13838-tmp * release-4.3-116-g613b155a4 / : PR13838: Added basic floating point support to systemtap
derek0883 has quit [Remote host closed the connection]
khaled_ has joined #systemtap
orivej has quit [Ping timeout: 268 seconds]
khaled_ has quit [Remote host closed the connection]
khaled_ has joined #systemtap
khaled_ has quit [Quit: Konversation terminated!]
khaled_ has joined #systemtap
khaled_ has quit [Quit: Konversation terminated!]
khaled_ has joined #systemtap
khaled_ has quit [Remote host closed the connection]
khaled_ has joined #systemtap
hpt has quit [Ping timeout: 265 seconds]
khaled_ has quit [Remote host closed the connection]
khaled_ has joined #systemtap
orivej has joined #systemtap
_whitelogger has joined #systemtap
orivej has quit [Ping timeout: 240 seconds]
derek0883 has joined #systemtap
derek0883 has quit [Ping timeout: 260 seconds]
tromey has joined #systemtap
amerey has quit [Remote host closed the connection]
amerey has joined #systemtap
<irker448> systemtap: alizhang systemtap.git:master * release-4.3-116-gee341273e / : PR13838: Added basic floating point support to systemtap
tonyj has quit [Quit: leaving]
tonyj has joined #systemtap
derek0883 has joined #systemtap
derek0883 has quit [Remote host closed the connection]
derek0883 has joined #systemtap
derek0883 has quit [Remote host closed the connection]
derek0883 has joined #systemtap
amerey has quit [Remote host closed the connection]
amerey has joined #systemtap
amerey has quit [Client Quit]
amerey has joined #systemtap
derek0883 has quit [Remote host closed the connection]
derek0883 has joined #systemtap
<kerneltoast> fche, bonjour
<fche> bon bon
<irker448> systemtap: mcermak systemtap.git:master * release-4.3-117-g4b52057ec / testsuite/systemtap.base/debugpath.exp: Adapt debugpath.exp to the debuginfod feature.
<kerneltoast> ready for the easiest code review of your life?
<fche> go for it
<kerneltoast> inb4 it breaks rhel6
<kerneltoast> sadly it doesn't fix our panics
orivej has joined #systemtap
tromey has quit [Quit: ERC (IRC client for Emacs 27.1.50)]
<kerneltoast> fche, i have more garbage to feed you
<fche> ummmmmmmmm
<fche> you will need to wait
<fche> I'm first having dinner
<fche> and then, ummm, garbage just doesn't sound that appealing
<fche> BUT THANKS FOR THE OFFER
<kerneltoast> it's delicious i promise
<kerneltoast> beats whatever dinner you're having
<fche> ok I'll look
<fche> ummmm I'm sure there must have been a reason to make that a goofy atomic
<fche> as opposed to a blocking wait kind of thing
<fche> bletch, now I'm losing my appetite
<fche> thanks a lot dude :)
<kerneltoast> np :)
<kerneltoast> and it is a blocking wait
<kerneltoast> this doesn't change that behavior
<kerneltoast> ok now go eat some grub
<kerneltoast> or lilo
<kerneltoast> or rEFInd
<fche> ok this is just getting silly
<fche> and we here in the british army don't like silly
<fche> no sir
<kerneltoast> are you in fact a redcoat?
<fche> I'm a double agent for the Revolutionary Army too, but don't tell anyone.
<kerneltoast> benedict, is that you?
<fche> eggs benedict, at your service
<kerneltoast> omelette du fromage?
<fche> ok so as to your patch, what testing has it suffered?
derek0883 has quit [Remote host closed the connection]
<kerneltoast> it boots
<fche> so does my shoe rack
<kerneltoast> what's your primary concern with the patch?
<kerneltoast> this was supposed to be somewhat obvious
<fche> sorry for overestimating me
<fche> or rather - I wonder why it wasn't done like this earlier
<kerneltoast> there's a lot of code in stap that makes one wonder that ;)
derek0883 has joined #systemtap
<fche> well, the runtime goes back to kernel 2.6.9 era or perhaps even earlier, so it tries not to assume too much modernity
<kerneltoast> 2.6.9 has wait_event
amerey has quit [Quit: Leaving]
<kerneltoast> i guess if i didn't know about wait events i'd do it like that?
<fche> maybe? :)
<fche> does it behave any differently (except for the polling) ?
<kerneltoast> no
<kerneltoast> behaves exactly the same. it just doesn't poll
<fche> ok, ship it
<kerneltoast> that was easy
<kerneltoast> fche, how's the commit message? https://gist.github.com/kerneltoast/a0f8e52b8065bb1a32628ffd80e75e99
derek0883 has quit [Remote host closed the connection]
<fche> lgtm
<fche> thanks.
<kerneltoast> fche, oh i guess i didn't make the patch strong enough to guarantee what i said in that last blurb: "This change also prevents stp_task_work_add() from queuing a new task worker after stp_task_work_exit() has finished, which could lead to a crash if it ever happened."
<kerneltoast> is that something i should worry about?
<fche> if it's something simple to prevent, as a belt&suspenders thing sure
<kerneltoast> ok, then i'll do some reworking
derek0883 has joined #systemtap
<kerneltoast> nvm it's not trivial to make that guarantee. belt & suspenders coming off
<kerneltoast> i'll need to test it again, but assuming it tests fine, good to ship?
<fche> would add a comment to the remaining atomic_inc_return as to why it's different from the others
<fche> you know
<fche> for the old guy who might forget
<kerneltoast> k
<fche> but yes.
<fche> ok
<kerneltoast> noice
<fche> educating as you go, thanks
<fche> pretty noice garbage there
<kerneltoast> very noice
sscox has quit [Ping timeout: 265 seconds]
<fche> warmly noice
sscox has joined #systemtap
<kerneltoast> ok it doesn't make our fuzzer scream, and i confirmed it waits till the count hits zero
khaled_ has quit [Quit: Konversation terminated!]
khaled_ has joined #systemtap
orivej has quit [Ping timeout: 258 seconds]
lickingball has joined #systemtap