<FromGitter>
<drujensen> I usually say the latest and the one before that
<FromGitter>
<drujensen> but with mysql, the 8.0 is a big jump
<FromGitter>
<Thellior> 1) 5 / 10.4 /9.6 /9.5?
<FromGitter>
<Thellior> Or 10 and 9
<FromGitter>
<drujensen> probably 5.6, 5.7?
<FromGitter>
<Thellior> 1) 7 -> 8.0(5.8)
<FromGitter>
<eliasjpr> @drujensen what did we decided with the connections?
<FromGitter>
<drujensen> i am going to release after we fix the travis failure
<FromGitter>
<drujensen> > 10.5 / 10.4 /9.6 /9.5?
<FromGitter>
<drujensen> good question
<FromGitter>
<drujensen> Can we do all 4?
<FromGitter>
<drujensen> probably just 9.6 and 10.5
<FromGitter>
<drujensen> would be fine, right?
<FromGitter>
<Thellior> We can do all versions
<FromGitter>
<drujensen> @Sija @kolyaio @noahlh @robacarp @ZeroPointEnergy @shobhitic @eliasjpr I have fixed the credits for v0.9.0 release (https://github.com/amberframework/amber/releases/tag/v0.9.0). Sorry for not catching this and thanks for your contributions!
<FromGitter>
<Thellior> Travis will run them parallel anyways
<FromGitter>
<drujensen> awesome!
<FromGitter>
<Thellior> But's it's more like what do we support and fix if there are issues
<FromGitter>
<drujensen> I usually go with current and previous as a rule of thumb
<FromGitter>
<kolyaio> Awesome ! 😊
<FromGitter>
<Thellior> @drujensen Ok will do that
<FromGitter>
<drujensen> @Thellior took it over. Basically, we changed to test each db separately in its own travis process
<FromGitter>
<drujensen> but now that we maintain one connection per adapter, when we register the other db, it fails
<FromGitter>
<drujensen> A fix would be to lazy load the connection, meaning we connect on first attempt instead of at instantiation of the adapter
<FromGitter>
<drujensen> once we fix that, I will release a patch to address the connection leak issue
<FromGitter>
<Thellior> @drujensen What i noticed on the tests is that if you create the adapter it immediately connects to the database. That's why the travis branch is failing. Each seperate docker container only test one database so it will instance either mysql image or pg image or the ubuntu sqlite. When running the sqlite container it will try to connect to a PG database that does not exist so it will raise a error. I'm changing the
<FromGitter>
... tests now so we can handle that
<FromGitter>
<Thellior> Don't know if it was intended that the database was loaded on Adapter initializing
<FromGitter>
<drujensen> right. We can lazy load it instead
<FromGitter>
<drujensen> can you fix it?
<FromGitter>
<Thellior> If you do that the travis branch should run properly
<FromGitter>
<Thellior> I was fixing the test to check which database is running and creating only the adapter corresponding to that
<FromGitter>
<Thellior> Don't know how you want to lazy load the database
<FromGitter>
<drujensen> ok. I will work on that
<FromGitter>
<Thellior> Ok, are you fixing it in the travis branch
<FromGitter>
<Thellior> Or are you going to make a sperate branch
<FromGitter>
<drujensen> separate branch
<FromGitter>
<eliasjpr> I think we should just have one DB.open per granite instance since the CrystalDB shard handle the connection pool. no need to assign a connection per model
<FromGitter>
<eliasjpr> IMO
<FromGitter>
<drujensen> right
<FromGitter>
<drujensen> that is the fix
<FromGitter>
<eliasjpr> ahh
<FromGitter>
<eliasjpr> ok
<FromGitter>
<drujensen> we had it that way and it was rolled back
<FromGitter>
<drujensen> when the new Adapter pattern was added
<FromGitter>
<Thellior> @drujensen Could you merge master into my pull request
<FromGitter>
<drujensen> yes
<FromGitter>
<Thellior> Thanks
<FromGitter>
<drujensen> @robacarp thanks for the quick approval
<FromGitter>
<drujensen> For granite, the three big changes needed are enhancing the `has_many` relationship, supporting inheritance (although there is now debates if this is an anti-pattern) and finishing up the dsl for querying. Is there anything else we should put on the roadmap?
<FromGitter>
<Thellior> @drujensen Currently im working on validators
<FromGitter>
<drujensen> 👍
<FromGitter>
<Thellior> So i'm checking which validators are inside ActiveRecord(rails) and try to implement those who are usefull
<FromGitter>
<Thellior> @drujensen 🍻 on the green test branch now
<FromGitter>
<Thellior> Thanks for the support
<FromGitter>
<drujensen> sweet. okk, i will release this. Thanks @Thellior
<FromGitter>
<drujensen> @Thellior @winhackua @zaidakram @Hansterdam Released granite v0.13.1 with your contributions. Thank you!
<FromGitter>
<Thellior> :shipit:
<FromGitter>
<eliasjpr> I left a comment
<FromGitter>
<eliasjpr> jusst suggestions
<FromGitter>
<drujensen> k
<robacarp>
@drujensen, thanks for addressing the connection issue on such short notice :D
<FromGitter>
<Sija> @drujensen gr8 :)
<FromGitter>
<Sija> @drujensen I’d remove commit sha’s too since they add lil’ value a and a lot of noise
<FromGitter>
<drujensen> > @drujensen I’d remove commit sha’s too since they add lil’ value a and a lot of noise ⏎ @Sija fixed
<FromGitter>
<Sija> @drujensen 👍
<FromGitter>
<Sija> @drujensen Any chances on being added to gh org as a member?