faustinoaq changed the topic of #amber to: Welcome to Amber Framework community! | https://amberframework.org | Developer happiness, productivity and bare metal performance | GH: https://github.com/amberframework | Docs: https://docs.amberframework.org | Gitter: https://gitter.im/amberframework/amber | IRC Logger: https://irclog.whitequark.org/amber | Amber::Server.start
<FromGitter> <Blacksmoke16> @robacarp does `dead` redis queue mean those that were completed?
<FromGitter> <Blacksmoke16> or that failed
<FromGitter> <Blacksmoke16> nvm, is a periodic that failed
<FromGitter> <robacarp> Yeah, jobs which fail too many times go dead
<FromGitter> <Blacksmoke16> what causes a job to go into like
<FromGitter> <robacarp> I think by default it will try a job 4 times before it dies
<FromGitter> <Blacksmoke16> timestamp of the failed job? doesnt seem to be ones that completed
<FromGitter> <robacarp> Is that a task entry that is empty?
<FromGitter> <Blacksmoke16> im not sure, i cant seem to make any new ones
<FromGitter> <robacarp> Hm. I’m not sure, I’d have to look for that. I know of a bug where jobs which complete wont get evicted from redis
<FromGitter> <robacarp> Did that job run and get completed and just not get erased?
<FromGitter> <Blacksmoke16> im not sure
<FromGitter> <Blacksmoke16> ill see if i can reproduce
<FromGitter> <Blacksmoke16> looks to be all the periodic jobs that failed
<FromGitter> <Blacksmoke16> on another note, i think it would be nice if successfully completed jobs were stored as well, then could use that for like metrics and stats
<FromGitter> <Blacksmoke16> but overall everything is working pretty good so far :)
<FromGitter> <robacarp> Great to hear!
<FromGitter> <robacarp> There are ways to calculate stats without storing jobs
<FromGitter> <robacarp> The trick is... I get an email every few months that the disk is full on my worker machine
<FromGitter> <robacarp> Because I have about 20 jobs that run once a minute
<FromGitter> <robacarp> So I just have to flush all manually
<FromGitter> <robacarp> @Blacksmoke16 will you file an issue about periodic jobs failing and hanging around?
<FromGitter> <Blacksmoke16> what about a TTL?
<FromGitter> <robacarp> We’ve talked before yeah, that’s an option for sure, and I think it’s worthy
<FromGitter> <Blacksmoke16> https://github.com/robacarp/mosquito/issues/5 i think covers it
<FromGitter> <robacarp> Redis expiring keys could do that
<FromGitter> <robacarp> Okay, great
<FromGitter> <Blacksmoke16> 👍
<FromGitter> <robacarp> I have a wip branch for wall clock scheduled jobs, and it addresses that, I think
<FromGitter> <Blacksmoke16> \o/
<FromGitter> <Blacksmoke16> great!
<FromGitter> <Blacksmoke16> what about the throttling of jobs? ;)
<FromGitter> <robacarp> I haven’t yet tackled that one 😬
<FromGitter> <Blacksmoke16> hehe, when i get closer to needing it we can chat and i can maybe make a pr
<FromGitter> <robacarp> Always welcome 😬
_whitelogger has joined #amber
_whitelogger has joined #amber
vivus has quit [Remote host closed the connection]
<FromGitter> <blankoworld> Hello there.
<FromGitter> <blankoworld> Today I find what was wrong between Nginx and Amber : Content-type ! It seems that Amber don't return any Content-Type (for the default example while using amber new myapp)
<FromGitter> <blankoworld> In fact, when I use HTTPS, I activate : https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Content-Type-Options
<FromGitter> <blankoworld> I set it to "nosniff". Which imply that we need to return (in response) a Content-Type
<FromGitter> <blankoworld> On given example, no Content-Type exist.
<FromGitter> <blankoworld> So my question is: is that normal? Or should I use something else to set, by default, a content Type?
<FromGitter> <blankoworld> My disgusting patch is just: ⏎ def index ⏎ ⏎ ```context.response.content_type = "text/html" ⏎ render("index.slang")``` ⏎ ... [https://gitter.im/amberframework/amber?at=5b8e358ec2bd5d117a17dc8a]
<FromGitter> <blankoworld> But I need to do this for *each* controller…
<FromGitter> <Thellior> @blankoworld You can create a before action on all and set the content type like that
<FromGitter> <Thellior> ```code paste, see link``` [https://gitter.im/amberframework/amber?at=5b8e3addc9500b4bab7cec81]
<FromGitter> <Thellior> It's something like this out of my head
<FromGitter> <blankoworld> Ok @Thellior. Is that better than making a Pipeline (middleware I think) to change each response?
<FromGitter> <Thellior> I think that is more a opinionated than really a better solution
<FromGitter> <Thellior> My personal preferences goes to this solution but than in the ApplicationController. For me it's less magic feeling when it's defined in the controller instead of a pipeline
<FromGitter> <Thellior> But i think both solutions are fine
<FromGitter> <blankoworld> Ok, I see :). Thanks !
<FromGitter> <robacarp> @blankoworld I’d opt for making a pipe, but this is a bug and needs to be fixed in Amber. Will you open an issue?
<FromGitter> <blankoworld> @robacarp : Ok, I will try to make a ticket about that.