faustinoaq changed the topic of #amber to: Welcome to Amber Framework community! | https://amberframework.org | Developer happiness, productivity and bare metal performance | GH: https://github.com/amberframework | Docs: https://docs.amberframework.org | Gitter: https://gitter.im/amberframework/amber | IRC Logger: https://irclog.whitequark.org/amber | Amber::Server.start
<FromGitter> <drujensen> There are 2 PRs that are different implementations of plugins.
<FromGitter> <drujensen> Another waiting for a review.
<FromGitter> <imeraj_gitlab> Anyone using Jennifer with Amber ?
<FromGitter> <imeraj_gitlab> I am getting this strange error ⏎ ⏎ `crystal sam.cr generate:makefile 1 ↵ ⏎ Showing last frame. Use --error-trace for full trace. ⏎ ... [https://gitter.im/amberframework/amber?at=5f2a3ce299e9260343308560]
alexherbo2 has joined #amber
alexherbo2_ has joined #amber
alexherbo2_ has quit [Ping timeout: 256 seconds]
alexherbo2 has quit [Ping timeout: 240 seconds]
alexherbo2 has joined #amber
alexherbo24 has joined #amber
_whitelogger has joined #amber
<FromGitter> <Blacksmoke16> update to latest commit
<FromGitter> <eliasjpr> CORS Fix Issue #1224 - https://github.com/amberframework/amber/pull/1225
renich has joined #amber
renich has quit [Remote host closed the connection]
<FromGitter> <eliasjpr> @drujensen @Blacksmoke16 I made changes based on the suggestions/comments
<FromGitter> <drujensen> approved
<FromGitter> <drujensen> can you look at https://github.com/amberframework/amber/pull/1218?
<FromGitter> <drujensen> I incorrectly raised an exception in the routes command on an `else` which is required for case statements now. this fixes it.
<FromGitter> <drujensen> it rolls back an earlier change
<FromGitter> <eliasjpr> got it
<FromGitter> <imeraj> Thanks @Blacksmoke16 . It worked!
<FromGitter> <drujensen> @eliasjpr did you get a chance to look at the 2 Plugin PR’s?
<FromGitter> <drujensen> Also should we remove the Process Count?
<FromGitter> <drujensen> @imeraj curious what was your reason to choosing Jennifer over Granite?
<FromGitter> <drujensen> migrations DSL?
<FromGitter> <drujensen> or is there other features in Jennifer that you liked better?
<FromGitter> <eliasjpr> In regard to the Plugin PRs I think we can merge this one https://github.com/amberframework/amber/pull/1219
<FromGitter> <eliasjpr> I think that PR is closer to having a consensus on the plugins approach, all thanks to the initial work done by @damianham of course
<FromGitter> <eliasjpr> I left the last comment on that PR it would be great that we enable it behind a feature flag for the next release
<FromGitter> <drujensen> ok, thanks. @damianham, can you take a look at @andrewc910 PR and give your blessing?
<FromGitter> <eliasjpr> In regards to https://github.com/amberframework/amber/pull/1157 I am not sure if we can merge at the moment
<FromGitter> <eliasjpr> We have to wait until parallelism is available
<FromGitter> <drujensen> ok. Wasnt sure if that was officially supported yet
<FromGitter> <drujensen> Is the plugin feature a breaking change?
<FromGitter> <eliasjpr> I do not see that it is a breaking change in the description we would have to test it
<FromGitter> <eliasjpr> I am curious what is the most requested feature for Amber I might have some time to work on Amber
<FromGitter> <eliasjpr> The plugin support will open a lot of possibilities and will unblock this issue as well https://github.com/amberframework/amber/issues/1189
<FromGitter> <drujensen> I think @damianham would love if someone added support for the `render` macro to check the view directory but if the template is not found, to check in the current directory. This will support the more modular layout.
<FromGitter> <drujensen> where you place the model/view/controller/assets all in the same folder
<FromGitter> <eliasjpr> We can make this a config variable `root_view_path` and have that be used by render
<FromGitter> <drujensen> Good idea. Avoids the extra call
<FromGitter> <eliasjpr> @drujensen do you have a few minutes, I am trying to triage some of the open issues there seems some of them to have been already resolved
alexherbo2 has quit [Ping timeout: 260 seconds]
alexherbo24 has quit [Ping timeout: 246 seconds]