<CYBERDEViL>
Hi! I just noticed that the Kodi `package.mk` isn't honoring `GOLD_SUPPORT` set in `distributions/LibreELEC/options`, it should right?
pauljw has joined #libreelec
<buzzmarshall>
i can't say for all the different builds but the ones i am working with which would be LE' Masters and a older vendor bsp driven build on all the AML stuff has -DENABLE_LDGOLD=ON in the kodi package.mk file
<buzzmarshall>
would make me think that its set to denable gold... thats in both the matrix and newest leia versions
<buzzmarshall>
maybe some of the other devices have it on but take alook deeper into the kodi package.mk file and see if its being set to overide the settings in the distribution or device options file
<CYBERDEViL>
Ah well I expected when I set `GOLD_SUPPORT="no"` and then do a `make image` that nothing is using the Google linker.
<buzzmarshall>
actually now that i look at a build i was just finishing on older S812's on Leia 18.7 it actually says it is set
<buzzmarshall>
when i am done here i will run a S912 build and see if its set in the build output as well in a little bit
<buzzmarshall>
the distro options file has it specificallys set on but i took it for granted the kodi package file was turning it off
<buzzmarshall>
obviously i was wrong on that one
<buzzmarshall>
at least thats what the build outputs are showing when it builds
<buzzmarshall>
i can't see why it wouldn't but to be honest i am only building currently for the none intel platforms so i am not sure if that would somehow effect the overall build in a way it doesn't work right across all platforms
<CYBERDEViL>
All right. Yeah here only building ARM images currently.
klesk has quit [*.net *.split]
mniip has quit [*.net *.split]
chbmb has quit [*.net *.split]
Kwiboo has quit [*.net *.split]
narmstrong has quit [*.net *.split]
iNDi has quit [*.net *.split]
thefinn93 has quit [*.net *.split]
diederik has quit [*.net *.split]
<buzzmarshall>
actually now after playing with this for a minute i am not so sure that the -DENABLE_LDGOLD=ON isn't actually overiding the global setting as i noticed if i change the setting to off in the distro options file then the build header shows its off
Kwiboo has joined #libreelec
klesk has joined #libreelec
mniip has joined #libreelec
chbmb has joined #libreelec
diederik has joined #libreelec
narmstrong has joined #libreelec
iNDi has joined #libreelec
thefinn93 has joined #libreelec
<buzzmarshall>
so i think what i seen in the build output headers is really just reading the master distro options file settings
<buzzmarshall>
as i can seem to change what the build headers say just by turning the gold on or off in the distro options file without even going thru the whole build and getting to rebuilding kodi itself
<buzzmarshall>
seems to say to me that output in the build headers at the top then really are irelavent to what actually is being overiden by the kodi package file
<buzzmarshall>
would need to actually look into the kodi package as it rebuilds to see which setting is actually being used
<buzzmarshall>
as unless i misunderstand the -DENABLE_LDGOLD=ON flag i would think thats saying turn gold off... next time i build i am going to try your patch as i can't see why it wouldn't be distructive to the builds i am doing
<CYBERDEViL>
All right, I expect -DENABLE_LDGOLD=ON to have the google linker enabled and with -DENABLE_LDGOLD=OFF to have no google linker. Since -D* options are CMake flags. Correct me if I'm wrong :-P
xexaxo1 has joined #libreelec
{HD} has quit [Ping timeout: 256 seconds]
{HD} has joined #libreelec
pauljw has quit [Read error: Connection reset by peer]
{HD} has quit [Ping timeout: 240 seconds]
{HD} has joined #libreelec
Tobbi has quit [Ping timeout: 272 seconds]
andy-burns has quit [Ping timeout: 258 seconds]
lolek has quit [Remote host closed the connection]
lolek has joined #libreelec
|Jeroen| has joined #libreelec
gouchi has joined #libreelec
ghostcube has quit [Quit: Verlassend]
fraggle_laptop has quit [Remote host closed the connection]
fraggle_laptop has joined #libreelec
{HD} has quit [Ping timeout: 256 seconds]
{HD} has joined #libreelec
{HD} has quit [Ping timeout: 272 seconds]
{HD} has joined #libreelec
{HD} has quit [Ping timeout: 272 seconds]
{HD} has joined #libreelec
pauljw has joined #libreelec
{HD} has quit [Ping timeout: 256 seconds]
{HD} has joined #libreelec
pauljw has quit [Read error: Connection reset by peer]
pauljw has joined #libreelec
hgeboner has quit [Ping timeout: 256 seconds]
pauljw_18 has joined #libreelec
pauljw_18 has quit [Remote host closed the connection]