<sb0>
_florent_, brute-forcing attribute gets in jesd common.py and ignoring exceptions is not acceptable, you should probably have merged JESD204BTransportSettings and JESD204BPhysicalSettings in the first place.
<sb0>
I'm talking about the code in get_configuration_data "for settings in [self.phy, self.transport], try... except: pass"
<sb0>
this adds unnecessary complexity, and causes obscure bugs with values silently not set
<_florent_>
sb0: ok to simplify that if you think that's useful
kuldeep has quit [Remote host closed the connection]
kuldeep has joined #m-labs
<_florent_>
sb0: but jesd204b has lots or parameters and it's probably easier to split this settings to understand the code
<sb0>
what is the difference between a "physical" and a "transport" setting?
<sb0>
even if this difference is justified, attempting to get a parameter by name from the first structure that will provide it and ignoring errors is a recipe for bugs
<sb0>
(such as those I am having right now, touching this code)
sb0 has quit [Quit: Leaving]
sandeepkr has joined #m-labs
sandeepkr has quit [Remote host closed the connection]