<GitHub152>
[smoltcp] whitequark commented on pull request #205 ff65807: Are you planning to somehow unify the ICMPv4 and ICMPv6 `Message`, `DstUnreachable`, `TimeExceeded` and `ParamProblem` enums? This doesn't seem like the right way to go to me. Why is this necessary? https://github.com/m-labs/smoltcp/pull/205#discussion_r187041666
<GitHub25>
[smoltcp] whitequark commented on issue #205: OK, now that I see `icmp.rs`, I think this is definitely not the right approach. `IcmpRepr` makes sense to have, but the other enums aren't used anywhere and it's not clear to me that they are clearly useful as defined. https://github.com/m-labs/smoltcp/pull/205#issuecomment-387748475
<GitHub103>
[smoltcp] ProgVal commented on issue #205: No. I added a `println!` in front of every initialization of `Truncated` I could find in ICMP- and IPv6-related files, none of them were called. https://github.com/m-labs/smoltcp/pull/205#issuecomment-387829537
<GitHub115>
[smoltcp] dlrobertson commented on pull request #205 04420a0: The new `IcmpRepr` really shouldn't be used in the `process_icmpv4` or `process_icmpv6` functions. AFAIK it is really only needed for getting data from the socket to the interface, but I don't think it is needed for parsing data from the outside world. https://github.com/m-labs/smoltcp/pull/205#discussion_r187146360
<GitHub109>
[smoltcp] ProgVal commented on pull request #205 04420a0: I don't really understand what `ChecksumCapabilities` mean (should the user of smoltcp verify them? or smoltcp itself? or the hardware?), but using `ChecksumCapabilities::ignored` fixed two of the issues, thanks! https://github.com/m-labs/smoltcp/pull/205#discussion_r187167063
<GitHub176>
[smoltcp] ProgVal commented on issue #205: Ha, I found why it's truncated, it's because the buffer allocated on the first line of `test_accepts_udp_v6` only supports 46-bytes packets.... https://github.com/m-labs/smoltcp/pull/205#issuecomment-387877416
<GitHub125>
[smoltcp] dlrobertson commented on pull request #205 73b41ed: yeah this is more or less a nit. It might be cleaner to add a line like `let socket_repr = IcmpRepr::from(icmp_repr)` then use `socket_repr` for the `IcmpSocket` functions and then you can still `match icmp_repr` and you don't have the extra `IcmpRepr::Ipv4(...)`, but this is just a nit. https://github.com/m-labs/smoltcp/pull/205#discussion_r18718
<GitHub5>
[smoltcp] dlrobertson commented on pull request #205 73b41ed: It is essentially used to determine if the parse/emit function should verify/fill the checksum. It is typically used in the context of a device. For example, a device that we can offload IPv4 checksumming on transmit to would have a `ChecksumCapabilities` structure with `ipv4` equal to [TX](https://github.com/m-labs/smoltcp/blob/master/src/phy/mod.rs#L127
<GitHub193>
[smoltcp] m-labs-homu commented on issue #178: :umbrella: The latest upstream changes (presumably ce2fbb7dd2a45d27426db3f842a2f5fa68f7b700) made this pull request unmergeable. Please resolve the merge conflicts. https://github.com/m-labs/smoltcp/pull/178#issuecomment-387904282