sb0 changed the topic of #m-labs to: ARTIQ, Migen, MiSoC, Mixxeo & other M-Labs projects :: fka #milkymist :: Logs http://irclog.whitequark.org/m-labs
<GitHub79> [smoltcp] whitequark commented on pull request #212 a24599b: `for and` https://github.com/m-labs/smoltcp/pull/212#discussion_r191062523
kaolpr has quit [Ping timeout: 268 seconds]
kaolpr has joined #m-labs
<GitHub196> [smoltcp] dlrobertson commented on pull request #219 a4348e3: Probably shouldn't run `lookup` on multicast addresses either. I think this can be `is_unicast`. https://github.com/m-labs/smoltcp/pull/219#discussion_r191062817
<GitHub189> [smoltcp] dlrobertson commented on pull request #219 a4348e3: Typically `Error::Exhausted` is returned if not enough storage. Is three a reason to return the previous gateway addr on error? https://github.com/m-labs/smoltcp/pull/219#discussion_r191062792
<GitHub166> [smoltcp] dlrobertson commented on pull request #219 a4348e3: I don't think this is necessary. If the address we're querying is the address of the router we either didn't run address resolution or it didn't respond. If `lookup` returns the address of the router we'll either used the cached link layer address or run address resolution. https://github.com/m-labs/smoltcp/pull/219#discussion_r191062945
<GitHub62> [smoltcp] dlrobertson commented on pull request #219 a4348e3: I don't think this is true any more. https://github.com/m-labs/smoltcp/pull/219#discussion_r191062769
<GitHub52> [smoltcp] dlrobertson commented on pull request #219 a4348e3: whitespace https://github.com/m-labs/smoltcp/pull/219#discussion_r191062990
<GitHub74> [smoltcp] dlrobertson commented on pull request #219 a4348e3: You might want to create a FIXME or issue to research a clever way to clear out expired routes. https://github.com/m-labs/smoltcp/pull/219#discussion_r191062910
<GitHub129> [smoltcp] dlrobertson commented on pull request #219 a4348e3: Same. https://github.com/m-labs/smoltcp/pull/219#discussion_r191062803
<GitHub61> [smoltcp] dlrobertson commented on pull request #219 a4348e3: What is the purpose of this test? https://github.com/m-labs/smoltcp/pull/219#discussion_r191062953
<GitHub91> [smoltcp] dlrobertson commented on pull request #219 a4348e3: I don't believe this is true now either. https://github.com/m-labs/smoltcp/pull/219#discussion_r191062806
<GitHub197> [smoltcp] dlrobertson commented on pull request #219 a4348e3: These tests should run if either `proto-ipv4` or `proto-ipv6` are enabled. See `MOCK_IP_ADDR_*` in [wire/ip.rs:852-876](https://github.com/m-labs/smoltcp/blob/master/src/wire/ip.rs#L853-L876). You will need to add `MOCK_IP_CIDR_*`. https://github.com/m-labs/smoltcp/pull/219#discussion_r191062898
<GitHub13> [smoltcp] dlrobertson commented on pull request #212 1e6157b: Fixed https://github.com/m-labs/smoltcp/pull/212#discussion_r191063071
Ultrasauce has quit [Ping timeout: 256 seconds]
<GitHub145> [smoltcp] ProgVal commented on pull request #219 a4348e3: Indeed. https://github.com/m-labs/smoltcp/pull/219#discussion_r191066316
<GitHub108> [smoltcp] ProgVal commented on pull request #219 a4348e3: I mimicked ManagedMap::range's return result. I'll change that. https://github.com/m-labs/smoltcp/pull/219#discussion_r191066323
<GitHub3> [smoltcp] ProgVal commented on pull request #219 a4348e3: What do you mean by "create a FIXME"? https://github.com/m-labs/smoltcp/pull/219#discussion_r191066384
<GitHub150> [smoltcp] ProgVal commented on pull request #219 a4348e3: will do https://github.com/m-labs/smoltcp/pull/219#discussion_r191066392
<GitHub130> [smoltcp] ProgVal commented on pull request #219 a4348e3: Which one? https://github.com/m-labs/smoltcp/pull/219#discussion_r191066425
<travis-ci> ProgVal/smoltcp#16 (managedmap-routes - 2e50354 : Valentin Lorentz): The build has errored.
<travis-ci> ProgVal/smoltcp#18 (managedmap-routes - ced197f : Valentin Lorentz): The build passed.
<GitHub80> [smoltcp] whitequark commented on issue #212: @m-labs-homu r+ https://github.com/m-labs/smoltcp/pull/212#issuecomment-392313865
<GitHub73> [smoltcp] m-labs-homu commented on issue #212: :pushpin: Commit 1e6157b has been approved by `whitequark`
<GitHub86> [smoltcp] m-labs-homu pushed 3 new commits to auto: https://github.com/m-labs/smoltcp/compare/9c1900ff3f66...2363f97834b3
<GitHub86> smoltcp/auto 2363f97 Dan Robertson: iface: Begin parsing Hop-By-Hop extension headers...
<GitHub86> smoltcp/auto dd80b22 Dan Robertson: Improve IPv6 options parsing...
<GitHub86> smoltcp/auto 030bba3 Dan Robertson: NDISC flags should be located in ndisc module...
<GitHub89> [smoltcp] m-labs-homu commented on issue #212: :hourglass: Testing commit 1e6157ba97a18266c54e9e4c89ad1201b264a452 with merge 2363f97834b3d529c6344f1840ab001645e853d2... https://github.com/m-labs/smoltcp/pull/212#issuecomment-392313891
<travis-ci> m-labs/smoltcp#978 (auto - 2363f97 : Dan Robertson): The build passed.
<GitHub61> [smoltcp] m-labs-homu commented on issue #212: :sunny: Test successful - [status-travis](https://travis-ci.org/m-labs/smoltcp/builds/384305082?utm_source=github_status&utm_medium=notification)
<GitHub44> [smoltcp] m-labs-homu merged auto into master: https://github.com/m-labs/smoltcp/compare/908ef8d0204b...2363f97834b3
<GitHub136> [smoltcp] m-labs-homu closed pull request #212: iface: Begin parsing Hop-By-Hop extension headers (master...parse_ext_hdr) https://github.com/m-labs/smoltcp/pull/212
<GitHub195> [smoltcp] m-labs-homu commented on issue #190: :umbrella: The latest upstream changes (presumably 2363f97834b3d529c6344f1840ab001645e853d2) made this pull request unmergeable. Please resolve the merge conflicts. https://github.com/m-labs/smoltcp/pull/190#issuecomment-392314493
<travis-ci> m-labs/smoltcp#979 (master - 2363f97 : Dan Robertson): The build passed.
rohitksingh has joined #m-labs
X-Scale has quit [Ping timeout: 245 seconds]
[X-Scale] has joined #m-labs
<GitHub-m-labs> [artiq] jordens pushed 2 new commits to master: https://github.com/m-labs/artiq/compare/db4d1878d352...56cfe77c91ce
<GitHub-m-labs> artiq/master 56cfe77 Robert Jordens: environment: spelling
<GitHub-m-labs> artiq/master b09d079 Robert Jordens: kasli: add LUH/PTB/HUB variants...
<rjo> bb-m-labs: force build --props=package=artiq-board,artiq_target=kasli,artiq_variant=ptb artiq-board
<bb-m-labs> build forced [ETA 34m45s]
<bb-m-labs> I'll give a shout when the build finishes
<rjo> bb-m-labs: force build --props=package=artiq-board,artiq_target=kasli,artiq_variant=hub artiq-board
<bb-m-labs> The build has been queued, I'll give a shout when it starts
rohitksingh has quit [Quit: Leaving.]
<bb-m-labs> build #1565 of artiq-board is complete: Failure [failed conda_build] Build details are at http://buildbot.m-labs.hk/builders/artiq-board/builds/1565
<bb-m-labs> build forced [ETA 34m45s]
<bb-m-labs> I'll give a shout when the build finishes
mumptai has joined #m-labs
<bb-m-labs> build #1566 of artiq-board is complete: Failure [failed conda_build] Build details are at http://buildbot.m-labs.hk/builders/artiq-board/builds/1566
<bb-m-labs> build #1567 of artiq-board is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-board/builds/1567
<bb-m-labs> build #2390 of artiq is complete: Failure [failed python_unittest_2] Build details are at http://buildbot.m-labs.hk/builders/artiq/builds/2390 blamelist: Robert Jordens <rj@m-labs.hk>, Robert Jordens <jordens@gmail.com>
<bb-m-labs> build #1568 of artiq-board is complete: Failure [failed conda_build] Build details are at http://buildbot.m-labs.hk/builders/artiq-board/builds/1568
<bb-m-labs> build #1569 of artiq-board is complete: Failure [failed conda_build] Build details are at http://buildbot.m-labs.hk/builders/artiq-board/builds/1569
[X-Scale] is now known as X-Scale
mumptai has quit [Remote host closed the connection]