<adambeynon_>
sprockets supports quite a few directives
<adambeynon_>
I think we just need to handle `require` though
<elia>
adambeynon_, tricky stuff, I mean would be good to ask sprockets for the whole bundle for a given file, but then two requires with the same deps would bring in those twice
<elia>
asking for the whole bundle can save us supporting directives of course
<elia>
maybe we can have a sprockets asset type, that lists its requires like others do, leaving directive parsing to sprockets…
<elia>
…just thinking out loud :)
<adambeynon_>
elia: makes sense actually. We can use sprockets in sprockets based environments, and just override the js/coffee processors to use the ones given to Builder
<adambeynon_>
elia: also, do you mind if I change the processors to use a sprockets 4.x style interface
<adambeynon_>
basically, a processors is anything that responds to #call
<adambeynon_>
and each #call method just modifies a hash of data
<elia>
adambeynon_, I restrained myself from moving to sprockets 4 bc it's not clear when it will ship
<elia>
or be part of rails
<elia>
let me check what's the status of sprockets 3
<adambeynon_>
elia: sorry, I meant change our Processor api to be similar to sprockets 4 - we would still actually use sprockets 2.x
<adambeynon_>
elia: *hopefully*, we could support 2 (or 3?) different versions of spockets by just having plugable Builder subclasses
<adambeynon_>
once 3.0 does finally drop
j_mcnally has joined #opal
<elia>
"plugable Builder subclasses" I think I'm missing something, should I check the cache_store branch code?
<elia>
brb
<adambeynon_>
elia: well, our code to handle sprockets 2.x, 3.x and 4.x would be slightly different, so to support all 3 we would need some customization inside our Sprockets::Processor code
<adambeynon_>
should be minimal tbh
j_mcnally has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
shawn42 has left #opal [#opal]
elia has quit [Read error: Connection reset by peer]
_elia has joined #opal
boberetezeke has joined #opal
e_dub has quit [Quit: ZZZzzz…]
<_elia>
adambeynon_, sry, fine by me, only thing to remember is that josh peek explicitly stated that new apis are still unstable
boberetezeke has quit [Ping timeout: 255 seconds]
_elia has quit [Quit: Computer has gone to sleep.]
GitHub179 has joined #opal
<GitHub179>
[opal] adambeynon pushed 3 new commits to cache_store: http://git.io/oOWxsQ
<GitHub179>
opal/cache_store a62810e Adam Beynon: Always construct an asset for storing builder data
<GitHub179>
opal/cache_store eb9775d Adam Beynon: Cleanup new asset building in Builder
GitHub179 has left #opal [#opal]
<GitHub179>
opal/cache_store 5bdcd52 Adam Beynon: Disable cache in demo
elia has joined #opal
travis-ci has joined #opal
<travis-ci>
opal/opal#2183 (cache_store - 5bdcd52 : Adam Beynon): The build was broken.
<adambeynon_>
elia: its a similar issue with updating rspec to the final release. they dont use “real requires” anymore
<adambeynon_>
so opal-rspec could have a #preload_tree() directive to get them all ready
<elia>
yes
<adambeynon_>
they use some spec_core_require() method iirc
<elia>
yes, I think they do it bc require_relative is faster and they care about startup time
<adambeynon_>
elia: talking of startup time, opal-rspec is much faster now with a file store cache ;) since we stopped shipping a compiled version of rspec, it had gotten quite slow to run tests
<elia>
awesome
<elia>
adambeynon_, so, is the branch ready for a merge?
<adambeynon_>
elia: testing it against 2 more rails apps. That last commit ^^^ fixed a bug I forgot about
<adambeynon_>
should be done
<adambeynon_>
hopefully
<adambeynon_>
might cleanup the api of some added methods though
<adambeynon_>
there are now 4 entry points to builder
<elia>
lol
<adambeynon_>
going to try and reduce that back to 2
<elia>
build and build_str?
<adambeynon_>
yeah, those *should* be all we need
<adambeynon_>
I added build_require
<adambeynon_>
but the above bug made that a little obsolete
<elia>
great work on docs btw
<adambeynon_>
lol, I knew I would be lazy and never go back to writing them, so I decided as I cleaned them up, it was a good time
<elia>
kudos :D
<adambeynon_>
I didnt know whether to go rdoc style or yard style with them
<adambeynon_>
I figure yard handles rdoc style as well?
<elia>
I guess, never learnt the difference by heart anyway
<adambeynon_>
(this shows how little I write docs, I never run anything through rdoc or yard…)
<elia>
but doc task I set up uses yard
<elia>
irrc
<elia>
adambeynon_, you're still on vim right?
<adambeynon_>
elia: yep. updated to MacVim though, instead of the terminal
<adambeynon_>
real copy and paste!
<elia>
ha!
<elia>
just saying bc I added xstrings js highlinght to the tmbundle
<elia>
and looks really good
<adambeynon_>
ah yeah. I saw that. I do go back and forth between TM on occassions