<fkchang>
oddly, rspec is telling that's the spec that's failing, but I don't see how the spec matches the error
<fkchang>
Failures:
<fkchang>
<fkchang>
<fkchang>
<fkchang>
1) OpalIrb should return classes
<fkchang>
<fkchang>
ArgumentError:
<fkchang>
comparison of [#<Promise(970)>, HTTP] with ["Numeric", Numeric] failed
<fkchang>
hmm, the spec fail is actually in this line
<fkchang>
opal_classes = subject.opal_classes
j_mcnally has quit [Ping timeout: 250 seconds]
fkchang has quit [Ping timeout: 258 seconds]
elia has joined #opal
fkchang has joined #opal
elia has quit [Quit: Computer has gone to sleep.]
f-3r has joined #opal
<fkchang>
meh`: adambeynon_ has Symbol#to_proc changed with 0.7? If I use this line, I get the Promise comparison classes.uniq.sort_by(&:name) but classes.uniq.sort_by { |cls| cls.name } works fine
elia has joined #opal
<adambeynon_>
fkchang: It shouldn’t have changed… let me check
<fkchang>
or perhaps it's to_proc returns a promise now
<adambeynon_>
fkchang: nope, to_proc doesn’t handle promises at all
<adambeynon_>
fkchang: hmmm, looks like there was a change since last release
<adambeynon_>
seems to be HTTP from opal-jquery causing the issue
<adambeynon_>
which is really confusing
<adambeynon_>
fkchang: as it works fine in opalrb.org
<fkchang>
yeah, also why is HTTP.name == "HTTP"
<fkchang>
but the promise when mapped
<adambeynon_>
fkchang: okay, found the issue
<adambeynon_>
HTTP has overriden the send method
<adambeynon_>
HTTP.send() => Promise
<fkchang>
aha
<meh`>
lol
<adambeynon_>
and to_proc uses obj#send()
<meh`>
adambeynon_, replace with __send__
<adambeynon_>
meh`: seems the plan. is it generally acceptable to override #send() ?
<meh`>
yes
<meh`>
internally always use __send__
<meh`>
it's like __id__
<meh`>
if you don't know what's going on, never use #object_id
<fkchang>
really, I hit a prob when I was trying to map the Vertx eventbus code into Opal, where they have EventBus.send -- don't remember exactly the issue, but I made the map to send_msg instead, maybe I'll undo that
<adambeynon_>
meh`: righty-o
<adambeynon_>
fkchang: If i fix on master, can you run things from git instead?
<adambeynon_>
fkchang: pushed to master ^^ should do the trick
GitHub60 has joined #opal
<GitHub60>
[opal] adambeynon pushed 1 new commit to master: http://git.io/muO53w
<GitHub60>
opal/master 665fee6 Adam Beynon: String#to_proc now uses #__send__ instead of #send
GitHub60 has left #opal [#opal]
<adambeynon_>
Off to watch some Boardwalk Empire.. back in an hour ;)
<fkchang>
adambeynon_: thx
f-3r has quit [Ping timeout: 264 seconds]
fkchang has quit [Read error: Connection reset by peer]