alyssa changed the topic of #panfrost to: Panfrost - FLOSS Mali Midgard & Bifrost - Logs https://freenode.irclog.whitequark.org/panfrost - <daniels> avoiding X is a huge feature
stikonas has quit [Remote host closed the connection]
stikonas_ has quit [Remote host closed the connection]
vstehle has quit [Ping timeout: 272 seconds]
_whitelogger has joined #panfrost
kinkinkijkin has joined #panfrost
<chewitt> morning all
<chewitt> I ran some tests with 5.7-rc4 and the known collection of Amlogic patches earlier
<chewitt> Kodi now starts but I see no output on screen (black screen)
<chewitt> I'm also unable to run kmscube
<chewitt> LibreELEC:~ # kmscube
<chewitt> failed to create gbm surface
<chewitt> failed to initialize GBM
<chewitt> same on both G31/G52
<chewitt> the only thing patches in mesa is the whitelist http://paste.ubuntu.com/p/f8M35qTrWw/
<chewitt> oddly Kodi reports a T830 chip
<chewitt> see http://ix.io/2kyi
kinkinkijkin has quit [Ping timeout: 260 seconds]
_mixfix41_ has quit [Ping timeout: 260 seconds]
bnieuwenhuizen has quit [Ping timeout: 260 seconds]
bnieuwenhuizen_ has joined #panfrost
bnieuwenhuizen_ is now known as bnieuwenhuizen
Elpaulo has quit [Read error: Connection reset by peer]
Elpaulo has joined #panfrost
davidlt has joined #panfrost
buzzmarshall has quit [Remote host closed the connection]
vstehle has joined #panfrost
<tomeu> chewitt: it's very odd that it displays t830
<chewitt> tomeu can you sanity check that patch, me and code are not always a good combo :)
<tomeu> chewitt: which one?
<chewitt> I assume it worked as without it Kodi fails to start after trying to use swrast
<chewitt> are there more points in mesa code where we need to force some kind of "GPUIsBifrost" check?
<icecream95> chewitt: If assertions are disabled panfrost_model_name is Undefined Behaviour on Bifrost so could return anything
<icecream95> You can enable assertions by adding -Db_ndebug=false when running meson
chewitt has quit [Read error: Connection reset by peer]
chewitt_ has joined #panfrost
<chewitt_> icecream95 I can try that in a bit
chewitt_ is now known as chewitt
<chewitt> May 04 06:54:17 LibreELEC kodi.sh[2695]: kodi.bin: ../src/panfrost/encoder/pan_props.c:111: panfrost_model_name: Assertion `!"Invalid GPU ID"' failed.
<chewitt> May 04 06:54:23 LibreELEC kodi.sh[2691]: Aborted (core dumped)
<chewitt> so I'll go patch some values there too and see what happens :)
raster has joined #panfrost
<chewitt> second ID patch fixes chip detection http://ix.io/2kHL
<chewitt> now shows as G31
<chewitt> systemd journal http://ix.io/2kHM
doublej472 has quit [Read error: Connection reset by peer]
doublej472 has joined #panfrost
chewitt_ has joined #panfrost
chewitt has quit [Ping timeout: 258 seconds]
<daniels> chewitt_: thanks! could you please send that as an MR?
<chewitt_> daniels, with or without the T628 enable in the whitelist?
chewitt_ is now known as chewitt
<daniels> I assume the 628 is still broken?
<chewitt> I didn't get far with it
<daniels> in that case separate sounds good - one to just get the Bifrost IDs in line with the rest, and then another can add 628 to the whitelist when it's safe to be whitelisted :)
<chewitt> k
cwabbott has joined #panfrost
<chewitt> MR 4870 submitted
stikonas has joined #panfrost
yann has quit [Read error: Connection reset by peer]
cwabbott has quit [Quit: cwabbott]
cwabbott has joined #panfrost
NeuroScr has quit [Quit: NeuroScr]
icecream95 has quit [Ping timeout: 246 seconds]
bnieuwenhuizen has quit [Ping timeout: 272 seconds]
raster has quit [Ping timeout: 272 seconds]
yann has joined #panfrost
raster has joined #panfrost
Elpaulo has quit [Quit: Elpaulo]
Elpaulo has joined #panfrost
bnieuwenhuizen has joined #panfrost
raster has quit [Remote host closed the connection]
raster has joined #panfrost
<tomeu> chewitt: why not just sue this branch? https://gitlab.freedesktop.org/tomeu/mesa/-/commits/bifrost
<chewitt> err, didn't know about it :)
<chewitt> I track master normally
<tomeu> sorry, I lost track of who I have mentioned it to :)
<tomeu> not completely sure alyssa will agree, but I think we would prefer to whitelist GPUs only once they are at rough parity with existing ones and are under CI
<tomeu> otherwise we'll be supporting people who want to try it out instead of writing code
<chewitt> no problem
<chewitt> I'll close the MR
<alyssa> icecream95: ..or sw decompress. but who knows
<alyssa> tomeu: "not completely sure alyssa will agree, but I think we would prefer to whitelist GPUs only once they are at rough parity with existing ones and are under CI"
<alyssa> ^ This is exactly my policy.
<alyssa> mesa ships to end-users automatically via distributions. If we ship a bad driver, we will cause real problems for real people, and we probably won't even know about it. Hence the whitelist.
cwabbott_ has joined #panfrost
cwabbott has quit [Ping timeout: 246 seconds]
cwabbott_ is now known as cwabbott
buzzmarshall has joined #panfrost
<robmur01> however AFAIK whether SoC vendors enable support for the various proprietary formats at integration time depends on whether they can be bothered to sort out licenses ;)
<robmur01> according to the RK3288 datasheet, "W" variants "Support DirectX", which presumably implies the old regular (and "c") ones don't
<robmur01> (much like there's apparently also a "D" variant with whatever Dolby licensing applies to the audio IP)
<alyssa> robmur01: Cute, ok :)
<alyssa> I don't suppose any windows mali actually happened..
<alyssa> tomeu: FBO stuff looks remarkably similar to midgard mfbd
<alyssa> big diff is block = TILED is always true
<alyssa> and .unk3 = 0xc,
<alyssa> for an FBO
<alyssa> .unk3 = 0x4,
<alyssa> for no
<alyssa> so I assume unk3 is the real layout specifier, probably shifted some bits
<alyssa> It's not clear to me whether that's AFBC or tiled.
<alyssa> Easy way to find out :3
<alyssa> `idea2` is current branch of bifrost hacks for me
<alyssa> tomeu: shadow crash is since rt_count=0, working on it
<alyssa> ^ Hardware z/s wallpapering in bifrost! :tada:
<alyssa> Okay, random magic bits later and no fault but no work either.
<alyssa> tomeu: `shadow` branch has enough for -bshadow
<alyssa> needs some serious cleanup but It Works
nerdboy has joined #panfrost
tomboy64 has quit [Remote host closed the connection]
tomboy64 has joined #panfrost
raster- has joined #panfrost
raster has quit [Disconnected by services]
raster- has quit [Client Quit]
raster has joined #panfrost
NeuroScr has joined #panfrost
<bbrezillon> alyssa: nice
<bbrezillon> alyssa: FWIW, it's also supported on Midgard ;)
<alyssa> bbrezillon: wha?
<alyssa> in hw?
<bbrezillon> but there seems to be cases where it doesn't work
<bbrezillon> yep
<bbrezillon> I've seen the blob emit those HW wallpapering desc
<bbrezillon> but not always
<alyssa> incredible :p
<alyssa> zero 4 <--> unknown1, okay, yeah, sure
davidlt has quit [Ping timeout: 240 seconds]
icecream95 has joined #panfrost
<icecream95> From the "Getting Started" tab on https://releases.linaro.org/members/arm/openembedded/juno-lsk/latest/, it appears that Midgard was designed to support OpenGL 4.2
<alyssa> icecream95: Oh, that's an incredible find, nice!!
<alyssa> I suspected something like that given the GL_QUADS support (etc) but nice to see a primary source
<HdkR> Oh neat
<alyssa> I should check if Bifrost supports quads..
<alyssa> The obvious tests for it require x11 which I don't have piped through yet
<cwabbott> I wonder if they support all the super-fun legacy stuff like point-coord replacement then
<alyssa> cwabbott: I wouldn't be surprised tbh.
<alyssa> Given how literally they seem to interpret the spec in hw :)
raster has quit [Quit: Gettin' stinky!]
<alyssa> cwabbott: As it is, gl_PointCoord is done as a magic `elements` value on midgard, with normal ld_vary instructions
<alyssa> same with gl_FragCoord (c.f. bifrost sysval)
<alyssa> so ignoring Y-flips, you don't need to key the shader.
<cwabbott> yeah, but with legacy stuff you can replace literally any varying with gl_PointCoord
<cwabbott> for compatibility with legacy fixed-function stuff
<alyssa> exactly
<cwabbott> oh, yeah
<alyssa> it's a magic gl_PointCoord address so the replacement is just scribbling over the address
<cwabbott> right
<cwabbott> iirc it wasn't like that on bifrost
<alyssa> not sure if there's a gl_PointCoordFlipped address too... right now I ignore the orientation and since the stars in neverball are symmetric nobody's noticed :p
<chewitt> @alyssa https://imgur.com/a/umowC9k :)
<alyssa> chewitt: yeah, sorryto mention you needed that commit
<alyssa> does kodi fail in any particularly spectacular way?
<chewitt> not yet, but we're only approaching our third minute of uptime :)
<alyssa> chewitt: so kodi works?
<alyssa> I mean, at least a little?
<chewitt> as long as you navigate from memory and fuzzy shapes, all is good
<alyssa> chewitt: Progress is progress :o
<alyssa> Blending is pretty broken right now so that explains the text issues and maybe others.
<chewitt> baby steps .. but awesome steps to see nonetheless
<alyssa> :)
<alyssa> changing `0x958020` to `0x951020` in pan_cmdstream.c might get you further but I don't endorse such a giant hack
bnieuwenhuizen has quit [Ping timeout: 265 seconds]
<chewitt> no obvious differences .. still looks like minecraft with an epic hangover
<alyssa> lol, alright
<alyssa> well, a lot more bifrost work is in the pipes, so I'll ping when there's hopefully an improvement :)
<chewitt> ISTR the first run of midgard looking similar not so long ago
<alyssa> :-)
<alyssa> ("And look how that turned out.")
<chewitt> indeed .. how time flies
<robmur01> lolwut, Linaro quoting somewhat-out-of-context chunks of the T600 configuration manual?
<HdkR> [REDACTED]