00:53 <_whitenotifier-f> [scopehal] azonenberg opened issue #236: Refactoring: Make Statistic derive from FlowGraphNode - https://git.io/JU82c

00:53 <_whitenotifier-f> [scopehal] azonenberg labeled issue #236: Refactoring: Make Statistic derive from FlowGraphNode - https://git.io/JU82c

00:53 <_whitenotifier-f> [scopehal] azonenberg labeled issue #236: Refactoring: Make Statistic derive from FlowGraphNode - https://git.io/JU82c

04:34 <azonenberg> miek: ping

04:41 <azonenberg> What does the "ALT" trigger type in agilent do?

04:41 <azonenberg> I'm working on refactoring the whole trigger subsystem and starting to look at holes in the current API

05:40 <azonenberg> Lovely, there are hidden objects in the LeCroy COM hierarchy that don't show up in the browser

05:40 <azonenberg> Like app.Acquisition.Trigger.Source

05:54 <azonenberg> actually wait, it IS in the browser

05:54 <azonenberg> But the refresh button in the browser doesn't work

05:54 <azonenberg> i have to close and reopen it

05:54 <azonenberg> Not sure if better or worse

06:09 <azonenberg> https://www.antikernel.net/temp/trigger-bug.png

08:11 <_whitenotifier-f> [scopehal] azonenberg pushed 3 commits to master [+6/-0/±45] https://git.io/JU8Sn

08:11 <_whitenotifier-f> [scopehal] azonenberg b4a7a83 - Refactoring: Removed some unused Oscilloscope APIs related to triggers. See #216.

08:11 <_whitenotifier-f> [scopehal] azonenberg 9a9ba7e - Refactoring: moved Trigger into its own class in preparation for advanced trigger support. See #216.

08:11 <_whitenotifier-f> [scopehal] azonenberg aa100c9 - LeCroyOscilloscope: fixed bugs in refactoring

08:11 <_whitenotifier-f> [scopehal-apps] azonenberg pushed 1 commit to master [+0/-0/±7] https://git.io/JU8SC

08:11 <_whitenotifier-f> [scopehal-apps] azonenberg 5ca948e - Updated UI code for new first-class Trigger object. Minimal refactoring so far; basically assumes everything is an EdgeTrigger.

08:16 <azonenberg> noopwafel: when you get a chance look at that new code

08:16 <azonenberg> tell me if you think that's a decent way to do it

08:16 <azonenberg> it doesn't add any new capabilities at this point, just refactoring.

10:22 <miek> azonenberg: it triggers on alternating edges, so if it triggered on a rising edge it makes sure the next trigger is on a falling edge

15:39 <azonenberg> miek: weird

15:39 <azonenberg> i've never seen that in any other instrument

15:40 <azonenberg> So that's going to be a fun challenge for our object model, how to handle new enum types per instrument. Let me think a bit about this

16:03 <_whitenotifier-f> [scopehal] azonenberg pushed 1 commit to master [+2/-0/±2] https://git.io/JU4sl

16:03 <_whitenotifier-f> [scopehal] azonenberg 39ae34a - Initial implementation of AgilentEdgeTrigger

16:03 <azonenberg> miek: how's that look?

16:03 <azonenberg> there's no UI to invoke it yet

16:04 <azonenberg> But it's in the object model and should be usable from C++ code now

16:36 <azonenberg> miek: also please check for any regressions in this

16:36 <_whitenotifier-f> [scopehal-apps] azonenberg pushed 1 commit to master [+0/-0/±1] https://git.io/JU4ZJ

16:36 <_whitenotifier-f> [scopehal-apps] azonenberg 3426d3d - Updated submodules

16:36 <azonenberg> I verified it compiles, but can't do functionality testing because i dont have any agilent/keysight gea

16:36 <azonenberg> gear*

16:37 <azonenberg> also, long term we may want to rename the driver to "keysight" if it is the same protocol used by modern gear

19:56 <miek> will do. today's been pretty busy but i'll take a look when i get a chance

19:58 <miek> i'm fine with a rename, going with the latest name probably does make the most sense. may want to wait and see how it goes as more gear is added though - i'm still not sure how much of the range it'll work with

20:01 <azonenberg> Yes

20:01 <azonenberg> That's why i've held off on the rename

20:01 <azonenberg> we may need one for old agilent and one for modern keysight

20:05 <azonenberg> incidentally we could probably emulate the alternate trigger mode in softwarer

20:05 <azonenberg> since our "normal" trigger is actually just one-shot anyway