00:15 <stellar-slack1> <sacarlson> well you can't send as both so I guess we should all just receive or look in both types at least.

03:39 <stellar-slack1> <sacarlson> http://zipperhead.ddns.net/stellar_min_client.html now incorporates this method for you all to try to see if it works

03:41 <stellar-slack1> <sacarlson> on the server side mss-server doesn't care if it's a number or a string it looks in both when "memo" is searched.

03:46 <stellar-slack1> <dzham> Doesn’t the SDM keep track of memotype? It’s in the XDR

03:51 <stellar-slack1> <sacarlson> I'm not sure. I should take out that code and see if it does the same

03:53 <stellar-slack1> <sacarlson> it seems you have a choice in sdk StellarSdk.Memo.text(memo.value) or StellarSdk.Memo.id(memo.value) maybe there is another way?

03:54 <stellar-slack1> <sacarlson> with the small added code it decides for you

03:55 <stellar-slack1> <sacarlson> on the send client side

05:26 <stellar-slack1> <dzham> does ‘manage_offer' ever create any effects other than ‘trade’?

05:27 <stellar-slack1> <sacarlson> it sits doing nothing if it doesn't hit a price target

05:27 <stellar-slack1> <sacarlson> other than that I can't think of any

05:28 <stellar-slack1> <dzham> But looking at the db there are tonnes of offers posted

05:28 <stellar-slack1> <dzham> but I can’t find the effects for that

05:28 <stellar-slack1> <dzham> I.e., “offer created”, “offer removed”, “offer updated"

05:28 <stellar-slack1> <dzham> All I see is ‘trade'

05:29 <stellar-slack1> <sacarlson> looking at transactions?

05:29 <stellar-slack1> <dzham> yeah,, well `/effects`

05:31 <stellar-slack1> <sacarlson> a change does take place in lastmodified if an order strike price is changed

05:32 <stellar-slack1> <dzham> Oh, in Horizon, I mean

05:32 <stellar-slack1> <sacarlson> oh ok I us mss-server to get results

05:36 <stellar-slack1> <dzham> Oh, man, this is f-ed up. If I find a ‘trade’-effect and look at it’s operation to find the OTHER effects that operation had, there are nothing but ‘trade'

05:37 <stellar-slack1> <dzham> no “offer removed” or “offer updated"

05:37 <stellar-slack1> <dzham> @jed: ^^^

05:37 <stellar-slack1> <sacarlson> what is your final goal of result?

05:38 <stellar-slack1> <dzham> tracking the effects are the easiest way to have a nice “transaction” history

05:38 <stellar-slack1> <dzham> … in a wallet

05:40 <stellar-slack1> <sacarlson> oh IC, ya I have no method to look at transaction history yet ether. only thing I have is {"action":"get_markt_price", "sell_asset":"BBB","sell_amount":4,"buy_asset":"AAA"}

05:41 <stellar-slack1> <sacarlson> I might be able to create a search for trades that took place from the stellar-core db

05:58 <stellar-slack1> <jed> dzham: can you make an issue in horizon

05:59 <stellar-slack1> <dzham> jed, I will, just looking around a little first to make sure I’m not making things up

06:19 <stellar-slack1> <sacarlson> done added this function in mss-server {"action":"get_tx_offer_hist"}

06:20 <stellar-slack1> <sacarlson> In a few minuts I'll add these filters {"action":"get_tx_offer_hist", "sell_asset":"BBB","buy_asset":"AAA"}

07:55 <stellar-slack1> <sacarlson> I've added filters for both sell and buy assets and issuers of each example: {"action":"get_tx_offer_hist","sell_asset":"BBB","sell_issuer":"GAX4CUJEOUA27MDHTLSQCFRGQPEXCC6GMO2P2TZCG7IEBZIEGPOD6HKF"}. I'm going to add one more filter to return only open or closed offers

10:17 <stellar-slack> <sacarlson> I'm sure it's not 100% solution but it should work until the server side is fixed by the gateways

10:27 <stellar-slack> <sacarlson> it also seems to just do an int if you send 1.234 you get "memo_id","memo_id":1,"memo_value":"1"

10:28 <stellar-slack> <sacarlson> but I assume that the gateway won't send you anything but an int or a string

10:54 <stellar-slack> <sacarlson> @bartek so from reading you link you think this is a better solution using Number.isNaN("37"); ?

11:03 <stellar-slack> <sacarlson> I tried using Number.isNaN but it fails when string is "abcd" as it still thinks that is a number so maybe neather would work

11:22 <stellar-slack> <powderfan> I would definately urge gateways to look at both text_memo *and* id_memo. As a wallet developer I can say: 1. I can only send id *or* text 2. as discussed above it is hard to tell, when to use which one 3. I definately want to bother my users with this decision 4. This results in centaurus always sending text

11:29 <stellar-slack> <dzham> why did people start using text tags?

11:29 <stellar-slack> <powderfan> Or is it, that a destination account can specify, which type of memo it preferes to receive? Than I could imagine to make a switch in my wallet to send an id (and restrict input to integer) as soon as the destination address is specified

11:30 <stellar-slack> <powderfan> If you don't send to a gatway but to a friend, text memos are just nicer

11:34 <stellar-slack> <powderfan> I know that kraken accepts both text *or* id

11:46 <stellar-slack> <bartek> @sacarlson isNaN test if value is a special js property NaN. I'm on mobile so it's hard to type so I won't explain it but check out this article https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/NaN

11:47 <stellar-slack> <bartek> I don't think there is a function that checks if a value is an integer (also in string) in js. You'd probably need to use regexp.

15:07 <stellar-slack> <sacarlson> as shown @bartek my present method works between the two different gateways. if you show me a third gatway the my method dosen't work then we will make a new one

15:08 <stellar-slack> <sacarlson> but like powderfan states the gateways should accept both text of int id

15:18 <stellar-slack> <sacarlson> @dzham: text tags can be conveted to int or float or stay strings, but int is not easy to convert the other way. way would you want to be using int?

15:21 <stellar-slack> <jed> it is nicer to the network

15:22 <stellar-slack> <sacarlson> why?

15:23 <stellar-slack> <sacarlson> why not both?

15:24 <stellar-slack> <sacarlson> if you didn't want to use strings why did you add them to the network?

15:26 <stellar-slack> <sacarlson> mss-server can't tell the difference

21:35 <stellar-slack1> <bartek> Memo.id takes less space

23:48 <stellar-slack1> <p41n3st> Hello guys. Ahm, i have a question. How can i compile stellar? I try at VS on windows 7 and it throw error. If someone can help me i would be grateful

23:50 <stellar-slack1> <sacarlson> you might add what error message you see and at what point