<dignifiedquire>
Hey jbenet, daviddias I would like to start helping out on the node implementation, any pointers directions where to best start looking, simple tasks I could do?
<daviddias>
dignifiedquire: absolutely :) I can start popping up issues with things I have on my track and cc you
<dignifiedquire>
that would be great :)
<daviddias>
Also, I'm happy to give you a run through of the state of things, what is already done (compatible with the most recent go-ipfs impl)
<daviddias>
dignifiedquire: is dignifiedquire your github handle too?
<dignifiedquire>
yep
<daviddias>
perfect
<daviddias>
I'll start pushing those issues today :)
<daviddias>
dignifiedquire: do you happen to be in Seattle?
<daviddias>
oh, so are you going to CCC or Battlemesh?
<daviddias>
I'm flying on July 31 to Berlin
<dignifiedquire>
I wanted to go to ccc camp, but probably won’t make it
kbala has joined #ipfs
<daviddias>
ANN: Everyone is welcome to join us this Thursday at Impact Hub for an IPFS meetup - http://attending.io/events/ipfs-seattle-july-2015 lot's of exciting stuff to share. We will try to make sure the talks will be in video later, but if you are in the area or close, we would love to hangout in person :)
<thefinn93>
let me just allow a huge pile of 3rd party JS to run so i can click accept on attending.io
<dignifiedquire>
daviddias, damn now I want to come even more
<daviddias>
thefinn93 ahahah
<daviddias>
dignifiedquire you are still on time to get one of the golden tickets :)
<thefinn93>
im also digging the complete lack of TLS
<thefinn93>
which is frustrating because I really like the concept
<thefinn93>
and like, how the fuck do i do my profile?
<thefinn93>
i want to do a profile pic and description by my name too!
www has quit [Ping timeout: 244 seconds]
rschulman_ has quit [Ping timeout: 248 seconds]
<daviddias>
thefinn93: right, didn't you login with twitter? attending.io is quite cool due to simplicity and frictionless to create a good event page, but yeah, there is somethings they could definitely improve
<thefinn93>
no i hit "sign in with email"
qster123` has joined #ipfs
<thefinn93>
since i hadn't unblocked twitter's JS
qster123 has quit [Read error: Connection reset by peer]
<thefinn93>
so non-twitter signins are sub-par?
<thefinn93>
meh
<daviddias>
thefinn93 if you enter attending.io, in the up right corner there is a image of your profile, if you click it, you go to a page where there is a "Edit profile" button
<daviddias>
I used twitter, so it fetched my photo and bio automatically
<daviddias>
nevertheless, swarm as a component itself does more than multiplexing, and although it has tests now
<daviddias>
it would be good to have tests for havoc scenarios
<daviddias>
and see how it behaves
<dignifiedquire>
okay, I’ll take a look and see what I understand ;)
<daviddias>
thank you :)
<dignifiedquire>
why are you using lab for testing? :P
patcon has quit [Ping timeout: 240 seconds]
<daviddias>
dignifiedquire: why shouldn't I?
<daviddias>
I like that dignifiedquire also detects memory leaks and free code coverage report
<daviddias>
but for example, in abstract-stream-muxer, I use tape
<dignifiedquire>
the last project I used it in, it bit me pretty hard, because it’ became reall slow and horrible to debug when trying to integrate it with babel :(
<dignifiedquire>
but yes the leak detection and fee coverage reports are nice, no question asked
<dignifiedquire>
the main thing I’m missing is “.only” and “.skip”
<daviddias>
well, I'm happy to change if we get something better (or less worse), could you make a case in a issue explaining the problems you hit and how you solved them? Sometimes I wish there would be a `standard` for tests as well
<daviddias>
one thing I miss in lab is the `.plan()` I get in tape
<daviddias>
I believe lab can do .only and .skip too
<daviddias>
skip - skip execution. Cannot be overridden in children once parent is set to skip.
<daviddias>
only - marks all other tests or experiments with skip. This doesn't mark all other experiments and tests in a suite of scripts as skipped, instead it works within a single test script
<dignifiedquire>
interesting, that must be new, because the last time I looked for it, the only had “grep” which was a pain to use
<dignifiedquire>
I’m a die hard mocha fan, mostly because of it’s excellent integration with other tojs compilers and async/promise suppport
<dignifiedquire>
but I don’t think it’s really worth it to switch, unless you are using a lot of promise pased things (which is painful to use in lab, because it requires you to use callback style always
<dignifiedquire>
have you already setup the abstract-stream-muxer tests somewhere, or does that still need to be integrated?
notduncansmith has quit [Read error: Connection reset by peer]
rschulman_ has joined #ipfs
<lgierth>
nice, digitalocean doesn't support ed25519 ssh keys
zabirauf has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
cjb has quit [Ping timeout: 246 seconds]
Arceliar has quit [Quit: Leaving]
Bat`O has quit [Ping timeout: 264 seconds]
Bat`O has joined #ipfs
<Luzifer>
poor dog :'(
patcon has quit [Ping timeout: 240 seconds]
therealplato1 has joined #ipfs
pinbot-test has joined #ipfs
notduncansmith has joined #ipfs
notduncansmith has quit [Read error: Connection reset by peer]
therealplato has quit [Ping timeout: 256 seconds]
www1 has joined #ipfs
pinbot-test has quit [Remote host closed the connection]
www has quit [Ping timeout: 265 seconds]
pinbot2 has joined #ipfs
<ipfsbot>
[go-ipfs] whyrusleeping created vendor/notifier (+1 new commit): http://git.io/vmQZb
<ipfsbot>
go-ipfs/vendor/notifier 6afe9e8 Jeromy: vendor notifier outside of go-ipfs...
notduncansmith has joined #ipfs
notduncansmith has quit [Read error: Connection reset by peer]
<ipfsbot>
[go-ipfs] whyrusleeping opened pull request #1498: vendor notifier outside of go-ipfs (master...vendor/notifier) http://git.io/vmQny
Bat`O has quit [Ping timeout: 248 seconds]
Bat`O has joined #ipfs
<ipfsbot>
[go-ipfs] jbenet pushed 2 new commits to master: http://git.io/vmQWs
<ipfsbot>
go-ipfs/master 5f29497 Juan Benet: Merge pull request #1497 from MichaelMure/mount-options...
<ipfsbot>
go-ipfs/master 78e9794 Michael Muré: Add the missing long argument for ipfs mount...
<tperson>
jbenet, I feel like we should be able to ask the fstream if it is closed yet
notduncansmith has joined #ipfs
notduncansmith has quit [Read error: Connection reset by peer]
<tperson>
And at the end of the for loop we can close the stream. Inside of multipartdir we should wait till the stream ends.
<ipfsbot>
[go-ipfs] whyrusleeping created fix/ci-test-skip (+1 new commit): http://git.io/vmQWQ
<ipfsbot>
go-ipfs/fix/ci-test-skip a4efe42 Jeromy: make timing tests actually not run under CI...
<jbenet>
tperson: i think i figured out why it's wrong. you're on to it. this code is all sync, and pipe assumes async.
<ipfsbot>
[go-ipfs] whyrusleeping opened pull request #1499: make timing tests actually not run under CI (master...fix/ci-test-skip) http://git.io/vmQWN
pinbot2 has quit [Remote host closed the connection]
pinbot2 has joined #ipfs
<jbenet>
tperson: either the rest of the operation needs to be async, or need to readSync all the things (which is bad practice anyway). these functions should take a cb(err, result) callback. i dont have time atm to take care of it atm, but maybe later.
* whyrusleeping
is tired of random test failures
<tperson>
Is there an absolute need for this api to do the reading from the file system instead of having the user handle it?
patcon has joined #ipfs
<jbenet>
whyrusleeping: me too, it's annoying.
<jbenet>
tperson: i want our APIs to be consistent across the board. if "ipfs add -r path" works in the cli, it should work exactly the same from the node interface, and from the golang shell. (maybe node-ipfs-api and node-ipfs-shell are different things... but _one_ thing should be consistent across the board so people dont have to learn what works where and be
<jbenet>
confused when the world is different
<jbenet>
if _i'm_ confused by this, imagine people who dont know much about ipfs and how the various tools work
<tperson>
THe thing is the API (rest) doesn't take a path, it takes a set of files.
<tperson>
There are two different interfaces.
<tperson>
CLI and API
<ipfsbot>
[go-ipfs] jbenet closed pull request #1499: make timing tests actually not run under CI (master...fix/ci-test-skip) http://git.io/vmQWN
<jbenet>
tperson: the http API logically can't take a path -- as it is in another environment (machine, etc), but the libraries and the cli that we give users should be nice.
<jbenet>
the library and cli Shells should be consistent
notduncansmith has joined #ipfs
notduncansmith has quit [Read error: Connection reset by peer]
atrapado has quit [Quit: Leaving]
<ipfsbot>
[go-ipfs] whyrusleeping pushed 1 new commit to fix/dht-test-connect: http://git.io/vmQB6
<ipfsbot>
go-ipfs/fix/dht-test-connect 6564fae Jeromy: comment for future @jbenet and @whyrusleeping's to understand reasoning...
pinbot2 has quit [Remote host closed the connection]
<ipfsbot>
[go-ipfs] whyrusleeping pushed 1 new commit to master: http://git.io/vmQ0l