<purezen>
Have been able to reproduce the issue on my end.. Have got the expected error message in jirb console.
<purezen>
How do I proceed from here?
JRubyGithub has joined #jruby
<JRubyGithub>
[jruby] mkristian opened issue #2474: truffle artifacts are not on maven central and we have a release repo in jruby-parent.pom http://git.io/AogJqA
JRubyGithub has left #jruby [#jruby]
<electrical>
purezen: most cases you can start working on it in a branch and submit a PR if you think you fixed it. and have it reviewed
<purezen>
electrical: Hey, looks like I have to add a constant in this case. Where do I look to add it?
<electrical>
purezen: no idea to be very honest. im not so deep in the jruby project :-)
<purezen>
electrical: Ok
paulswilliamsesq has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
JRubyGithub has joined #jruby
<JRubyGithub>
[jruby] chrisseaton opened issue #2475: Truffle: Understand and reduce impact of Truffle on the distribution size http://git.io/bahFGQ
JRubyGithub has left #jruby [#jruby]
tenderlove has joined #jruby
mkristian has joined #jruby
<mkristian>
chrisseaton, good morning
<chrisseaton>
hi
<mkristian>
did you see my last issue ?
<mkristian>
when I played around with getting truffle into its own jar, I realized this blocker for maven central. the oracle truffle artifacts are not maven central
<chrisseaton>
How does JRuby get it's jars onto central?
<chrisseaton>
*its*
vyorkin has joined #jruby
<mkristian>
we have an account with sonatype and headius, enebo and some others can push artifacts to the groupId 'org.jruby' and 'rubygems'
<mkristian>
let me get you the info page on how to set it up
<mkristian>
are those truffle libraries open source ?
<chrisseaton>
yeah
purezen has quit [Ping timeout: 246 seconds]
<mkristian>
cool
JRubyGithub has joined #jruby
<JRubyGithub>
[jruby] chrisseaton pushed 1 new commit to truffle-head: http://git.io/ugArIw
<JRubyGithub>
jruby/truffle-head eb53c1b Chris Seaton: Merge branch 'master' into truffle-head
JRubyGithub has left #jruby [#jruby]
kl has joined #jruby
zorak8 has joined #jruby
<electrical>
mkristian: hiya. we are still using jar-dependencies and works great. i do have a question though. we have some plugins that require the same jars ( kafka input and output for example ) is there a nice way to share jars somehow?
<mkristian>
electrical, are you bundle the jars with the gem or just declare them ?
<electrical>
mkristian: just declaring them in the gemspec
<mkristian>
electrical, then they are shared via maven local repo. or did I miss the point of the question ?
<electrical>
mkristian: i mean when the jars are being installed on the system. at the moment they are vendored inside each gem locally.
<electrical>
sorry i wasn't clear :-)
<mkristian>
yes, I see. hmm
<mkristian>
let me have look if it possible to avoid this "vendoring"
<electrical>
the advantage now is that when we remove the gem it removes the jars as well since it just removes the directory so doing an upgrade is easy.
<electrical>
but it does cause some duplicate jars
<electrical>
would be nice if the following could happen: 1. install jars into a single place and re-use them if they already exist. 2. On gem removal check if no other gemspec has the jars required and then delete them,. otherwise keep them.
metadave has joined #jruby
vyorkin has quit [Quit: WeeChat 1.0.1]
<electrical>
this way we could have the kafka input and output share the same jars.
JRubyGithub has joined #jruby
<JRubyGithub>
[jruby] chrisseaton pushed 1 new commit to truffle-head: http://git.io/h-dm8w
<JRubyGithub>
jruby/truffle-head f097640 Chris Seaton: [Truffle] Disable DSL boxing optimisations....
JRubyGithub has left #jruby [#jruby]
<mkristian>
electrical, ok - first there is the "property" JARS_VENDOR which can turn off the vendoring of jars inside the gems. in this case the jars have to be in local maven repo. which happens when you install the gem
<mkristian>
so it is close to your idea. just the deleting is missing
<electrical>
ah okay.. can we set a specific directory where it needs to install the jars? so we can include them in LS in a specific dir?
<mkristian>
if you do not want to use the regular local maven repo you can set JARS_HOME to where you want to store the jars
<mkristian>
but there is no delete on uninstall of a gem
<electrical>
okay
<electrical>
that would require a post uninstall hook i guess?
metadave has quit [Ping timeout: 264 seconds]
<electrical>
which would be quite difficult because it would require to check all gems for jar dependencies, compile the list and then check if any of the installed jars are not required anymore.
<mkristian>
yes and probably an explicit trigger to do so. since the local maven repo is not I place where I suppose to delete stuff. if you think this to be a nice "extra" please file an issue on jar-dependencies and I will see to it
<mkristian>
yes, that is true as well
purezen has joined #jruby
<mkristian>
it is bigger task
<electrical>
yeah indee
<electrical>
which doesn't make it easier. lol
benlovell has joined #jruby
<purezen>
Looks like I got disconnected.
<purezen>
Anyways, where do I have to look for to add the constant?
<purezen>
headius, mkristian ping :)
<mkristian>
purezen, I have no context ! on the last question
johnmuhl has joined #jruby
<purezen>
mkristian, Hey, so I looked into the GH issue #1359.
<purezen>
Also, I was able to reproduce it locally. In the ./bin/jirb shell.
anaeem1 has quit [Remote host closed the connection]
<purezen>
Now, I need some guidance on moving forward?
<mkristian>
let's see if I am the irght person to help ;)
<purezen>
Basically, I want to know where I need to look for working on bugs for improving ruby version 2.0-2.2 compat.
<purezen>
mkristian, Oh, :D:D
anaeem1 has joined #jruby
anaeem1 has quit [Remote host closed the connection]
<mkristian>
ok - socket is build in library. now I need to find it in java part of jruby in core/src/main/java/org/jruby
anaeem1_ has joined #jruby
<mkristian>
purezen, it is the extension under: core/src/main/java/org/jruby/ext/socket/
anaeem1_ has quit [Remote host closed the connection]
anaeem1 has joined #jruby
<purezen>
Hmm..
<mkristian>
have a look at /core/src/main/java/org/jruby/ext/socket/RubySocket.java there a lot of constants are defined ;)
anaeem1 has quit [Ping timeout: 245 seconds]
<purezen>
Ok.
<purezen>
Hmm.. so this will be added in RubySocket class with like 'rb_mConstants.setConstant..' ?
<mkristian>
yes, this is just a ruby class written in java ;)
<purezen>
Ok, cool!
<purezen>
Going through it..
anaeem1_ has joined #jruby
tenderlove has joined #jruby
benlovell has quit [Ping timeout: 245 seconds]
benlovell has joined #jruby
tenderlove has quit [Ping timeout: 245 seconds]
anaeem1_ has quit [Remote host closed the connection]
<purezen>
mkristian, So, 'rb_mConstants.setConstant("IFF_MULTICAST", arg2)' will add the constant, right? And what will be the second argument?
<purezen>
Does it set the length of the constant?
<mkristian>
it should be the "value" of the constant. like IFF_MULTICAST has the value 32768 (which I got from the issue-1359)
kares has joined #jruby
<purezen>
Well, I got a diff. value in my irb session (mri).
<purezen>
43.. something
<mkristian>
hmm - I am not familiar with what IFF_MULTICAST is used for
<purezen>
Hmm.. ruby-doc says 'Socket::Ifaddr represents a result of getifaddrs() function.'
<purezen>
Looks like a port number to me.
<purezen>
Also, jirb is printing the no. which I passed as 2nd argument as Socket::IFF_MULTICAST
<purezen>
So, I get that the thing with 2nd arg atleast :)
<mkristian>
could be, but multicast - does it has a port. well, at least you know now how to setup ruby constants in java ;)
<purezen>
:D:D that was a wild guess.. but yeah I got that :) Thx there!
<purezen>
I am just concerned that if it is a fixed value.
<mkristian>
in MRI the socket.rb uses a socket.so - maybe looking a the source of this socket.so helps to understand what IFF_MULTICAST is.
<purezen>
Hmm.. I was looking for that
<purezen>
Btw, what's a good way to refer mri source?
anaeem1_ has joined #jruby
<purezen>
I am just browsing it on gh
<mkristian>
sorry - I am the wrong person to ask here. I know jruby-openssl is using the native code as reference - not sure the java code does carry some textual references
josh-k_ has joined #jruby
<purezen>
ok
zorak8 has quit [Ping timeout: 276 seconds]
josh-k has quit [Ping timeout: 264 seconds]
<purezen>
so, I will comment on the issue on gh for now
e_dub has joined #jruby
paulswilliamsesq has joined #jruby
mitchellhenke has joined #jruby
benlovell has quit [Quit: leaving]
paulswilliamsesq has quit [Read error: Connection reset by peer]
booly-yam-4227 has joined #jruby
mkristian has quit [Quit: bye]
booly-yam-4227 has quit [Remote host closed the connection]