jmalves_ has quit [Remote host closed the connection]
jmalves has joined #jruby
<ChrisBr>
lopex: so we use the lower bit of the hash to calculate the bin index! If two hashes collide with the same bin index we need to call eql even if the hash is completely different as we do not store the hash anymore
<ChrisBr>
before we stored the hash and it was done like: bin collision -> hash collision -> eql?
<ChrisBr>
now it is: bin collision -> eql?
<ChrisBr>
so we currently skip the comparision of the hash
<ChrisBr>
e.g 8 and 16 would be in bin 0 but have different hashes, in this case we call now eql?
<ChrisBr>
before we first checked 8 == 16 and skipped the eql? check in this case
<ChrisBr>
does this answer your question?
<ChrisBr>
so my PR restores the algorithm to store the hash value and first compare the hash values before doing eql?
shellac has joined #jruby
jmalves_ has joined #jruby
jmalves has quit [Ping timeout: 244 seconds]
hipertracker has joined #jruby
hipertracker has quit [Client Quit]
hipertracker_ has joined #jruby
hipertracker_ is now known as hipertracker
hipertracker has quit [Client Quit]
hipertracker has joined #jruby
hipertracker has left #jruby [#jruby]
shellac has quit [Ping timeout: 252 seconds]
shellac has joined #jruby
shellac has quit [Ping timeout: 264 seconds]
kares has joined #jruby
jmalves_ has quit [Remote host closed the connection]
lanceball has joined #jruby
Crocket has joined #jruby
jmalves has joined #jruby
jmalves has quit [Remote host closed the connection]
<kares>
ChrisBr: definitely, always looking forward to meeting JRuby-ists :)
Eiam has quit [Ping timeout: 260 seconds]
Crocket has quit [Quit: Leaving]
Eiam has joined #jruby
xardion has quit [Remote host closed the connection]
xardion has joined #jruby
jmalves has joined #jruby
jmalves has quit []
Puffball has quit [Read error: Connection reset by peer]
Puffball has joined #jruby
Puffball has quit [Remote host closed the connection]
Puffball has joined #jruby
Puffball is now known as jaszhix
jaszhix has quit [Remote host closed the connection]