lispyone has quit [Read error: Connection reset by peer]
banjiewen has quit [Ping timeout: 258 seconds]
asedeno has quit [Read error: Connection reset by peer]
tfb has quit [Ping timeout: 252 seconds]
kilimanjaro has quit [Ping timeout: 257 seconds]
l1x has quit [Ping timeout: 240 seconds]
banjiewen has joined #lisp
asedeno has joined #lisp
tfb has joined #lisp
kilimanjaro has joined #lisp
lispyone has joined #lisp
v88m has quit [Read error: Connection reset by peer]
v88m has joined #lisp
l1x has joined #lisp
Achylles has joined #lisp
lumm has quit [Read error: Connection reset by peer]
lumm has joined #lisp
amerlyq has joined #lisp
izabera has left #lisp ["WeeChat 1.9.1"]
<p_l>
bizarrefish... hmmm
<p_l>
ah, I see izabera left
<p_l>
I seemed to recall that nick, might have known the person and could have asked ^^;
ludston has joined #lisp
Folkol has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
milanj has quit [Quit: This computer has gone to sleep]
ebrasca has joined #lisp
orivej has joined #lisp
Bike has joined #lisp
rwlisp has joined #lisp
Inline has joined #lisp
lucasb has joined #lisp
jerme_ has joined #lisp
Folkol has joined #lisp
pfdietz has joined #lisp
defaultxr has joined #lisp
milanj has joined #lisp
lumm has quit [Ping timeout: 258 seconds]
lumm has joined #lisp
varjag has quit [Quit: ERC (IRC client for Emacs 25.2.2)]
dddddd has joined #lisp
lumm has quit [Read error: Connection reset by peer]
lumm has joined #lisp
lumm_ has joined #lisp
lumm has quit [Ping timeout: 268 seconds]
lumm_ is now known as lumm
agspathis has joined #lisp
lumm has quit [Quit: lumm]
lumm has joined #lisp
Achylles has quit [Remote host closed the connection]
manualcrank has joined #lisp
Achylles has joined #lisp
gbiesiad has joined #lisp
dale_ has joined #lisp
dale_ is now known as dale
cosimone has joined #lisp
lnostdal has joined #lisp
LiamH has joined #lisp
<moldybits>
this was surprising: (equal #(-3 1) (vector -3 1)) ; => NIL
<moldybits>
i had forgotten about equalp because i hadn't run into this yet
<pjb>
indeed. and the donwside of equalp is that: (equalp #(-3 1 "Hello") (vector -3 1 "HELLO")) #| --> t |#
<pjb>
So you may have to write your own (defun vec-equal (a b) (and (= (length a) (length b)) (every (function equal) a b))) (vec-equal #(-3 1 "Hello") (vector -3 1 "HELLO")) #| --> nil |# (vec-equal #(-3 1 "Hello") (vector -3 1 "Hello")) #| --> t |#
v88m has quit [Remote host closed the connection]
ebrasca has quit [Remote host closed the connection]
lnostdal has quit [Remote host closed the connection]
cosimone has quit [Quit: WeeChat 2.3]
cosimone has joined #lisp
Mayoi is now known as erkin
v88m has joined #lisp
Achylles has quit [Read error: Connection reset by peer]
warweasle has joined #lisp
rumbler31 has joined #lisp
khisanth_ has quit [Ping timeout: 244 seconds]
v88m has quit [Quit: Quit]
v88m has joined #lisp
rumbler31 has quit [Ping timeout: 246 seconds]
rippa has joined #lisp
mindCrime has joined #lisp
khisanth_ has joined #lisp
gbiesiad has quit [Quit: gbiesiad]
rumbler31 has joined #lisp
rumbler31 has quit [Ping timeout: 268 seconds]
linack has joined #lisp
Folkol has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
rumbler31 has joined #lisp
v88m has quit [Ping timeout: 245 seconds]
gbiesiad has joined #lisp
nimiux_ has joined #lisp
flazh has quit [Read error: Connection reset by peer]
nimiux_ has left #lisp [#lisp]
lavaflow has quit [Read error: Connection reset by peer]
sjl has joined #lisp
q3d has quit [Ping timeout: 256 seconds]
Jesin has quit [Quit: Leaving]
X-Scale has quit [Ping timeout: 245 seconds]
sjl has quit [Ping timeout: 250 seconds]
X-Scale has joined #lisp
keep_learning_M has quit [Quit: This computer has gone to sleep]
jprajzne_ has quit [Quit: jprajzne_]
hhdave has quit [Ping timeout: 246 seconds]
fivo has quit [Quit: WeeChat 1.9.1]
Jesin has joined #lisp
sjl has joined #lisp
karlosz has joined #lisp
linack has quit [Quit: linack]
gbiesiad has quit [Quit: gbiesiad]
agspathis has quit [Remote host closed the connection]
Achylles has joined #lisp
karlosz has quit [Quit: karlosz]
gbiesiad has joined #lisp
lavaflow has joined #lisp
cdegroot has quit [Read error: Connection reset by peer]
MichaelRaskin has joined #lisp
wigust- has quit [Remote host closed the connection]
wigust has joined #lisp
jsjolen has joined #lisp
biopandemic has joined #lisp
karlosz has joined #lisp
warweasle has quit [Quit: later]
ludston has quit [Ping timeout: 246 seconds]
l1x has quit []
l1x has joined #lisp
sauvin has quit [Read error: Connection reset by peer]
biopandemic has quit [Quit: biopandemic]
jsjolen has quit [Remote host closed the connection]
gbiesiad has quit [Quit: gbiesiad]
gbiesiad has joined #lisp
scymtym has quit [Ping timeout: 240 seconds]
lumm has quit [Ping timeout: 276 seconds]
random-nick has quit [Ping timeout: 276 seconds]
karlosz has quit [Quit: karlosz]
karlosz has joined #lisp
igemnace has joined #lisp
cosimone has quit [Quit: WeeChat 2.3]
cosimone has joined #lisp
cosimone has quit [Client Quit]
pankajgodbole has quit [Ping timeout: 250 seconds]
fe[nl]ix has quit [Ping timeout: 259 seconds]
Blkt has quit [Ping timeout: 259 seconds]
gbiesiad has quit [Quit: gbiesiad]
beach has quit [Disconnected by services]
beach has joined #lisp
gbiesiad has joined #lisp
Blkt has joined #lisp
fe[nl]ix has joined #lisp
random-nick has joined #lisp
milanj has quit [Quit: This computer has gone to sleep]
defunkydrummer has quit [Remote host closed the connection]
fiveop has joined #lisp
shifty has joined #lisp
amerlyq has quit [Quit: amerlyq]
cyberoctopi has joined #lisp
Bike has quit []
cyberoctopi has quit [Ping timeout: 245 seconds]
gravicappa has quit [Ping timeout: 246 seconds]
<shka_>
phoe: ok, just added one more comment that sums up my impression of this code
lumm has quit [Quit: lumm]
<shka_>
it smells funny to me, and although it is not objectively speaking bad, i simply think that it is convoluted
<shka_>
and not well structured
<shka_>
sorry that i can't help more
lumm has joined #lisp
nowhere_man has quit [Ping timeout: 246 seconds]
lumm has quit [Ping timeout: 258 seconds]
rwlisp has quit [Remote host closed the connection]
rwlisp has joined #lisp
<phoe>
shka_: no problem
<phoe>
I think it's an iteration above what was before, but you make some good points
rwlisp has quit [Client Quit]
<phoe>
I just don't think my algorithmic skills are good enough to implement your final point
<sjl>
Writing code that works, doesn't cons excessively, and is backwards compatible with the existing behaviour is not as easy as it seems when you first see it.
<phoe>
and also has good style
<phoe>
oh damn
<phoe>
sjl: you made me remember the test suite of SPLIT-SEQUENCE
<phoe>
backwards compatibility with what the original code did caused my code to become the ugly monstrosity that it was
argo has joined #lisp
<phoe>
and, honestly, I invite anyone who's up for it to write better code that still conforms to the split-sequence test suite - it's a challenge
<fe[nl]ix>
at least we have an extensive test suite :)
<sjl>
e.g. you have to stop *exactly* where the original does, because the original returns the number of elements it processed as a separate value
<shka_>
phoe: i didn't track the split sequence, but i can see how something conceptually simple can devolve into monstrosity
<phoe>
fe[nl]ix: this is the first time I wrote a random fuzzer test
<sjl>
the interaction between start/end, count, and remove-empty-subseqs is... nontrivial to get exactly the same as the original.
<shka_>
that's why i'm always for well structured code even for simple stuff
<shka_>
phoe: well, it is, extra arguments makes it more complicated
gbiesiad has joined #lisp
<phoe>
shka_: in other words: yes, you are correct, if we didn't need to conform to the original API and test suite, we'd gladly have made this code much nicer
rippa has quit [Quit: {#`%${%&`+'${`%&NO CARRIER]
<sjl>
(and didn't care about performance)
<sjl>
(though performance was the entire reason phoe rewrote this in the first place, so really if we didn't care about performance we'd still have the original...)
<phoe>
oh right, the original split-sequence was quadratic on lists
lumm has joined #lisp
<shka_>
sjl: i am simply recommending restructuring this a little bit further
<shka_>
it is really not that far from the ideal
<sjl>
shka_: feel free to PR it. If you can come up with something that performs as well and is clearer, I'm sure phoe would be willing to merge it
<shka_>
well, not gonna happen
<phoe>
s/phoe/fe[nl]ix/
<shka_>
i will be AFK for a week
<phoe>
I don't have merge rights
vlatkoB has quit [Remote host closed the connection]
scymtym has joined #lisp
oni-on-ion has joined #lisp
angavrilov has quit [Remote host closed the connection]