sb0 changed the topic of #m-labs to: https://m-labs.hk :: Logs http://irclog.whitequark.org/m-labs :: Due to spam bots, only registered users can talk. See: https://freenode.net/kb/answer/registration
<GitHub161> [smoltcp] jhwgh1968 opened pull request #266: [WIP] Minimal Implementation of TCP Selective Acknowledgement (master...selective-ack-phase-1) https://github.com/m-labs/smoltcp/pull/266
_whitelogger has joined #m-labs
rohitksingh_work has joined #m-labs
sb0 has joined #m-labs
<sb0> zoobab: hi
sb0 has quit [Quit: Leaving]
_whitelogger has joined #m-labs
_whitelogger has joined #m-labs
m4ssi has joined #m-labs
<rjo> sb0: suservo has an rtio address that's wider than 8 bit. but the data is 24 bit iirc, i.e. you can move address bits into the data word.
sb0 has joined #m-labs
<sb0> rjo: I had based this on your comment https://github.com/m-labs/artiq/issues/636#issuecomment-377254243 - is it still accurate or do you foresee more issues with 8bit addresses?
<GitHub-m-labs> [migen] whitequark pushed 1 new commit to master: https://github.com/m-labs/migen/commit/28a5f32448ecf675d85ec137ddde619321a4eab9
<GitHub-m-labs> migen/master 28a5f32 whitequark: genlib/fsm: add basic FSM tests.
<bb-m-labs> build #333 of migen is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/migen/builds/333
<rjo> sb0: i don't foresee any. but please don't take that to mean that you don't have to look at the code.
<GitHub-m-labs> [migen] enjoy-digital pushed 10 new commits to master: https://github.com/m-labs/migen/compare/28a5f32448ec...e7c9ab0ba156
<GitHub-m-labs> migen/master 1fdf5db Florent Kermarrec: lattice/diamond: use build_name as top name
<GitHub-m-labs> migen/master 48023fa Florent Kermarrec: lattice: fix Misc constraints
<GitHub-m-labs> migen/master 2dc085d Florent Kermarrec: lattice/common: no need to differentiate nbits==1 and nbits > 1
<bb-m-labs> build #334 of migen is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/migen/builds/334
<sb0> okay the weird unittest breakage is due to the removal of the now save/restore mechanism in 8caea0e6d3a91e625f84172e455229920dca930f
<GitHub-m-labs> [migen] enjoy-digital pushed 1 new commit to master: https://github.com/m-labs/migen/commit/319d3cdc90f90aaaee859d544ea422a779ef25da
<GitHub-m-labs> migen/master 319d3cd Florent Kermarrec: build: use default toolchain_path on all backends when toolchain_path passed value is None
<bb-m-labs> build #335 of migen is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/migen/builds/335
<GitHub-m-labs> [artiq] sbourdeauducq pushed 1 new commit to new: https://github.com/m-labs/artiq/commit/59033d258881d5667fbff85e027501274e9ab647
<GitHub-m-labs> artiq/new 59033d2 Sebastien Bourdeauducq: firmware: workaround for RPC failures
<sb0> bb-m-labs: force build --branch=new artiq
<bb-m-labs> build forced [ETA 1h05m36s]
<bb-m-labs> I'll give a shout when the build finishes
<sb0> whitequark: could it be another bug with this double-mailbox async RPC mechanism?
<whitequark> sb0: that seems unlikely
<whitequark> how would it interact?
<sb0> this bug is unexpected, so i don't know. something is wrong somewhere.
<sb0> and it seems to be triggered by RPCs
<whitequark> hm
<sb0> and it is hidden by messing with the mailbox in the same way that the now save/restore mechanism does
<whitequark> ok, I see
<whitequark> this line of thinking makes sense to me
<whitequark> not sure what the bug is though, I've spent quite a while on the async RPC mechanism...
<whitequark> what if you disable async RPCs?
<bb-m-labs> build #2013 of artiq-board is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-board/builds/2013
sb0 has quit [Quit: Leaving]
rohitksingh_work has quit [Read error: Connection reset by peer]
<bb-m-labs> build #2014 of artiq-board is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-board/builds/2014
<bb-m-labs> build #2683 of artiq is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq/builds/2683
d_n|a_ has joined #m-labs
d_n|a__ has joined #m-labs
d_n|a has quit [Ping timeout: 246 seconds]
d_n|a_ has quit [Ping timeout: 246 seconds]
sb0 has joined #m-labs
<sb0> rjo: what to move into the data? profile?
<sb0> rjo: that would still limit channel to 3
rohitksingh has joined #m-labs
<rjo> or profile (5 bits) and the three coefficient selection bits
<sb0> minimized workaround > https://hastebin.com/ovelucofud.php
<sb0> whitequark: what is the purpose of LAST in mailbox.rs?
<whitequark> sb0: you wrote that code, actually
<whitequark> I mean, the C code was the same
<whitequark> sec
<sb0> hm, really?
<whitequark> yes.
<whitequark> and it took me a while to understand how it works.
<whitequark> I then tried to remove LAST but it was very persistent, so I kept it.
<whitequark> I think the idea is to make it work as half-duplex.
<whitequark> so, you send something, if you read back the same thing, it means there's no reply or ack.
<sb0> ah, right
<sb0> ffs this bug makes no sense at all
<sb0> workarounds:
<sb0> either uncomment core_log or https://hastebin.com/okaxewapuj.diff
<sb0> symptom: prints None
<sb0> whitequark: any ideas?
<sb0> flushing the dcache or calling kern_acknowledge in session.rs kern::RunFinished has no effect
<whitequark> hm
<whitequark> can you give me lock?
<sb0> whitequark: done
<sb0> or use the kc705
<whitequark> with core_log: https://hastebin.com/ilocoleqeq.css
<whitequark> without core_log: https://hastebin.com/obivuwumiv.css
<whitequark> definitely async RPC related
<whitequark> it's a race I think
<whitequark> let me see if I can fix it
<whitequark> sb0: are you building a branch?
<sb0> whitequark: "new" branch
<sb0> so what is happening? the kernel dies before the async rpc completes?
<whitequark> it's a TOCTTOU
<whitequark> actually, not quite
<whitequark> it's more of an ordering issue
<whitequark> fixed
<GitHub-m-labs> [artiq] whitequark pushed 1 new commit to new: https://github.com/m-labs/artiq/commit/0edae64afb69a8fbf3ed7e04e6f6ad68abc527ce
<GitHub-m-labs> artiq/new 0edae64 whitequark: firmware: fix TOCTTOU race in sync/async RPC code....
<whitequark> hm, now that I think about it, there is *another* race condition there, much more subtle
<whitequark> and the easiest way to fix it is just to have a dummy request that flushes the async RPC queue
<sb0> is it difficult to have only 1 mailbox for everything?
<GitHub-m-labs> [artiq] whitequark pushed 2 new commits to new: https://github.com/m-labs/artiq/compare/0edae64afb69...dd829afebd76
<GitHub-m-labs> artiq/new 583bba8 whitequark: Revert "firmware: workaround for RPC failures"...
<GitHub-m-labs> artiq/new dd829af whitequark: firmware: fix another TOCTTOU race in sync/async RPC code.
<whitequark> I recall there being some issue with it, but it's been a while
mauz555 has joined #m-labs
<sb0> bb-m-labs: force build --branch=new artiq
<bb-m-labs> build forced [ETA 1h04m21s]
<bb-m-labs> I'll give a shout when the build finishes
<sb0> whitequark: still using the board?
<whitequark> sorry, no
<whitequark> released
<GitHub-m-labs> [artiq] sbourdeauducq pushed 2 new commits to master: https://github.com/m-labs/artiq/compare/a4997c56cfe8...248c1cf7dce1
<GitHub-m-labs> artiq/master 68aad3e whitequark: firmware: fix TOCTTOU race in sync/async RPC code....
<GitHub-m-labs> artiq/master 248c1cf whitequark: firmware: fix another TOCTTOU race in sync/async RPC code.
<sb0> whitequark: thanks
<GitHub-m-labs> [artiq] sbourdeauducq pushed 2 new commits to release-3: https://github.com/m-labs/artiq/compare/ad07274a1b8b...dbd1cb9e041d
<GitHub-m-labs> artiq/release-3 ae88c13 whitequark: firmware: fix TOCTTOU race in sync/async RPC code....
<GitHub-m-labs> artiq/release-3 dbd1cb9 whitequark: firmware: fix another TOCTTOU race in sync/async RPC code.
m4ssi has quit [Quit: Leaving]
<bb-m-labs> build #2015 of artiq-board is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-board/builds/2015
<bb-m-labs> build #2016 of artiq-board is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-board/builds/2016
<bb-m-labs> build #2684 of artiq is complete: Exception [exception python_unittest_2 board_unlock_1] Build details are at http://buildbot.m-labs.hk/builders/artiq/builds/2684
mauz555 has quit [Remote host closed the connection]
<bb-m-labs> build #2017 of artiq-board is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-board/builds/2017
<bb-m-labs> build #2018 of artiq-board is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-board/builds/2018
mauz555 has joined #m-labs
rohitksingh has quit [Ping timeout: 246 seconds]
<bb-m-labs> build #2685 of artiq is complete: Exception [exception python_unittest_2 board_unlock_1] Build details are at http://buildbot.m-labs.hk/builders/artiq/builds/2685 blamelist: whitequark <whitequark@whitequark.org>
mauz555 has quit [Remote host closed the connection]
<bb-m-labs> build #2019 of artiq-board is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-board/builds/2019
<bb-m-labs> build #951 of artiq-win64-test is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-win64-test/builds/951
<bb-m-labs> build #2686 of artiq is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq/builds/2686
cr1901_modern has quit [Ping timeout: 246 seconds]
mauz555 has joined #m-labs
mauz555 has quit [Read error: Connection reset by peer]
cr1901_modern has joined #m-labs
mauz555 has joined #m-labs
mauz555 has quit [Read error: Connection reset by peer]