<jfredett>
I'm hooked on mutant testing now. Nothing more satisfying then wrangling the last remaining mutant to the ground.
jfredett has quit [Quit: Leaving.]
jfredett has joined #rom-rb
NemesisD has joined #rom-rb
<NemesisD>
anyone around?
NemesisD has quit [Quit: zzz]
mbj has joined #rom-rb
skade has joined #rom-rb
lgierth has joined #rom-rb
postmodern has quit [Quit: Leaving]
jfredett has quit [Quit: Leaving.]
robertjpayne has joined #rom-rb
snusnu has joined #rom-rb
jfredett has joined #rom-rb
jfredett has quit [Quit: Leaving.]
jfredett has joined #rom-rb
cored has joined #rom-rb
cored has joined #rom-rb
robertjpayne has quit [Remote host closed the connection]
jfredett has quit [Ping timeout: 260 seconds]
breakingthings has joined #rom-rb
jfredett has joined #rom-rb
snusnu has quit [Quit: Leaving.]
<lgierth>
mbj: one more question, working on that resbody mutator. i can't test this kind of node in isolation since it needs to be a child of a rescue node, otherwise the parser blows up. so in the specs i'm defining complete begin/rescue/end lines for :source and :mutations. i'm afraid i'll duplicate lots of mutation expectations that actually belong to the rescue mutator
<lgierth>
so i thought i'd just put those specs into rescue/mutation_spec.rb right away, as a resbody can only exist with a rescue node
jfredett has quit [Ping timeout: 260 seconds]
<mbj>
lgierth, I'm busy with commercial stuff. Can you open a question issue on GH, or comment something, so I dont forget?
<lgierth>
yup will do
<mbj>
lgierth: thx, gonna close IRC ;)
mbj has quit [Quit: leaving]
bf4 has quit [Ping timeout: 248 seconds]
zekefast has joined #rom-rb
gildo has joined #rom-rb
mbj has joined #rom-rb
mbj has quit [Client Quit]
cored has quit [Ping timeout: 260 seconds]
cored has joined #rom-rb
bf4 has joined #rom-rb
jfredett has joined #rom-rb
snusnu has joined #rom-rb
robertjpayne has joined #rom-rb
zekefast has quit [Quit: Leaving.]
zekefast has joined #rom-rb
skade has quit [Quit: Computer has gone to sleep.]
gildo has quit [Ping timeout: 261 seconds]
gildo has joined #rom-rb
dkubb has joined #rom-rb
<dkubb>
good morning
<jfredett>
mornin'
misfo has joined #rom-rb
zekefast has quit [Quit: Leaving.]
robertjpayne has quit [Remote host closed the connection]
<dkubb>
which basically makes it so everything in the RSpec namespace is skipped
<misfo>
gotcha. I'll take a look at why the NoFreeze stuff isn't preventing singleton classes from being frozen
<misfo>
i'll create a github issue for it and take a look later
<misfo>
thanks again for adamantium/ice_nine. i'm really liking having a part of our codebase be entirely stateless
<dkubb>
awesome, good to hear
<dkubb>
that was actually an extraction from axiom too
mbj has joined #rom-rb
<mbj>
hola
mbj has quit [Client Quit]
<dkubb>
when we write stuff that doesn't quite fit in with the library, the first step is that it goes in the lib/{gem}/support directory. then it gets used and refined over a bit of time
<dkubb>
the plan is generally anything in support directories will eventually be extracted
<misfo>
yeah, i like that a lot. I played around with Clojure for a bit and there are a *ton* of tiny libraries. you didn't used to see that much in the Ruby community so it's nice to see
<misfo>
@mbj hi. i finally took your advice and showed up to chat before heading to github
<misfo>
haha
<dkubb>
it seems like a few years ago everyone was following the trend of rails, where you have really big libraries with lots of moving pieces and lots of edge cases, but I think we're starting to see smaller libs that do one thing well
<dkubb>
we even did it too with extlib
<dkubb>
which was kind of like an activesupport alternative. it wasn't bad, but it was still way too big
<misfo>
that less monkey-patching base class trend kinda follows the trend in javascript. everyone loved prototype.js for a time, but then moved away from modifying prototypes of built-ins
<dkubb>
yeah, it's such a common trend that it's probably required for most dynamic languages to go through.. monkey patching has such a low barrier to entry it's only natural you start there. when you get some experience maintaining projects for long periods you realize that monkey patches tend to multiply the complexity
<dkubb>
I think ruby is kind of in the post-monkey-patching phase. I'm kind of surprised that refinements were added to ruby 2.0 though. it's something that could've been used 5 years ago, and it's not so useful now
<dkubb>
in fact I'm probably not going to use it myself, and will proabbly actively recommend against it, just because I think it's a bad trend
gildo has quit [Ping timeout: 240 seconds]
<misfo>
couldn't the core extensions in IceNine have their place, though? the extra noise in the code caused by not using them is not insignificant
<dkubb>
you mean the Object#deep_freeze stuff?
<dkubb>
I don't actually ever use that myself ;)
lgierth has quit [Ping timeout: 240 seconds]
<dkubb>
I always use IceNine.deep_freeze.. but even then it's usually inside things like adamantium. about the only time I use it directly is with defining constants with a nested data structure
<jfredett>
dkubb: I think it's not so much post-monkey patch, it's just that people put it low on the list of 'ways to solve a problem' — I have a few projects with patches in them, but they're very limited in scope, and are really just mimicing, eg, extension methods from C#
<cored>
snusnu: I started the move, need to finish some assertions on the extractions and then, I'll make the pull request
<cored>
for you to review
<snusnu>
cored: awesome!
skade has joined #rom-rb
misfo has quit [Ping timeout: 250 seconds]
bf4 has quit [Ping timeout: 252 seconds]
snusnu has quit [Quit: Leaving.]
cored has quit [Ping timeout: 260 seconds]
cored has joined #rom-rb
snusnu has joined #rom-rb
misfo has joined #rom-rb
NemesisD has joined #rom-rb
<NemesisD>
quick question: should people not use datamapper anymore?
<NemesisD>
i've got a simple product that is using virtus to model ebay products. i'd like a way to map those into an sqlite database, preferably without polluting the virtus model with persistence stufff. rom-rb is obviously a perfect fit but doesn't support sqlite yet
<NemesisD>
or should i just mixin datamapper::resource or whatever and call it a day
bf4 has joined #rom-rb
<snusnu>
cored: btw, i don't wanna rush you or anything, but imo it's really ok to open PRs *very* early .. this doesn't only go for that specific PR you are working on now, but in general
<cored>
snusnu: oh ok, I follow same suggestion from dkubb but I spend a lot of time with an open PR without anything moving forward
<cored>
snusnu: but at the moment the specs are failing
mbj has quit [Ping timeout: 260 seconds]
misfo has quit [Ping timeout: 250 seconds]
mbj has joined #rom-rb
gildo has quit [Read error: Connection reset by peer]
zekefast has joined #rom-rb
martxel has quit [Ping timeout: 245 seconds]
zekefast has quit [Ping timeout: 256 seconds]
knowtheory has quit [Quit: Computer has gone to sleep]
gildo has joined #rom-rb
martxel has joined #rom-rb
martxel has joined #rom-rb
martxel has quit [Changing host]
cored has quit [Ping timeout: 268 seconds]
cored has joined #rom-rb
cored has joined #rom-rb
knowtheory has joined #rom-rb
cored has quit [Ping timeout: 260 seconds]
cored has joined #rom-rb
knowtheory has quit [Quit: Computer has gone to sleep]
postmodern has joined #rom-rb
cored has quit [Ping timeout: 246 seconds]
jfredett has quit [Quit: Leaving.]
breakingthings has quit []
knowtheory has joined #rom-rb
jfredett has joined #rom-rb
gildo has quit [Ping timeout: 245 seconds]
jfredett has quit [Ping timeout: 260 seconds]
dkubb has joined #rom-rb
<mbj>
dkubb: hola
gildo has joined #rom-rb
jfredett has joined #rom-rb
<dkubb>
mbj: hello
<dkubb>
mbj: so yeah, my thinking on twitter was that we should just close issues and prs with no activity in a certain amount of time
<dkubb>
and send a 1 week reminder beforehand
cored has joined #rom-rb
<dkubb>
the closure message could be canned, and include something like "this is being closed due to inactivity, not because it has no merit. if this is a PR, before reopening please make sure it is rebased against master and passes with rake spec or rake ci. if this is a bug report and there is no reproduction, please make sure there is one before reopening"
<dkubb>
"if this is a bug with an existing reproduction, please reopen with a link to a PR resolving the issue"
<dkubb>
I hate to do it, but everyone's time is limited. a cluttered issue tracker is worse than none at all
<dkubb>
if it's important someoen will pick it up and work on it. if it's not important then it will languish compared to other things
gildo has quit [Read error: Connection reset by peer]
<dkubb>
my thinking is that if it's important it will keep bubbling to the surface over and over
jfredett has quit [Ping timeout: 264 seconds]
<postmodern>
dkubb, i would also tag the issues as "old"
<dkubb>
that's a good idea too
<dkubb>
it's also not like i'm deleting the issues or anything.. they still would show up via search, which peolpe should be checking before reporting anyway
<dkubb>
at work we have an issue tracker that has stuff in it we'll never get to within a year. I questioned why we even track it. if it's so important, it'll keep coming up anyway.. and if it's not, then we're better off having an issue tracker with important stuff in it
jfredett has joined #rom-rb
<mbj>
dkubb: sounds god.
<mbj>
dkubb: *good
jfredett has quit [Quit: Leaving.]
<dkubb>
mbj: depending on time I may work on something like that using the GH api. not sure yet
<mbj>
dkubb: dont invest too much time now.
<mbj>
dkubb: But if its fast, why not.
knowtheory has quit [Read error: Connection reset by peer]
knowtheo1y has joined #rom-rb
<dkubb>
yeah it depends on if I do it for work too
<dkubb>
I don't think they're quite at the point where it needs to be automated, but I could use it across a bunch of oss repos
<mbj>
dkubb: nice, I like to reuse stuff from work for OSS and vice versa.
<mbj>
dkubb: my current project does not allow me to do this. Ses what happened to my GH contribution graph :(
<dkubb>
yeah, I've been able to make some spree contributions on this project
<dkubb>
I'm not a huge fan of one-off projects unless the project is really interesting. I'd rather extend something oss, and then contribute fixes back to it
<mbj>
dkubb: Yeah.
<mbj>
dkubb: re spree, at the time I was using it for work I was shocked how far AR can be strechted and misused. Than I saw more AR "evil" in other projects.
<mbj>
dkubb: IMHO it must be a huge pain to be a spree core developer.
knowtheo1y has quit [Read error: Connection reset by peer]
knowtheory has joined #rom-rb
knowtheory has quit [Client Quit]
<dkubb>
mbj: it's not that bad. my biggest complaints are lack of foreign keys and lack of validations in the models
<dkubb>
mbj: both of which can be relatively easily fixed, at least to 80-90% of what the ideal would be
<dkubb>
mbj: there are tools like immigrant that can use foreigner to generate foreign key constraints after reflecting them from the models
<dkubb>
I don't know if validations can be inflected too from the db, but you might be able to generate something halfway good, and then refine it manually. it could use the column specifications, as well as the existing data to infer some validations for example
cored has quit [Ping timeout: 264 seconds]
jfredett-w has quit [Read error: Connection reset by peer]