<FromGitter>
<sam0x17> if anyone is looking for a way to do serverless crystal, gcf.cr which provides an API and deploy tool for running crystal in Google Cloud Functions, is ready: https://github.com/sam0x17/gcf.cr
<FromGitter>
<Thellior> @Blacksmoke16 @robacarp I commented on https://github.com/amberframework/granite/pull/249. It's the pull request about test with multiple databases. My question was if i should rewrite the tests so it will only test one database at a time. Maybe it's not really useful now because @Blacksmoke16 added json and yaml support so maybe i have to wait for that. What do you guys think?
<FromGitter>
<Blacksmoke16> hmm
<FromGitter>
<Blacksmoke16> i dont have a strong opinion either way
<FromGitter>
<Blacksmoke16> would more so be better to wait for #257 since that refactors how connections work
<FromGitter>
<Thellior> Ok I will do that
feepbot has quit [Ping timeout: 255 seconds]
feepbot has joined #amber
<FromGitter>
<robacarp> @Thellior I saw your comment and was thinking I’d wait to see who commented.
<FromGitter>
<Thellior> haha ok :)
<FromGitter>
<robacarp> I don’t see much benefit outside of tidying up code which I do like. it would make it harder to test in development, which I don’t like.
<FromGitter>
<robacarp> So I’m kind of divided
<FromGitter>
<robacarp> The tests are so much better than they used to be
<FromGitter>
<Thellior> I just wanted to change the adapter patterns to only test one db instead of each adapter
<FromGitter>
<Blacksmoke16> how would that work?
<FromGitter>
<Blacksmoke16> would there be like 1 spec helper for each and run those 1 a time or?
<FromGitter>
<Thellior> I need to figure it out how it’s going to work
<FromGitter>
<Thellior> Because the issue is that the models are different for each type of adapter
<FromGitter>
<Blacksmoke16> prob not worth it imo?
<FromGitter>
<Thellior> And you can test locally with docker if we are going to rewrite @robacarp
<FromGitter>
<Thellior> Yea I was having thoughts about it as well
<FromGitter>
<Thellior> But now we test different databases and rerun the other fixed versions
<FromGitter>
<Thellior> That’s also weird
<FromGitter>
<Blacksmoke16> cant we just run them all at once? once my PR is done would be able to define additional adapters in `ADAPTERS = ["pg", "mysql", "sqlite"]`
<FromGitter>
<Blacksmoke16> then just register their db url
<FromGitter>
<Blacksmoke16> then could have docker or whatever just spin up diff containers with each version and define the connection to each?
<FromGitter>
<Thellior> We cannot have multiple connections in granite yet right
<FromGitter>
<Blacksmoke16> then in your models would use it like `adapter mysql8` or `adapter mysql5.7`
<FromGitter>
<Blacksmoke16> which tells that model to use the url of the adapter with that name
<FromGitter>
<Thellior> 👍🏻
<robacarp>
@thellior @blacksmoke16 there's a lot of benefit to being able to run the tests with only one database, and doing so across many databases. Parallel CI, better coverage over the databases in the wild, etc. I'm not sure how that dovetails with the multiconnection stuff, but multiple connections is a feature that's asked about about once a month for Granite. Testing workflow is important because tooling is
<robacarp>
important, but I put requested features slightly above it.
<FromGitter>
<Blacksmoke16> yea for sure, deff worth pursuing
<FromGitter>
<Thellior> 👍🏻
wontruefree has joined #amber
hightower3 has quit [Ping timeout: 276 seconds]
hightower3 has joined #amber
marenz_ has joined #amber
marenz has quit [Ping timeout: 276 seconds]
wontruefree has quit [Quit: bye]
wontruefree has joined #amber
wontruefree has quit [Client Quit]
wontruefree has joined #amber
wontruefree has quit [Quit: bye]
wontruefree has joined #amber
wontruefree has quit [Quit: bye]
wontruefree has joined #amber
wontruefree has quit [Quit: bye]
wontruefree has joined #amber
wontruef_ has joined #amber
wontruefree has quit [Ping timeout: 244 seconds]
hightower3 is now known as hightower4
<hightower4>
Hey why is #crystal channel on IRC set to invite only?
hightower4 has left #amber ["Leaving"]
hightower4 has joined #amber
<hightower4>
Actually nvm
wontruef_ has quit [Quit: bye]
wontruefree has joined #amber
wontruefree has quit [Quit: this is not the client you are looking for]