07:30 <rperier_> hi all

08:39 <mmind00> rperier: it seems you forgot Dave Miller

08:40 <mmind00> who will take the patch if applicable

08:41 <rperier> mmind00: it is not required, it will be send directly to patchwork/netdev :)

08:41 <rperier> this is what I did for the previous patches

08:41 <mmind00> rperier: ok then :-)

08:42 <rperier> I discovered that while reading netdev-FAQ.txt on sources/Documentation, it's a really nice tool

08:42 <rperier> s/on/in/

13:26 <rperier> mmind00: do I need to backport recent changes made in the dts ? (to rebase my dts patch on it), I mean it might change something for me ?

13:28 <mmind00> rperier: porting yes, but not back more sideways :-) ... i.e. the dts patches should apply against my dts branch on kernel.org (https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/log/?h=v3.18-next/dts)

13:29 <rperier> oh you have a branch for that, perfect!

13:30 <rperier> I plan to send two patches, one for the dts itself and another one for documentation (documenting arc,rockchip-rk3188 and arc,rockchip-rk3066)

13:31 <rperier> (under Documentation/devicetree/bindings/net/)

13:31 <mmind00> hmm, I don't think that's the right order :-) ... I didn't have time to look at your patch yet, but let me take quick look

13:32 <mmind00> ah ok ... in the patch itself they are named correctly ... you had me worried there ;-)

13:32 <rperier> what I had in mind was: 1. emac_rockchip, 2. emac_dts, 3. emac_doc . I can also put 2)° and 3)° inside the same patch

13:32 <mmind00> but ... normally the binding document is part of the code patch

13:33 <mmind00> i.e. you submit (driver + binding) and (core dts node + board enablement)

13:34 <mmind00> so I'd suggest simply submitting the binding document as reply to your emac driver

13:34 <mmind00> and for the second part to take a look at https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v3.18-next/dts&id=85095bf30f028f6dcb7d8177ab9b00425c11ca58 and https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v3.18-next/dts&id=2c31d9498cb85dcf37806237870e8ccf4dbf84e0

13:34 <mmind00> as inspiration

14:06 <rperier> mmind00: so I would send documentation with the patch for emac_rockchip ? (in the same patch)

14:06 <rperier> s/would/should/

14:07 <mmind00> rperier: the devicetree maintainer requested at one time that the binding should be a separate patch for easier reviewing on their part

14:07 <mmind00> so normally you have two patches, the driver itself and the binding

14:07 <rperier> bindings including, the dts changes and the doc ... ?

14:15 <mmind00> nope ... the binding is only the document in Documentation/devicetree/bindings/...

14:16 <mmind00> as stated above, the actual changes to the dts files are again separate patches, ideally similar to the two commits I linked above

14:17 <mmind00> to elaborate a bit more, the devicetree binding document describes how the component gets described in the devicetree (which properties it has etc)

14:17 <mmind00> the driver then implements this binding

14:17 <mmind00> which is the reason they should of course be submitted together :-)

14:18 <mmind00> the changes to dts files, then simply enable the device for an actual platform according to the described binding

14:19 <mmind00> http://patches.sntech.de/projects/linux-kernel/03_maintainer-tree/rockchip-saradc/

14:39 <rperier> I see

14:43 <rperier> the binding is not written yet, so I will probably send a v4

14:58 <rperier> so I will re-send my patch including the binding : the driver in [PATCH v4 1/2], the binding in [PATCH v4 2/2] (two seperated patches submitted together) , then I will send two patches one for the device core node (in rk3xxx.dtsi and rk3188.dtsi) and a final patch for rk3188-radxarock.dts (the board)

15:00 <rperier> the review process is not easy, but with time, I will improve myself

15:06 <mmind00> yep, that is the plan ... you could also simply send all 4, and Dave and me will then simply grab the ones we need :-)

15:08 <mmind00> and yes, there is some learning curve but as you will have already seen, nobody shouts normally, so don't worry

19:47 <testman> Hello. Anyone here? Could really use some help with Rockchip Batch Tool. I have some problem with installing drivers. Autoinstall says that driver is installed, but Device manager in Windows 8 says that driver is not found.