<rperier>
mmind00: emac_rockchip v5 does not work in emac_rockchip_remove when it is built as module (and when it is unloaded), so i should not get a "reviewed-by" from you
<rperier>
no?
<mmind00>
I think the emac is inocent here
<rperier>
I mean I will send a v6... or I can also send another patch to solve the problem
<mmind00>
from what I see from afar, the cause is the clk_disable_unprepare of the refclk ...
<mmind00>
when this happens, the common clk framework traverses the clock tree upwards and disables all then unused clocks
<mmind00>
which in our 50mhz case is the dpll at the top which provides ram clock too
<rperier>
another problem is arc_emac_remove should be moved before clkc_disable_unprepare :)
<rperier>
it does not make sense to disable the clock and the regulator (powers off the phy) before trying to disconnect from it (call the core) , no ?
<mmind00>
yep that is correct and the generic remove should move before disabling the resources
<rperier>
yes
<rperier>
as the current patch is tagged as "reviewed-by" I will send a fix (separated patch) I think (and reply to the mail to explain to the netdev maintainer)
<rperier>
(as it is logged in patchwork)
GriefNorth has quit [Ping timeout: 264 seconds]
rz2k has joined #linux-rockchip
dlezcano has quit [Ping timeout: 245 seconds]
dlezcano has joined #linux-rockchip
Yao_ has joined #linux-rockchip
Yao has quit [*.net *.split]
ChiaSmurf has quit [*.net *.split]
ferric has joined #linux-rockchip
ferric has quit [Ping timeout: 246 seconds]
ChiaSmurf has joined #linux-rockchip
ferric has joined #linux-rockchip
ferric has quit [Read error: Connection reset by peer]
ferric has joined #linux-rockchip
eebrah|mobile has joined #linux-rockchip
eebrah|mobile has quit [Read error: Connection reset by peer]
ferric has quit [Ping timeout: 252 seconds]
bengal has joined #linux-rockchip
RaYmAn has quit [Ping timeout: 240 seconds]
RaYmAn has joined #linux-rockchip
RaYmAn is now known as Guest73228
ferric has joined #linux-rockchip
<bengal>
mmind00: it seems that when the new emac_driver submitted by rperier tries to disable the SCLK_MAC clock, the dpll gets disabled and the system hangs
<bengal>
this is the clk disable log (sorry for the spam):
<bengal>
[ 16.241119] CLK disable: hclk_emac
<bengal>
[ 16.247929] disable: hclk_emac DONE
<bengal>
[ 16.244528] disable: hclk_emac
<bengal>
[ 16.251761] CLK disable: hclk_peri
<bengal>
[ 16.255159] disable: hclk_peri
<bengal>
[ 16.258557] disable: hclk_peri DONE
<bengal>
[ 16.262389] CLK disable: aclk_peri_pre
<bengal>
[ 16.266155] CLK disable: sclk_macref
<bengal>
[ 16.269738] disable: sclk_macref
<bengal>
[ 16.273310] disable: sclk_macref DONE
<bengal>
[ 16.277314] CLK disable: mac_src
<bengal>
[ 16.280538] disable: mac_src
<bengal>
[ 16.283762] disable: mac_src DONE
<bengal>
[ 16.287420] CLK disable: dpll
<bengal>
[ 16.290384] disable: dpll
<bengal>
[ 16.293348] disable: dpll DONE
<bengal>
[ 16.296745] CLK disable: pll_dpll
<bengal>
[ 16.300056] disable: pll_dpll
<bengal>
[ 16.303368] rockchip_rk3066_pll_disable
<bengal>
and then the board is frozen
<mmind00>
yeah, I guessed as much ... the dpll is the main ram supply too
akaizen has quit [Remote host closed the connection]
akaizen has joined #linux-rockchip
akaizen has quit [Ping timeout: 272 seconds]
dlezcano has quit [Ping timeout: 252 seconds]
dlezcano has joined #linux-rockchip
dlezcano has quit [Remote host closed the connection]
GriefNorth has quit [Ping timeout: 272 seconds]
<rperier>
mmind00: so the limitation is not from my patch directly... but from the clock subsystem framework (if I understood correctly)
<mmind00>
rperier: correct
<mmind00>
there is currently no driver handling the dram at all - thus no user of the ddrphy clock, so the clock-frameworks thinks it can disable the dpll
<rperier>
mhhh yeah makes sense
<mmind00>
I'll submit a patch to extend the critical clocks to the ddrphy :-)
ferric has joined #linux-rockchip
<rperier>
okay cool, so my patch should be accepted with no problem.
benja` is now known as benja
nighty^ has quit [Remote host closed the connection]
bengal has quit [Read error: Connection reset by peer]
benja is now known as benja`
bengal has joined #linux-rockchip
ferric has quit [Ping timeout: 276 seconds]
bengal has quit [Quit: Leaving]
Bludot has joined #linux-rockchip
rz2k has quit []
viric_ has joined #linux-rockchip
cristian_c has joined #linux-rockchip
viric has quit [Ping timeout: 245 seconds]
viric_ is now known as viric
<cristian_c>
Hi
<cristian_c>
I'd like to install a linux distro on a micro-sd card