ashkan has quit [Remote host closed the connection]
ashkan has joined #openwrt-devel
ashkan has quit [Ping timeout: 265 seconds]
ashkan has joined #openwrt-devel
ashkan has quit [Quit: Konversation terminated!]
ashkan_ has joined #openwrt-devel
Grommish has joined #openwrt-devel
goliath has quit [Quit: SIGSEGV]
<Grommish>
The smell, feel, speed of a freshly wiped computer
hbug has joined #openwrt-devel
philipp64 has quit [Quit: philipp64]
hbug___ has quit [Ping timeout: 240 seconds]
Grommish_ has joined #openwrt-devel
Grommish_ has quit [Client Quit]
Grommish_ has joined #openwrt-devel
Grommish has quit [Ping timeout: 260 seconds]
tobleminer-tSYS has quit [Quit: AS4242423214]
tobleminer-tSYS has joined #openwrt-devel
Grommish_ is now known as Grommish
philipp64 has joined #openwrt-devel
philipp64 has quit [Quit: philipp64]
philipp64 has joined #openwrt-devel
cheakoirccloud has joined #openwrt-devel
<cheakoirccloud>
Hello, I've been working on protocol in luci and netifd for about a day. I'm stuck, but let me dump what pain points I've experienced thus far.
<cheakoirccloud>
netifd: Testing the protocol script. I know about `-n`, I assume that's `ash -n`, but this didn't allert to the syntax error in my script. I attempted to call my protocol `bonding-slave`...
<cheakoirccloud>
The fix was to rename to `bonding_slave`, but I only got an error when booting up... Yes, I've been having to reboot.
<cheakoirccloud>
I've asked about user support regarding this on #openwrt and have had no response and I don't think it's an appropriate topic here.
zkrx has quit [Ping timeout: 240 seconds]
<cheakoirccloud>
I'll try and pastebin my current code, but that's steps ahead.
danitool has quit [Quit: Cubum autem in duos cubos, aut quadratoquadratum in duos quadratoquadratos]
<cheakoirccloud>
I was like, ohh shoot, I forgot to update the copyright... Then there wasn't one.
philipp64 has quit [Quit: philipp64]
zkrx has joined #openwrt-devel
guidosarducci has quit [Remote host closed the connection]
guidosarducci has joined #openwrt-devel
<cheakoirccloud>
This may be a question better answered in ##javascript I've noticed that one can't effectively interrogate scopes, like that of `bonding_slave.js`. Is there a way to add the scope to `global` or something to export it, for debugging?
urjaman has quit [Read error: Connection reset by peer]
urjaman has joined #openwrt-devel
philipp64 has joined #openwrt-devel
<cheakoirccloud>
...I mean I know I can add things to `global`, what I'm asking is can I then debug the data in the JS console. Instead of calling `console.log` on everything.
<cheakoirccloud>
I think I'm at my ask, finally, I'm trying to get the interface created with `bonding_slave.js` to show up in the slaves menu of a bridge?
<cheakoirccloud>
AYCS I've implemented `getIfname` and no such luck. Ohh, there is also the issue of netifd not being able to bring up the interface... working on it.
<cheakoirccloud>
The NEXT project I plan to tackle is `brtables` SNAT and DNAT for WiFi devices, some need arp proxy like shinanagains.
philipp64 has quit [Quit: philipp64]
philipp64 has joined #openwrt-devel
<Grommish>
cheakoirccloud: Hang around ifyou can to a catch any replies.. People are coming and going
victhor has quit [Ping timeout: 260 seconds]
ashkan_ is now known as ashkan
opal has quit [Remote host closed the connection]
opal has joined #openwrt-devel
veonik has quit [Ping timeout: 276 seconds]
veonik has joined #openwrt-devel
ashkan has quit [Ping timeout: 240 seconds]
ashkan has joined #openwrt-devel
philipp64 has quit [Quit: philipp64]
valku has quit [Quit: valku]
feriman has joined #openwrt-devel
feriman has quit [Quit: WeeChat 3.1]
<cheakoirccloud>
I'm wondering what `address-external` does? It's the 3rd parameter to `proto_init_update` in netifd.
plntyk has joined #openwrt-devel
ashkan_ has joined #openwrt-devel
ashkan has quit [Ping timeout: 260 seconds]
glyph has quit [Quit: End of line.]
glyph has joined #openwrt-devel
swex has quit [Quit: swex]
swex has joined #openwrt-devel
ashkan_ has quit [Quit: Konversation terminated!]
philipp64 has joined #openwrt-devel
veonik has quit [Quit: Peace out]
veonik has joined #openwrt-devel
black_ant has joined #openwrt-devel
black_ant has joined #openwrt-devel
<rsalvaterra>
Grommish: pong
rmilecki has joined #openwrt-devel
heffer has quit [Quit: heffer]
heffer has joined #openwrt-devel
Ycarus has quit [Ping timeout: 246 seconds]
dedeckeh has joined #openwrt-devel
ivanich has joined #openwrt-devel
Ycarus has joined #openwrt-devel
danitool has joined #openwrt-devel
Borromini has joined #openwrt-devel
_lore_ has quit [Read error: Connection reset by peer]
_lore_ has joined #openwrt-devel
xes_ has joined #openwrt-devel
xes has quit [Ping timeout: 250 seconds]
Borromini has quit [Quit: Lost terminal]
muhaha has joined #openwrt-devel
clayface has joined #openwrt-devel
<xdarklight>
Hauke: I got feedback from jwh with software polling (instead of hardware auto polling) for the RMII PHY on the 7360: that fixes these ports
<Hauke>
xdarklight: do you kown the settings used with the old driver on the 7412?
<Hauke>
xdarklight: maybe we should always configure the mac like phylink suggestes from the SW and use the auto polling only for link up
<Hauke>
xdarklight: for the 7412 it works when flow controll is off, flow controll could also explain the problems occurring after some time. It could be that something is not able to handle pause frames
<Hauke>
xdarklight: shouldn't it be sufficent to set this only in gswip_phylink_mac_link_up ?
<xdarklight>
Hauke: I did it like this for two reasons: 1) gswip_phylink_mac_link_up doesn't have the speed/duplex/etc. arguments on 5.4 and 2) I wanted to have separate functions to make it easier to read anyways. so it'll be easy to change
<Hauke>
xdarklight: I would call gswip_port_set_pause() with tx_pause and rx_pause as seperate parameters
<Hauke>
that should make it easier at least for upstream
<stintel>
I'd like to bump to 1.0.9 too to fix some memory leaks related to a CVE
<rsalvaterra>
Yeah, but not even considering zstd, when it should be the default, if available? Jeez… :/
<rsalvaterra>
I'm going to cook an upstream patch and see if it sticks…
ashkan has quit [Read error: Connection reset by peer]
* rsalvaterra
is still waiting for comments/insults on his jffs2 zstd patch…
samantaz__ has quit [Ping timeout: 246 seconds]
<Hauke>
rsalvaterra: thanks for taking care of this
<rsalvaterra>
Hauke: Don't mention it, just scratching my own itches. ;)
<rsalvaterra>
Even if for some unfathomable reason my patch doesn't stick, It's probably a good idea to integrate it in OpenWrt. It will make the zstd migration easier, in the long run, won't it?
<stintel>
Hauke: thanks - thought that would add the acked-by to all of the patches in the series but apparently not, ok to add it to patch 1-3 and leave it out of the lldpd dependency ?
<xdarklight>
Hauke: I added it in case some weird bootloader sets it. or do you mean it doesn't have to be changed at runtime (only at initialization time)?
<Hauke>
xdarklight: I think we should only set it at initialisation
blb4393 has joined #openwrt-devel
dxld_ has joined #openwrt-devel
Borromini has joined #openwrt-devel
<Hauke>
xdarklight: which bootloader configures isolation mode?
dxld has quit [Ping timeout: 240 seconds]
dxld_ is now known as dxld
danitool has joined #openwrt-devel
Night-Shade has quit [Read error: Connection reset by peer]
<xdarklight>
Hauke: not sure. it was one of the experiments I did with jwh to get it the two RMII ports on the 7360 working
early` has quit [Quit: Leaving]
<Hauke>
xdarklight: I do not know if setting GSWIP_MDIO_PHY is still needed
<Hauke>
when we configure the MAC explicitly
<Hauke>
xdarklight: will you clean the patches up and send them upstream?
blb4393 has quit [Quit: ChatZilla 0.9.93 [Waterfox 56.3/MOZ_BUILDID]]
<xdarklight>
Hauke: ok, I'll unset the isolation bit only in gswip_setup. whether GSWIP_MDIO_PHY is needed or not: I don't know. I can try removing it and let people test again
<xdarklight>
Hauke: do you have any other clean-ups in mind?
samantaz__ is now known as SamantazFox
black_ant has joined #openwrt-devel
black_ant has joined #openwrt-devel
black_ant has quit [Changing host]
dangole has joined #openwrt-devel
illumi has joined #openwrt-devel
<Hauke>
xdarklight: you should shaush some of these patches together
<Hauke>
one patch sets GSWIP_MII_CFG_RATE_AUTO and the next one removes it again
<xdarklight>
Hauke: ah, this I can do
<xdarklight>
Hauke: I already squashed the isolation one with the next one which configures the remaining MII_CFG registers
<Hauke>
setting the mdio_phy register too should be ok
<Hauke>
it does not hurd if it is not needed
<Hauke>
xdarklight: where do I find the most recent version?
<xdarklight>
Hauke: the GSWIP_MII_CFG_RATE_AUTO one is already upstream so I will not squash it. it at least fixed the Gbit/s ports with RGMII PHY on the Fritz 7490 according to some user so I am not asking for a revert of that
<Hauke>
xdarklight: I am not sure if the configuration of the MAC should be done in the gswip_phylink_mac_config() and gswip_phylink_mac_link_up()
<xdarklight>
Hauke: it's also not 100% clear to me so that's why I would send it as RFC. I found different example: some configuring the LINK_UP register in _phylink_mac_link_{up,down} and others are doing it (additionally) in _phylink_mac_config
<Hauke>
xdarklight: you could write GSWIP_MAC_CTRL_0_FCS_EN BIT(7) and same for PADEN
<xdarklight>
Hauke: will change this. in general I think the whole driver could make use of GENMASK and FIELD_PREP() to make the code easier to read
<Hauke>
didn't know FIELD_PREP()
<xdarklight>
I believe that I already converted most of the non-lantiq drivers for which I am responsible by now. but certainly I also started without FIELD_PREP
<Hauke>
xdarklight: the autopoling is disabled for all ports by default so you do not have to manually disable it again
<Hauke>
the change in gswip_setup is not needed
<illumi>
Quick question, trying to get the libcap binaries installed on 19.07 but the -bin package seems to be missing. Is anyone able to push it to https://downloads.openwrt.org/releases/19.07.7/packages/ or is it build it myself situation?
<Hauke>
xdarklight: Is regs->version correct? Is this the version of the HW and not the version of the regs format?
<xdarklight>
Hauke: I can drop disabling the auto-polling mechanism, but I think it's a good idea to be clear it anyways in case any of the bootloaders sets it
<Hauke>
it is unset here: gswip_mdio_w(priv, 0x0, GSWIP_MDIO_MDC_CFG0);
<xdarklight>
oh, I missed that. thanks!
<xdarklight>
I'll remove the newly added code but update the comment above that line with the AR8030 example
black_ant has quit [Ping timeout: 265 seconds]
<Hauke>
ok
<Hauke>
I would combine the "net: dsa: lantiq_gswip: Configure all remaining GSWIP_MII_CFG bits" and the "net: dsa: lantiq_gswip: Don't use PHY auto polling - WiP " commit into one
<Hauke>
at least this split is not so good becasue you revert some changes in the next commit again
<xdarklight>
Hauke: I think you're right for the GSWIP_MII_CFG_RATE_* bits. GSWIP_MII_CFG_RMII_CLK and GSWIP_MII_CFG_RGMII_IBS can be part of a separate patch IMO
<Hauke>
yes, that split is good
<Hauke>
why don't you disbale the link in the setip function any more?
<Hauke>
xdarklight: could you add a comment to GSWIP_MII_CFG_RMII_CLK (the definition or the useage): 1: RMII clock is output
<Hauke>
I haven't found a DSA interface to configure this, so output should be the default option to match RMII specification when it is conencted to only the one PHY
<xdarklight>
Hauke: okay. I think similar to the RGMII RX/TX delay it's probably more phylink specific rather than DSA specific
<Hauke>
xdarklight: ok, but I also haven't seen there any support ;-)
<xdarklight>
:-)
<Hauke>
as I do not have any device which uses it, just set it
<xdarklight>
yep, that's what was tested by jwh on the 7360 also
<xdarklight>
Hauke: RE disabling the link in .setup: I just force pushed - can you please double-check with the latest code? looks good to me
indy has quit [Ping timeout: 265 seconds]
Borromini has quit [Quit: Lost terminal]
<Hauke>
in the reg debug commit: You can also print gswip_switch_r(priv, GSWIP_MAC_PSTATp(port)); for the CPU port
<xdarklight>
done :)
<xdarklight>
DSA doesn't have support for getting stats on the CPU port but I think it's still good to be prepared for whenever that is added
<Hauke>
xdarklight: looks good
<Hauke>
xdarklight: you can add my Acked-by to the first 3 patches
<xdarklight>
Hauke: thanks :)
indy has joined #openwrt-devel
dedeckeh has quit [Quit: Connection closed]
goliath has quit [Quit: SIGSEGV]
Risk64 has joined #openwrt-devel
wigyori has joined #openwrt-devel
wigyori has quit [Changing host]
muhaha94 has joined #openwrt-devel
muhaha94 has quit [Client Quit]
muhaha has quit [Quit: Connection closed]
Tost has quit [Ping timeout: 240 seconds]
ivanich has quit [Quit: Konversation terminated!]
bala has quit [Quit: WeeChat 2.8]
<Hauke>
xdarklight: for the TP-Link vr200v port 1 and port 3 are mixed up in the DSA pull request