<aparcar[m]>
but it fails to apply when using the build system
<rmilecki>
[14:34] <nbd> how about having a 'config bridge' section imply the creation of an implicit proto=none interface with the same name
<rmilecki>
nbd: so that would basically just result in having network.interface.foo, right?
<rmilecki>
(ubus object)
Nick_Lowe has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
<rmilecki>
jow: i agree with nbd that if we create bridge device (which results in Linux bridge interface), there needs to be a way for brinding it up & down using ifup / ifdown (AKA netifd + ubus "up" / "down" methods)
<rmilecki>
jow: so we either need network.interface.foo for layer 2 bridge interface OR something like network.device.foo
dedeckeh has quit [Quit: Connection closed]
<rmilecki>
now, if we add something like network.device.foo and then user adds interface too, then "ubus call network.device.foo up" and "ubus call network.interface.foo" will do basically the same thing I guess
<rmilecki>
oh crap, that layer 2 & layer 3 handling in Linux, netifd, UCI, LuCI is a mess
Nick_Lowe has joined #openwrt-devel
brentmagma has quit [Remote host closed the connection]
brentmagma has joined #openwrt-devel
Nick_Lowe has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
SamantazFox has quit [Read error: Connection reset by peer]
<ldir>
you'll note the following line "strlen(blobmsg_get_string(_tb[SERVICE_INSTANCE])) + 1" has a + 1 and again I'm assuming the idea is to make sure calloc includes space for a string terminator.
<stintel>
but that's not helping to fix the compile warning
<ldir>
now I need to look at strncpy - I suspect my error is that the strncpy should be strlen and perhaps no strlen+1. - can't remember what strncpy does!
<Redfoxmoon>
memcpy or strlcpy, don't use strncpy
<Redfoxmoon>
can always use memcpy and manually null terminate arrays
<ldir>
we need n+1 of space, but only n of the source string. calloc will give as a null terminator already because it inits the alloc memory to nulls for us.
<stintel>
ldir: will you commit that fix :D
<ldir>
oh hell yes - I don't mind my name being dragged through the mud, I'm an idiot :-)
<stintel>
heh :D
<Redfoxmoon>
I think gcc can make just about anyone feel stupid
madwoota has quit [*.net *.split]
<ldir>
I think the compiler is trying to cover the case of 'oh but what if the end character isn't a null' not realising that it must be 'cos strlen must have fallen over a null to give is a string length.
<stintel>
ok next problem: busybox :P
<ldir>
It wasn't me!
<stintel>
oh, fPIC blabla
<stintel>
because PKG_ASLR_PIE:=0
<ldir>
Redfoxmoon: I agree strncpy is a horror show
<Redfoxmoon>
Yep.
<Redfoxmoon>
I understand the original intent behind it, but the implementation is wack
<ldir>
yeah, let's just count the characters and still not really care if we terminate the string correctly
<Redfoxmoon>
:-)
<Redfoxmoon>
at least strlcpy is safe, but it does come w/ the fact that it will truncate
AlexisEvelyn has quit [Ping timeout: 250 seconds]
<Hauke>
stintel: ldir are you working on gcc 10?
<ldir>
you'd have thought that null termination would be implicit - it IS called 'string n copy'
<ldir>
brb - have to collect mrs ldir from the dentist
<stintel>
Hauke: 13|13:26:02 < stintel> I'm switching to binutils 2.36.1 and gcc 10.3.0 on all my builds as I would like to make those the new defaults in master
<Hauke>
stintel: umbim is also not compling with gcc 10
<stintel>
I should probably do full build :)
Ansuel has joined #openwrt-devel
brentmagma has quit [Remote host closed the connection]
madwoota has joined #openwrt-devel
brentmagma has joined #openwrt-devel
<ldir>
stintel: good enough - you can add my acked by
<stintel>
ldir: thanks, I'll push in a few minutes
* ldir
mrs ldir still has relevant teeth :-)
<stintel>
ugghhh fscking IO problem
<stintel>
every time I build OpenWrt when the kernel extracts all IO hangs
<stintel>
seriously fscking annoying
<stintel>
and my box doesn't support NVMe
<stintel>
and PCIe to NVMe cards are hard to find over here
brentmagma has quit [Remote host closed the connection]
Acinonyx has joined #openwrt-devel
<stintel>
maybe I should consider replacing my 8+ y old Intel 520 SSDs
Acinonyx_ has quit [Ping timeout: 246 seconds]
brentmagma has joined #openwrt-devel
<stintel>
although I'd expect the scheduler to avoid this annoyance
brentmagma has quit [Remote host closed the connection]
Acinonyx has quit [Ping timeout: 260 seconds]
Acinonyx has joined #openwrt-devel
rok has joined #openwrt-devel
rok has quit [Client Quit]
brentmagma has joined #openwrt-devel
poljar1 has joined #openwrt-devel
poljar has quit [Ping timeout: 240 seconds]
Borromini has joined #openwrt-devel
brentmagma has quit [Remote host closed the connection]
brentmagma has joined #openwrt-devel
AlexisEvelyn has joined #openwrt-devel
Night-Shade has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
Night-Shade has joined #openwrt-devel
nitroshift has quit [Quit: Gone that way --->]
<rsalvaterra>
ldir: 5.10 is at .36. Are you bumping it, or shall I do it this time? :)
<ldir>
you can check if I've done it right
<rsalvaterra>
Oh, you're already on it, nice! I'll give it a look/spin, for sure.
<zorun>
stintel: is your fs mounted with discard? it's a frequent cause of hangs on some SSDs
_lore_ has quit [Read error: Connection reset by peer]
<stintel>
zorun: it's not, as it's a SATA 3.0 device, queued discard was only added in 3.1
<stintel>
oh wait a minute
<stintel>
that extracts to /home, those aren't my Intel 520s at all
<stintel>
*facepalm*
_lore_ has joined #openwrt-devel
<stintel>
my /home is on btrfs raid1 on samsung qvo, sata 3.2 so discard _shouldn't_ be a problem
<stintel>
but I guess I'll try disabling it to make sure
<rsalvaterra>
ldir: Even better, I'll do it locally too and compare my results to yours.
<zorun>
discard often *is* a problem ;) I mean the mount option, as some SSDs really don't like the way the filesystem issues lots of discards when you delete files
<zorun>
I've seen multi-minutes I/O hangs on a samsung EVO when running big rsyncs with lots of small files
<stintel>
blergh
<zorun>
running fstrim regularly is fine
<stintel>
zorun: thanks for mentioning it. I didn't even consider it because I have it disabled on my rootfs and didn't think about the fact that /home is on different SSDs. it appears it might have been the culprit after all
<stintel>
systemctl enable fstrim.timer # fixed
<Borromini>
hmmm... should i disable discard on btrfs as well then or can that handle it better?
* Borromini
has discard=async set
<stintel>
Borromini: I'm on btrfs so I guess it doesn't ;)
<Borromini>
:D
<Borromini>
thanks
brentmagma has quit [Remote host closed the connection]
brentmagma has joined #openwrt-devel
opa7331 has joined #openwrt-devel
<stintel>
ldir: do you have 5.10.36 bump pushed somewhere ?
<stintel>
as I'm planning to build new images for all my devices, it's the perfect time to test that also
<stintel>
s/planning to build/building/
netprince has joined #openwrt-devel
cheakoirccloud has joined #openwrt-devel
Borromini has quit [Ping timeout: 265 seconds]
brentmagma has quit [Remote host closed the connection]
<stintel>
oh, nvm lol, I'm not using 5.10 yet on most of my devices
<stintel>
lots of brainfarts today
<rsalvaterra>
stintel: Even better, it's the perfect opportunity to test! B)
<stintel>
maybe not while switching from gcc 8 to 10 ;)
<rsalvaterra>
Hm. The mac80211 patches need refreshing, I see.
<rsalvaterra>
stintel: gcc 10, binutils 2.36 and musl 1.2.2 here. The edge doesn't get much more bleeding than this… :P
<Ansuel>
when gcc 11?
<rsalvaterra>
Ansuel: I wouldn't dare to bump it myself… compilers are scary, compiler patches are scarier.
<Ansuel>
just asking if someone have some testing patch, can't remember when gcc 11 was released
<Ansuel>
anyway looking at the patch for 10.3, there are only 18 and are not too big max 4kb... so doesn't look that different than the upstream gcc
<aparcar[m]>
rsalvaterra: ping
<rsalvaterra>
aparcar[m]: pong, what's up?
<aparcar[m]>
rsalvaterra: how to submit patches to busybox
<rsalvaterra>
aparcar[m]: It's the same as the Linux kernel, but you need to be subscribed to the mailing list, iirc.
<aparcar[m]>
ack ty
<rsalvaterra>
np
rsalvate_ has joined #openwrt-devel
rsalvaterra has quit [Ping timeout: 246 seconds]
brentmagma has quit [Remote host closed the connection]
<netprince>
nbd: has anyone reported trouble with unifi 6 lite since https://git.openwrt.org/?p=openwrt/openwrt.git;a=commitdiff;h=06f5e8009d4470d0dc6bba28a8f946ac4448cba2?
<netprince>
I tested a build from the previous commit and its ok
brentmagma has joined #openwrt-devel
_lore_ has quit [Ping timeout: 265 seconds]
<netprince>
on wifi it seems like most packets are just dropped, an occasional ping or two will get through
<nbd>
which wifi chip?
zjason has joined #openwrt-devel
<nbd>
2.4 or 5 ghz?
<netprince>
5 ghz
<nbd>
haven't received any reports
<nbd>
can you git bisect the mt76 driver?
<netprince>
I can try but I dont know how, do you have any pointers?
<stintel>
there is a 0 missing in the substitution
<stintel>
but now figuring out where that sed command comes from in the first place
<stintel>
more autohell voodoo and black magic probably
<ldir>
probably - you seem to understand more about autohell than I do (or ever wish to) :-D
<stintel>
m4
<stintel>
heh I don't understand any of it
<stintel>
I'm just following a trail :P
<ldir>
There are times I wish I'd actually done computer science...or been a proper programmer :-)
Acinonyx has joined #openwrt-devel
<stintel>
I started Harvard CS50x last year but I never managed to finish the week 0 task
<stintel>
had to make something in Scratch
<stintel>
"writing" a program by dragging and dropping stuff in a GUI
<stintel>
absolutely fscking horrible
<stintel>
nice for kids or people with 0 experience
<stintel>
but when inserting some extra logic in the middle of an existing block becomes a problem, I tend to get very agitated
brentmagma has quit [Remote host closed the connection]
Ansuel has joined #openwrt-devel
brentmagma has joined #openwrt-devel
Ansuel_ has quit [Ping timeout: 250 seconds]
<svanheule>
stintel: I thought Scratch was for primary school?
<stintel>
well it's what CS50x starts with
<svanheule>
if it's any consolation, I get paid to "program" in LabView
<svanheule>
quite literally spaghetti code...
J-L has joined #openwrt-devel
Borromini has joined #openwrt-devel
<svanheule>
luckily it can interface with C-libraries, so I can shove logic into real code :P
<rsalvaterra>
stinte: I beg to differ. I find Scratch really nice. :)
<rsalvaterra>
*stintel
<rsalvaterra>
I mean, it's the whole point. It's for people with zero experience.
<stintel>
I know
<rsalvaterra>
And a WAY better way of learning how to code than with (GAH!) BASII
<rsalvaterra>
BASIC
<rsalvaterra>
At least in Scratch you have structure.
<stintel>
well it's just not for me
<rsalvaterra>
And kids really need to see the "code" making things move around the screen.
<ldir>
stintel: I know exactly what you mean - I tried the same thing and fell into the same trap/lack of interest - I had great difficulty relating it to 'proper' programming in a non-gui language.
* rsalvaterra
started with ZX BASIC and isn't proud.
<ldir>
lol - started with zx80 zx basic, then 'progressed' to ZX81 basic. then into some sort of hybrid z80 machine code/assembly by looking up the instruction codes from the back of the zx81 manual and 'assembling' by hand.
<J-L>
Hi, I'm completely new to openwrt. It seems I got lucky that some devices I bought some years ago had prebuilt openwrt support.
<J-L>
Now I have recently bought something new (and cheap). Turns out TP-link put out new hardware versions for most of it's devices since by now. Often downsizing flash and RAM
<J-L>
I did see that device profile was added at some point "tl-wr841n-v14" which is supposed to support that thing. Only it's doesn't "easily" build (haven't been able to replicate online claims to success).
<J-L>
I was just wondering if so explicit on not supporting 32/4, why keep the profiles arround and actively maintain them?
<PaulFertser>
J-L: because people self-building still can use it nicely. It's just to stop caring about extra load and issues with the build bots.
<PaulFertser>
J-L: new default package set can't fit 4 MiB flash anyway, so autobuilding the images is no longer possible. But it would be uncool to just drop all of it.
<PaulFertser>
J-L: the build process should be easy, what didn't work for you?
<J-L>
well, it's been 12 years or something that I've did opensouce cpp builds, so it certainly rusty, with sadly less time to spend on it than I'd like
<J-L>
so I went for trying to build it using a prebuild docker container
<ldir>
rsalvaterra: that's probably why I can still remember 0x01, 0x11, 0x21 as ld [bc/de/hl],nn respectivly - EDB0 is 'ldir', C3nnnn is jump, C9 is Ret, CD is Call
<PaulFertser>
J-L: yes, you should run "make menuconfig" and disable packages you do not need.
<PaulFertser>
J-L: also it's not imagebuilder I had in mind, it's the build system. Imagebuilder doesn't really build the software, it just assembles the image.
AlexisEvelyn has quit [Ping timeout: 276 seconds]
<PaulFertser>
J-L: should be adequate for the purpose, just do not include extra software.
<J-L>
ok, on a next endavour I'll go for using the actual build system
<PaulFertser>
IB should work too.
<PaulFertser>
I guess you're trying to include luci, try without.
<ldir>
rsalvaterra: I'm 50 years old in not many days time. How the hell??!!!!!!
<J-L>
well even a completly stripped version didn't get accepted
Nick_Lowe has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
brentmagma has quit [Remote host closed the connection]
poljar1 has joined #openwrt-devel
brentmagma has joined #openwrt-devel
poljar has quit [Ping timeout: 240 seconds]
Nick_Lowe has joined #openwrt-devel
<aparcar[m]>
lynxis: all right I sent a patch to upstream
dangole has quit [Quit: Leaving]
<stintel>
can anyone explain me what https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=tools/automake/patches/000-relocatable.patch;h=d05b25e61c2e240b5c858fde7f2f13ce622958fc;hb=HEAD#l23 does ?
Ansuel has joined #openwrt-devel
Nick_Lowe has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
SamantazFox has quit [Read error: Connection reset by peer]
SamantazFox has joined #openwrt-devel
Nick_Lowe has joined #openwrt-devel
* stintel
gives up and uses ldir's grub commit
Nick_Lowe has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
Ansuel has quit [Read error: Connection reset by peer]
sbrown has quit [Remote host closed the connection]
sbrown has joined #openwrt-devel
Nick_Lowe has joined #openwrt-devel
sbrown has quit [Remote host closed the connection]
sbrown has joined #openwrt-devel
Ansuel has joined #openwrt-devel
Nick_Lowe has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
Ansuel has quit [Read error: Connection reset by peer]
brentmagma has quit [Remote host closed the connection]
brentmagma has joined #openwrt-devel
Ansuel has joined #openwrt-devel
AlexisEvelyn has quit [Read error: Connection reset by peer]
AlexisEvelyn has joined #openwrt-devel
Nick_Lowe has joined #openwrt-devel
Nick_Lowe has quit [Client Quit]
Nick_Lowe has joined #openwrt-devel
Nick_Lowe has quit [Client Quit]
Nick_Lowe has joined #openwrt-devel
SamantazFox has quit [Ping timeout: 265 seconds]
brentmagma has quit [Remote host closed the connection]
brentmagma has joined #openwrt-devel
lukedashjr has joined #openwrt-devel
luke-jr has quit [Ping timeout: 240 seconds]
Nick_Lowe has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]