Guest74795 has quit [Read error: Connection reset by peer]
voxadam has joined #openwrt-devel
Ycarus has quit [Ping timeout: 245 seconds]
Ycarus has joined #openwrt-devel
Night-Shade has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
feriman has quit [Ping timeout: 252 seconds]
Borromini has quit [Ping timeout: 252 seconds]
<rmilecki>
what the heck
<rmilecki>
build_dir/target-aarch64_cortex-a53_musl/netifd-2021-05-18-7277764b/interface.c:259:3: error: 'fallthrough' undeclared (first use in this function)
<rmilecki>
fallthrough;
<rmilecki>
^~~~~~~~~~~
<rmilecki>
nbd: ??
<nbd>
did you update libubox?
<nbd>
the libubox update that i pushed adds the fallthrough macro
<karlp>
why is that better than the documented comment form?
<rmilecki>
nbd: ah, ok, i was trying to bump netifd locally without your recent ubox change
<karlp>
mentioning the changed requirements in the commit message would hav ebeen nice :)
<nbd>
karlp: clang doesn't accept the comment form
<karlp>
does gcc accept the attribute?
<nbd>
i copied the macro from the kernel
<karlp>
seems rough to me to puyt this in an external dep, but hey, just the peanut gallery....
<nbd>
so it's a form that is accepted by both clang and gcc
<nbd>
what do you mean by 'external dep'? netifd already depends on libubox and uses a lot of utility functions from it
<rmilecki>
nbd: compiles fine, thanks!
<nbd>
karlp: and if you update openwrt without having specific versions of netifd or libubox locked in via git-src, there is no compile error
<karlp>
but you don't have any reference to which libubox is required at any point, there's no submodule, it's just "update all of them and hope they currently sync"
<karlp>
but really, not my playground, sorry for interfering
<nbd>
they're not widely used outside of openwrt
<nbd>
and if you update openwrt, you get them updated in the right order
<nbd>
don't worry about interfering, i just want to understand your concerns
<rmilecki>
karlp: it's the same store when we extend some API in ubox and then use it in another OpenWrt software
<rmilecki>
karlp: that requires bumping in the correct order
<rmilecki>
nothing new here
<rmilecki>
*story
<rmilecki>
can someone try /etc/init.d/network restart
<rmilecki>
can you access your router after that?
<rmilecki>
a simple ping will do
<nbd>
works for me
dedeckeh has quit [Quit: Connection closed]
daregap has joined #openwrt-devel
<rsalvaterra>
blogic: Is it possible to learn this power? :)
<rsalvaterra>
blogic: Oh, nevermind, I just saw your repository now.
Nick_Lowe has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
<rsalvaterra>
aparcar[m]: I'm updating ELFKickers here, but sstrip is unchanged, it seems. Is it worth the bump? It's trivial enough, though…
AlexisEvelyn has quit [Ping timeout: 245 seconds]
AlexisEvelyn has joined #openwrt-devel
<jow>
rmilecki: I guess having "ports" for both is fine
<rmilecki>
jow: ok, th
<rmilecki>
x
<jow>
rmilecki: I also like the ifname->device change
<rmilecki>
cool
<rmilecki>
it also matches bridge-vlan section option
<jow>
rmilecki: as for disabling support for legacy bridge creation in luci... I was considering a forced config migration similar to how it is done for wireless
<jow>
rmilecki: to see what I mean, remove the name from any "config wifi-iface" in your /e/c/wireless and open the wifi config page in luci
<rmilecki>
jow: i pushed that one an hour ago, i decided to wait with the other patch till tomorrow
<jow>
rmilecki: would love to see something like that to migrate type bridge to device bridge
<rmilecki>
let me check in LuCI what do you mean
<jow>
then we can simply drop all legacy code
<rmilecki>
i need a second to switch to some wireless router
<rmilecki>
aparcar[m]: check commit messages in above for examples
decke has quit [Read error: Connection reset by peer]
lipnitsk has joined #openwrt-devel
<rmilecki>
aparcar[m]: so it's basically rename + using "section device" for bridge
nick[m]1 has joined #openwrt-devel
decke has joined #openwrt-devel
<jow>
rmilecki: I don't care about cli users :)
<jow>
I mean not in a sense thatthey need any handholding
<rmilecki>
rmilecki: well, if we do it "my way", it's going to handle CLI usera AND LuCI users
<jow>
I don't want to maintain redundant code paths to let cli users clinge to their deprecated configs
<aparcar[m]>
jow: how big is ucode if you compile it with all regular features?
<rmilecki>
jow: no worries, i'm planning to drop legacy code from netifd afterwars
<jow>
either hey want to use luci, they they'll get force migrated so that they can configure using luci
<rmilecki>
jow: so the only thing we're going to stay with it 1 uci-defaults file
<jow>
or not, in this case the luci network config won't work to not break legacy configs
<rmilecki>
jow: no, let's don't migrate just LuCI users
<rmilecki>
jow: really, that's the benefit from that?
<rmilecki>
let me just "migrate" everyone
olmari has joined #openwrt-devel
<jow>
I was referring to your proposed patch
<aparcar[m]>
rmilecki: thanks for the sources
<rmilecki>
jow: which one? ;)
<jow>
there you disabled the ability to create old style bridges but left the code to configure them in place
<jow>
also uci-defaults is unreliable
<rmilecki>
why is it unrel?
<jow>
factory reset to old configs on self built images, restore from old backups
<jow>
sysupgrade retaining old configs
<jow>
users copy-pasting examples fro mthe web after your migration ran
<rmilecki>
uci-defaults run after sysupgrade
<jow>
scp'ing configs from one device to another
<rmilecki>
restore config -> ok, that will fail
<rmilecki>
jow: i could leave uci-defaults with "exit 1" to hack that around
<rmilecki>
i'm not sure how much you like it
nejon has quit [Read error: Connection reset by peer]
nitroshift has quit [Quit: Gone that way --->]
norris has quit [Ping timeout: 260 seconds]
<rmilecki>
jow: i don't have any good idea for users restoring (restore / scp / whatever) configs using old syntax except having that uci-defaults migration script with "exit 1" so it runs on every boot
whyameye has quit [Ping timeout: 245 seconds]
<jow>
rmilecki: I've no objection against you adding a uci-defaults script
<rmilecki>
jow: ok
<rmilecki>
jow: let me look at it now then
<jow>
the LuCI solution is just another, more reliable mechanism for those that do use luci to edit the config
<rmilecki>
jow: i'm also working on uTutorial on DSA & UCI & LuCI
<rmilecki>
i'll post on forum
<jow>
because for those, the config will be migrated at the very point in time they're trying to change it
<jow>
[in case it isn't already migrated]
<jow>
[for wahtever reason]
whyameye has joined #openwrt-devel
<jow>
the other advantage of the gui approach is that you actually trigger it yourself (by visting the settings page) and thet you initiate the migration explicitely (by pressing proceed)
<jow>
vs. a uci-defaults script that changes a network config without the user consenting
<jow>
also keep in mind that automatic uci operations on a file changes its indentation and that all comments will be stripped
<jow>
to a cli user that is likely a far bigger deal than to a gui one
norris has joined #openwrt-devel
<rmilecki>
can you ever make everyone happy when doing such changes? ;)
<jow>
no, I just explained the reasoning for wanting a ui assisted migration (in addition). Because it allows me to simplify the code there without having to care about whatever core ends up doing
__lore__ is now known as _lore_
<nbd>
i strongly prefer only doing the migration for luci users at the moment (in the way that jow proposed)
<jow>
for core we should start with *shipping* updated defaults, migration can be (re)considered much later
<nbd>
right
<nbd>
there is very little (if any) benefit to early forced migration for cli users
<nbd>
but a non-neglegible risk of breaking working configs
<aparcar[m]>
zorun: please review my AUTORELEASE busybox patch if you have the time :)
<rmilecki>
blah
<rmilecki>
ok, i'll see to LuCI to add similar workaround to wifi-iface one
<aparcar[m]>
openwrt has a cli?
nejon has joined #openwrt-devel
zjason has joined #openwrt-devel
<jow>
aparcar[m]: on x86/64 its ~74K after sstrip & gzip for all modules and the interpreter itself
<jow>
aparcar[m]: it'll likely become smaller when disabling the trace support
<aparcar[m]>
jow: thanks!
svanheule has quit [Quit: No Ping reply in 180 seconds.]
svanheule has joined #openwrt-devel
cheakoirccloud has joined #openwrt-devel
poljar1 has joined #openwrt-devel
poljar has quit [Remote host closed the connection]
Fishman has quit [Remote host closed the connection]
gladiac133779 has quit [Quit: Ping timeout (120 seconds)]
gladiac133779 has joined #openwrt-devel
mattsm has quit [Killed (verne.freenode.net (Nickname regained by services))]
SamantazFox has quit [Remote host closed the connection]
zjason has quit [Remote host closed the connection]
sigtrm has quit [Remote host closed the connection]
sigtrm has joined #openwrt-devel
<aparcar[m]>
rmilecki: thanks for the examples, looks good to me. I'm still missing the big picture why this is terrible difficult to implement into a UI and needs the change but I'm sure it makes sense :)
<aparcar[m]>
lynxis: is there a missunderstanding on https://github.com/openwrt/openwrt/pull/4170 (busybox timestamps)? I'd merge this since based on rsalvaterra experience busybox seems to be rather "slow" to respond
<rsalvaterra>
aparcar[m]: I'd merge it for the time being, yes. My BusyBox patch took months to be merged, IIRC.
<aparcar[m]>
I'll wait for lynxis and then merge it
valku has joined #openwrt-devel
<aparcar[m]>
does OpenWrt 19.07 support JavaScript based LuCI apps?
clayface has quit [Read error: Connection reset by peer]
clayface has joined #openwrt-devel
valku has quit [Quit: valku]
caiortp has joined #openwrt-devel
zjason has joined #openwrt-devel
Immanuel has quit [Ping timeout: 246 seconds]
Immanuel has joined #openwrt-devel
caiortp has quit [Read error: Connection reset by peer]
AlexisEvelyn has quit [Read error: Connection reset by peer]
AlexisEvelyn has quit [Read error: Connection reset by peer]
AlexisEvelyn has joined #openwrt-devel
decke has quit [Quit: Leaving.]
embargo has joined #openwrt-devel
danitool has quit [Quit: Cubum autem in duos cubos, aut quadratoquadratum in duos quadratoquadratos]
AlexisEvelyn has quit [Ping timeout: 260 seconds]
AlexisEvelyn has joined #openwrt-devel
netprince_ has joined #openwrt-devel
dedeckeh has quit [Ping timeout: 240 seconds]
jlsalvador has quit [Quit: jlsalvador]
mattsm has quit [Read error: Connection reset by peer]
mattsm has joined #openwrt-devel
goliath has quit [Quit: SIGSEGV]
<zorun>
aparcar[m]: I don't know what AUTORELEASE is
<jow>
aparcar[m]: yes, it does
jlsalvador has joined #openwrt-devel
Nick_Lowe has joined #openwrt-devel
<aparcar[m]>
jow: thanks. could you please help me with some comments on the current luci-app-attenddsysupgrade? I didn't really understand all the smart LuCI JS concepts
<rmilecki>
jow: how can I save all uci changes without uci.save() which brings a popup with summary?
<rmilecki>
jow: i added migration code that does all required uci.set() calls and then return uci.save().then(L.bind(L.ui.changes.init, L.ui.changes)).then(L.bind(L.ui.changes.displayChanges, L.ui.changes));
<rmilecki>
but that brings a popup
<rmilecki>
jow: i checked uci.save function and it does all kind of magic related to the .callAdd() and .callSet(), I don't want to reimplement that magic
<rmilecki>
jow: or should I avoid uci.set() calls and use .callSet() directly?
AlexisEvelyn has quit [Ping timeout: 245 seconds]
Nick_Lowe has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
<blogic>
rmilecki: on a rampage, love it :-)
Nick_Lowe has joined #openwrt-devel
<rmilecki>
uh, i hit something fishy
<rmilecki>
RPCError: RPC call to uci/set failed with ubus code 2: Invalid argument
<rmilecki>
but reply in Network looks actually cool to me :| [{"jsonrpc":"2.0","id":23,"result":[0,{"section":"cfg0a0f15"}]},{"jsonrpc":"2.0","id":24,"result":[2]}]
<rmilecki>
oh, the second one does not
AlexisEvelyn has joined #openwrt-devel
AlexisEvelyn has quit [Read error: Connection reset by peer]
<rsalvaterra>
aparcar[m]: I may be wrong, but I have this faint idea the BusyBox nslookup wouldn't allow to specify the DNS port.
<aparcar[m]>
tell me more
<rsalvaterra>
I can't, I'd have to rebuild and test myself. Or look at the source. Either way, it's past midnight here, and I need to hit the sheets. :)
<aparcar[m]>
bueno
<rsalvaterra>
I'll take a look at it in the morning, if not overwhelmed at $dayjob.
<aparcar[m]>
I'll look more into it and see if I can figure something out :)
SamantazFox has quit [Ping timeout: 265 seconds]
Borromini has quit [Quit: leaving]
<aparcar[m]>
Change LocalRemote Package
<aparcar[m]>
-1204230492231696busybox
<rsalvaterra>
Alright, tell me if you get there before me, so we don't duplicate efforts.
<aparcar[m]>
you'll see in the commit log ;P
<rsalvaterra>
That's a nice diff, indeed!
<aparcar[m]>
well these 1200 bytes may contain some port functionality
<rsalvaterra>
Yeah, quite a difference. Enough for a lot more going on.