<daniels>
icecream95: I wonder if 0x22 is one of the ASTC formats perhaps?
<robmur01_>
so judging by that the same case was happening before, it just wasn't being screamed about
<robmur01_>
what I don't know is whether RGBA formats are expected to have a sampler key, whether it's a mistake that we ever call into that at all for such formats, or whether the message is entirely spurious :/
<tomeu>
alyssa: btw, I'm looking at a gles3 crash due to we not having a layer stride per level in 3d textures
<tomeu>
that could explain some flip-flops, as some texture memory might be overwritten later
<robmur01_>
re texture formats: I think those are configurable based on licensing, so beware that the "same" GPU on different SoCs (or potentially even different variants of one SoC) may have differing support. No idea about discoverability though :(
<alyssa>
So the problem is that r32_snorm (0x65) only defines a single channel, but the swizzle we're providing accesses all four channels (since the driver thinks it's RGBA, since that's what it is except for this stealthy change of format code at the 11th hour)
<alyssa>
Up to you how you want to resolve that, but you have access to both swizzles right where you do the format switcharoo :)
<alyssa>
Next up, I guess, will be sRGB blend shaders so tomeu is unblocked
<icecream95>
Making both swizzles just PIPE_SWIZZLE_X*4 doesn't change anything (except making everything greyscale)
<alyssa>
Hm.
<alyssa>
What about, like, X000?
* alyssa
isn't confident about the exact hw requirements here
<icecream95>
That doesn't help either...
<alyssa>
Hrm.
<icecream95>
Now I need to reboot again because of a recursive fault...
<alyssa>
Do you mind sending the patch (with the swizzle)? I can take a look
stikonas has joined #panfrost
<icecream95>
The 0x{6..}7 formats cause a null deref in drm_mm_takedown when quitting...
* alyssa
blinks
<alyssa>
That one's not on me I swear
NeuroScr has joined #panfrost
<alyssa>
Okay, this is interesting
<alyssa>
ld_color_buffer_u8_as_fp16 does sRGB->RGB conversion implicitly if necessary
<alyssa>
But we have to do the RGB->sRGB conversion explicitly ourselves
<alyssa>
Using a pair of ldst_op_09 opcodes I guess
<alyssa>
tomeu: This could take some time
<alyssa>
Oddly, this seems backwards from the behaviour I mention in the NIR comments, um
<alyssa>
Lowering to ALU ops is an option in the interim, nir_format_linear_to_srgb looks like it'll do what we need and that hooks in nicely with nir_lower_framebuffer
BenG83 has joined #panfrost
pH5 has quit [Ping timeout: 260 seconds]
pH5 has joined #panfrost
stikonas has quit [Remote host closed the connection]
abordado has quit [Read error: Connection reset by peer]