stikonas has quit [Remote host closed the connection]
Daanct12 has joined #panfrost
Daanct12 has quit [Remote host closed the connection]
Danct12 has joined #panfrost
robmur01_ has joined #panfrost
robmur01 has quit [Ping timeout: 240 seconds]
atler is now known as Guest49164
atler has joined #panfrost
Guest49164 has quit [Ping timeout: 265 seconds]
bbrezillon has quit [Ping timeout: 265 seconds]
Depau has quit [Ping timeout: 260 seconds]
Depau has joined #panfrost
bbrezillon has joined #panfrost
camus has joined #panfrost
kaspter has quit [Ping timeout: 240 seconds]
camus is now known as kaspter
kaspter has quit [Quit: kaspter]
kaspter has joined #panfrost
kaspter has quit [Ping timeout: 240 seconds]
kaspter has joined #panfrost
AreaScout_ has quit [Remote host closed the connection]
davidlt has joined #panfrost
davidlt has quit [Ping timeout: 240 seconds]
kaspter has quit [Ping timeout: 265 seconds]
kaspter has joined #panfrost
archetech has quit [Quit: Konversation terminated!]
<tomeu>
please tell us more about how do you review statistically
<alyssa>
tomeu: When I see an MR, I check the name and then roll a dice, commenting r-b if it's Boris and I roll a 2 or above, another Mesa dev and I roll a 3 or above, and a stranger is I roll a 4 or above.
<alyssa>
In rare cases I might check the patch.
<alyssa>
/s
<tomeu>
I can see how that can save some time, sometimes
<alyssa>
The bottleneck is rolling the dice.
kaspter has quit [Ping timeout: 276 seconds]
kaspter has joined #panfrost
vstehle has joined #panfrost
davidlt has joined #panfrost
kaspter has quit [Ping timeout: 265 seconds]
kaspter has joined #panfrost
<bbrezillon>
alyssa: so the solution to your review bandwidth issue is to increase the number of dice so you can review several MRs in // :-)
<bbrezillon>
icecream95: what's the commit hash?
guillaume_g has joined #panfrost
warpme_ has joined #panfrost
nlhowell has joined #panfrost
wwilly has quit [Quit: Leaving]
icecream95 has quit [Quit: Bridge terminating on SIGTERM]
JJJollyjim has quit [Quit: Bridge terminating on SIGTERM]
stebler[m] has quit [Quit: Bridge terminating on SIGTERM]
icecream95 has joined #panfrost
<icecream95>
bbrezillon: It was 50061670614 ("panfrost: Hook-up indirect dispatch support")
<icecream95>
The main problem is checking for PAN_SYSVAL_NUM_WORK_GROUPS in the loop in panfrost_emit_const_buf, which will stop working as each loop iteration will upload multiple sysvals/uniforms
<icecream95>
I'll probably try looking up the offset of NUM_WORK_GROUPS within the push constants in pan_shader_compile, then just set num_wg_sysval to that + push_transfer.gpu
JJJollyjim has joined #panfrost
camus has joined #panfrost
kaspter has quit [Ping timeout: 276 seconds]
camus is now known as kaspter
stebler[m] has joined #panfrost
stikonas has joined #panfrost
stikonas has quit [Remote host closed the connection]
stikonas has joined #panfrost
raster has joined #panfrost
robmur01_ is now known as robmur01
stikonas_ has joined #panfrost
stikonas has quit [Ping timeout: 246 seconds]
stikonas_ has quit [Remote host closed the connection]