<icecream95>
It seems that the alignment code in pan_preload_emit_viewport is wrong...
raster- has joined #panfrost
raster has quit [Disconnected by services]
raster- is now known as raster
<icecream95>
heh, GIMP hits issues with both reload (or I guess preload now?) and CRC code, but the artefacts from each look similar, so I was getting confused for a bit at why my fix to one wasn't completely working
Net147 has joined #panfrost
stikonas has quit [Ping timeout: 260 seconds]
raster has quit [Quit: Gettin' stinky!]
atler has quit [Ping timeout: 252 seconds]
atler has joined #panfrost
anarsoul|c has quit [Quit: Connection closed for inactivity]
davidlt has joined #panfrost
camus has joined #panfrost
kaspter has quit [Ping timeout: 240 seconds]
camus is now known as kaspter
Lyude has quit [Quit: WeeChat 3.0.1]
Lyude has joined #panfrost
vstehle has quit [Remote host closed the connection]
<icecream95>
bbrezillon: I think that fix is wrong, it should be MIN2(ALIGN_POT(fb->extent.maxx + 1, 32), fb->width) - 1
<bbrezillon>
icecream95: absolutely
<bbrezillon>
mind send a MR for that?
<bbrezillon>
you have my R-b
<bbrezillon>
*mind sending
vstehle has joined #panfrost
guillaume_g has joined #panfrost
catfella has quit [Remote host closed the connection]
nlhowell has joined #panfrost
<icecream95>
bbrezillon: The CRC issue is that MALI_PRE_POST_FRAME_SHADER_MODE_ALWAYS and clean_fragment_write = false need to be used for batches where the CRC data is full && !valid
<bbrezillon>
I'm a bit lost in all those weird combinations, but send a patch and I'll review it
patrik has joined #panfrost
stikonas has joined #panfrost
stikonas has quit [Read error: Connection reset by peer]
stikonas has joined #panfrost
nlhowell has quit [Ping timeout: 240 seconds]
<icecream95>
eh? "Batch max values are inclusive, we need to subtract 1." [The following line does not subtract 1]
<bbrezillon>
oops, that's a copy&paste error
<bbrezillon>
fb->extent.max values are exclusive
<icecream95>
They seem to be inclusive, though it might make more sense to change them to be exclusive
<bbrezillon>
sorry, inclusive (that is, maxx is the last pixel being written on the X axix)
<bbrezillon>
and I'd like to keep it that way
<bbrezillon>
unless you have a good reason to make it exclusive
<bbrezillon>
having batch and fb_info follow the same rule would be good though
<icecream95>
Currently batch is exclusive and fb->extent is inclusive
<bbrezillon>
yep
neonking has quit [Ping timeout: 240 seconds]
<bbrezillon>
and I'd prefer to make batch use inclusive coords
raster has joined #panfrost
camus has joined #panfrost
chewitt has joined #panfrost
kaspter has quit [Ping timeout: 260 seconds]
camus is now known as kaspter
chewitt has quit [Quit: Zzz..]
chewitt has joined #panfrost
chewitt_ has joined #panfrost
chewitt has quit [Ping timeout: 240 seconds]
chewitt_ is now known as chewitt
stikonas has quit [Read error: Connection reset by peer]
stikonas has joined #panfrost
pendingchaos has quit [Quit: No Ping reply in 180 seconds.]
zkrx has quit [Ping timeout: 265 seconds]
pendingchaos has joined #panfrost
pendingchaos has quit [Ping timeout: 252 seconds]
pendingchaos has joined #panfrost
zkrx has joined #panfrost
warpme_ has joined #panfrost
stikonas has quit [Remote host closed the connection]