<johnf>
ah, interesting, the issue may be broken bridge support
<johnf>
root@OpenWrt:/# brctl addbr test
<johnf>
brctl: bridge test: No error information
<johnf>
though, err, how I achieved that and how I can fix it are not at all clear to me :)
<johnf>
jow: it is bridging, I can fix it if I comment out #option type 'bridge'
<johnf>
however for other reasons I cannot do this
<johnf>
I've got scripts that depend on br-lan being present
<jow>
I could imagine that the lack of IPv6 support is the cause
<jow>
some code somewhere not expecting ipv6 related operations to fail
<johnf>
I do have kernel ipv6 support enabled
<jow>
nope
<jow>
# CONFIG_KERNEL_IPV6 is not set
<jow>
line 26
<johnf>
I see that, in make kernel_menuconfig, bridging is set to m
<johnf>
hmm, it's enabled in kernel_menuconfig
<jow>
ah
<jow>
then you're probably missing kmod-bridge
<johnf>
yes, I used kernel_menuconfig, I am a bad person
<jow>
if that even exists yet
<jow>
afair it was removed a while back since we expect bridge support to be always builtin
<jow>
but I might misremember
<jow>
so either make bridging =y or enable kmod-bridge if it still exists
<johnf>
I have: <M> 802.1d Ethernet Bridging
<jow>
(kmod-bridge in menuconfig, not kernel_menuconfig)
<johnf>
ah, I think I see the nature of the problem
<johnf>
this is built as a module as IPv6 is built as a module
<johnf>
jow: I see that kernel_ipv6 exists in the config, but there's no way to access it from menuconfig, is that right?
dedeckeh has joined #openwrt-devel
<jow>
johnf: afaik not, no
ephemer0l has joined #openwrt-devel
<johnf>
ok, and if I set it to =y
<johnf>
and then run make menuconfig
<johnf>
it appears to revert
Radu-Mamy has joined #openwrt-devel
<johnf>
ok, I'm trying to turn ipv6 back on
<johnf>
but it greatly increases kernel memory consumption
<jow>
you can use the slash (/) search to track the dependencies
<johnf>
and then all my stuff OOMs
<johnf>
I used the / search, the dependancies aren't clear, that one appears to have none
<jow>
KERNEL_IPV6 might be a hidden symbol toggled by other symbols
<johnf>
this, I think, is possible
<johnf>
I do see it referenced in ipv6 mutlicast routing
<johnf>
but that setting isn't in the kernel build options
<johnf>
where does kernel_menuconfig store it's settings?
<jow>
it actually modified target/linux/$platform/config-xxx
<jow>
see git diff
caiortp has joined #openwrt-devel
<johnf>
ok, thanks
<johnf>
I'm trying to build with IPv6 re-enabled
<johnf>
to see what the resulting image looks like
owrt-snap-builds has quit [Remote host closed the connection]
owrt-snap-builds has joined #openwrt-devel
<jow>
I usually state that disabled IPv6 is an unsupported configuration due to issues like that
<jow>
nobody actually tests this, or at least properly maintains the feature dependencies
<johnf>
yeah, I understand
<johnf>
I just really really need the 2MB
<johnf>
interestingly I think it's the damage I did to the kernel config file that's the real problem, even with IPv6 enabled it's still not getting functional bridging
<johnf>
I've updated the forum post, thanks very much for your help jow
dedeckeh has quit [Quit: Ping timeout (120 seconds)]
Tapper has quit [Ping timeout: 245 seconds]
silverwhitefish has quit [Quit: One for all, all for One (2 Corinthians 5)]
Tapper has joined #openwrt-devel
silverwhitefish has joined #openwrt-devel
djdisodo has joined #openwrt-devel
<jow>
hmm, wireless config reload seems to be unreliable in master
<jow>
I've had several cases now where a manual wifi down/wifi up was required to apply new settings
djdisodo has quit [Read error: Connection reset by peer]
dangole has quit [Remote host closed the connection]
djdisodo has joined #openwrt-devel
<Borromini>
jow: any errors in logread?
<Borromini>
i've seen issues where i outright need to kill the hostapd instance before wireless will come up again
dangole has joined #openwrt-devel
ekathva has joined #openwrt-devel
caiortp has quit [Ping timeout: 246 seconds]
<dangole>
jow: is possible to reproduce that state somehow? so i can check what's going wrong
<jow>
dangole: will try. Right now it happened when renaming the SSID of default_radio0 and enabling it via LuCI
<jow>
nothing happened, ubus call network.wireless status kept showing the old state
<jow>
wifi down / wifi up brought the wifi up as expected
<jow>
LuCI relies on config reload triggers behind the scenes, there's no explicit calls to /sbin/wifi or /etc/init.d/network
Radu-Mamy has quit [Quit: Radu-Mamy]
valku has joined #openwrt-devel
dangole has quit [Remote host closed the connection]
dangole has joined #openwrt-devel
<dangole>
jow: just tried exactly that on mt7622 hardware. enabled wifi in LuCI, comes up with default SSID, change SSID in LuCI to 'OpenWrt1', click apply, SSID changes in air as well as ubus call network.wireless. which hardware/driver are you trying this on?
<dangole>
jow: I previously had problems testing changing parameters even just from within hostapd_cli when running on mac80211-hwsim...
<dangole>
jow: (hence my question)
<jow>
dangole: tested on a Zbt wg2626
<jow>
which is mt7621 afair
<dangole>
jow: yes, mt7621+mt7612+mt7602, i know that hardware :)
linzst has joined #openwrt-devel
<jow>
on hwsim I don't have issues atm
<jow>
on the zbt, the 5ghz radio was already active and configured since while
<jow>
I tried to enable the 2.4ghz radio to setup a management access
djdisodo has quit [Read error: Connection reset by peer]
<jow>
this involved changing the sssid, setting a wpa key, creating a new network and assigning it to the lan zone
<jow>
will try to reproduce it later
<dangole>
jow: i'll also play with it a bit more, switching modes, changes interfaces, ...
<jow>
my hunch is that this happens when the wireless status "structure" changes, that is new networks and/or radio phys come online
linzst has quit [Client Quit]
<dangole>
jow: that could be indeed, i'll dig a bit there
dorf has joined #openwrt-devel
<jow>
dangole: can't manage to reproduce it using hwsim, will try on the zbt later
<dangole>
ynezz: i could temporarily chip-in 16 Intel Xeon E312xx (Sandy Bridge) (family: 0x6, model: 0x2a, stepping: 0x1) cores to speed things up a bit. it's a VM in a datacentre in the US, well connected, 16 gigs of RAM. i usually use it for private test-builds and that hardware it's shared with other likeminded people (who i've just asked, and they are fine with offering this for OpenWrt)
<dangole>
ynezz: currently runs debian buster, i got root.
<dangole>
ynezz: the box got 32 cores and 96gb of ram total, i was just told we could bump my share of ram to a bit more, if needed
djdisodo has joined #openwrt-devel
djdisodo has quit [Client Quit]
Tapper has joined #openwrt-devel
decke has quit [Quit: Leaving.]
<dangole>
karlp: does the hotplug.ntp get called properly via ubus? ie. can you do `ubus monitor` and see what's going on at the time you see this message?
<dangole>
karlp: because this is probably the stdout/stderr of a script in /etc/hotplug.d/ntp
<dangole>
karlp: i've seen this before being caused by /etc/hotplug.d/ntp/25-dnsmasqseq because initscript variable was unset and /lib/functions/procd.sh assumes it to be set.
<dangole>
karlp: that's why i set it in commit aed95c4cb8d which fixed it for me
owrt-2102-builds has quit [Remote host closed the connection]
owrt-1907-builds has quit [Remote host closed the connection]
philipp64 has quit [Quit: philipp64]
owrt-1907-builds has joined #openwrt-devel
owrt-2102-builds has joined #openwrt-devel
philipp64 has joined #openwrt-devel
<dangole>
hauke: can you try if `fw_setenv rootfs_data_max 0x1000000` has the desired effect on that device? it should limit the size of rootfs_data to 16MiB after the next sysupgrade to have the then free space available for additional user-defined UBI volumes (e.g. permanent logs/stats, container filesystems, ...)
<dangole>
hauke: (talking about the WSR-2533DHP2)
<karlp>
dangole: yeah, I had gotten as far as looking at all the hot plug scripts, (I have a couple of my own too) but couldn't see anything unexpected/visibly broken
<karlp>
and I have the initscript= patch in this build.
<dangole>
karlp: and not using unbound or other hooks in /etc/hotplug.d/ntp I assume, right?
<karlp>
nope.
<karlp>
have some of my own hooks to run services, but I'm running them again by hand and not seeing anything, and they're all disabled now.
<dangole>
karlp: do you add anything to /etc/hotplug.d/ntp specificly?
<karlp>
yes, but I've already removed them, and none of them call basename anyway.
<dangole>
karlp: they may call basename indirectly by sourcing /lib/functions/procd.sh or things like that...
<dangole>
karlp: anyway, if you removed them and it's only the dnsmasq script left, it got to be that then
<karlp>
they do a . /lib/functions/procd.sh
<karlp>
I was calling my scripts manually, envs different I guess.
<dangole>
karlp: so in that case you got to set initscript=something just like i did in the dnsmasq script
* karlp
pokes it.
lukedashjr has joined #openwrt-devel
<karlp>
I'm not even using any functions from procd, is shell expanding them all inside functions even if they're not called?
<karlp>
I thought shell scripting just ran stuff when it was called?
<dangole>
by sourcing /lib/functions/procd.sh that script is executed and it does more than just defining functions (that basename is outside of any function)
luke-jr has quit [Ping timeout: 245 seconds]
<karlp>
oh, the bottom line calls it all, awesome, just got to the bottom of the file.
<karlp>
it's procd_lock.
<dangole>
karlp: maybe we should improve logging for the hotplug handlers, i admit it's not obvious where this is comming from right now (just spitting it to /dev/console)
<karlp>
why couldn't procd_lock just use $0 instead of assuming "initscript" is available?
<karlp>
we have to source the file anway...
<dangole>
because of symlinks to init scripts
lukedashjr is now known as luke-jr
<dangole>
could use realname of readlink instead, i guess. we should grep for existing users setting initscript= themselves (rather than /etc/rc.common doing that)
<Hauke>
dangole: ok I will try
<Hauke>
dangole: in The UGW for GRX500 we also create the overlay partition in UBI only with 32 instead of all the rest
<Hauke>
this way we have no problem when the kernel or rootfs partition increases in an update
<Hauke>
32MB
<dangole>
Hauke: yes, makes for sense to have it for other things. for the linksys e8450/belkin rt3200 i also implemented it in U-Boot, doesn't matter if you flash through U-Boot or using sysupgrade, rootfs_data_max is always respected
<dangole>
Hauke: size changes I solved by just making use of uImage.FIT properly :)
<karlp>
ok, one of my scripts had the sourcing of procd functions, it didn't need it, I've just removed it. sorted. thanks dangole!
<dangole>
Hauke: but for that U-Boot needs to be quite recent
<dangole>
karlp: happy to help
<dangole>
Hauke: but I like the result a lot now, kernel+squashfs is nicely structured image which my FIT partition parser can make sense of and map the squashfs partition for rootfs. and in case this running on GPT, there is a magic GUID for FIT which triggers parsing the sub-partitions. in that case (GPT on block device) the remaining space after the FIT image is used for rootfs_data.
Borromini has quit [Ping timeout: 264 seconds]
<dangole>
Hauke: that makes things work very much the same no matter if we are on block storage or UBI. i will also update the mtdsplit/fit.c to actually parse fit structure (rather than just the header) to get the total size, so the resulting mtdblock device holding the FIT can (just like ubiblock) then contain partitions incl. squashfs. needs 4k padding around squashfs, but that's worth it.
<rsalvaterra>
Grommish: Ping. Still no hangs with my patch? :)
KanjiMonster_ has joined #openwrt-devel
<Hauke>
dangole: will this also also work with an upstream U-Bot?
lipnitsk1 has joined #openwrt-devel
pgwipeout[m]1 has joined #openwrt-devel
KanjiMonster has quit [Ping timeout: 265 seconds]
pgwipeout[m] has quit [Ping timeout: 265 seconds]
lipnitsk has quit [Ping timeout: 265 seconds]
whyz has quit [Ping timeout: 264 seconds]
whyz has joined #openwrt-devel
<dangole>
Hauke: all features needed form U-Boot are already in place in U-Boot 2020.10 and later. what i added was the parser for uImage.FIT in target/linux/generic/files/block/partitions/fit.c as well as image generation and sysupgrade scripts
<Hauke>
dangole: good
<dangole>
Hauke: i hope that this will be the future for all targets using recent U-Boot (ie. sunxi, rockchip, ...) and replace the IBM PC legacy boot imitation with FAT boot partition and all that, while gaining flexibility and robustness (because bootloader can make sure system will actually start, ie. hash of squashfs is checked before starting kernel)
<dangole>
Hauke: and i built logic in fstools to handle config-restore from tar.gz written directly to partition, like we do on flash-based targets, so no need to stash config in the boot volume
<Hauke>
dangole: with the u-boot config option the overlay fs is smaller: overlayfs:/overlay 13.3M 48.0K 12.6M 0% /
<Hauke>
I am using the vendor u-boot
<dangole>
Hauke: all needed for that is persistent U-Boot env. U-Boot itself doesn't need to handle that variable unless you are using U-Boot to flash OpenWrt
<dangole>
Hauke: and beautiful to know it just works. you could create more (ubifs) volumes simply using `ubimkvol /dev/ubi0 -N foo -s 16M`
<dangole>
Hauke: (and those volumes will survive sysupgrade)
<Hauke>
nicve
pine127 has quit [Ping timeout: 268 seconds]
pine127 has joined #openwrt-devel
<dangole>
Hauke: regarding parsing FIT with external data (ie. offsets stored in the FDT structure rather than the images itself) i guess the vendor loader will fail, being U-Boot 2014 afair...
<Hauke>
I would like to supprot the vendor u-boot, becasue this maeks it easy for users to install OpenWrt
<Hauke>
but having a good implementation too is nice so hopefully the vendors will switch at some point in time
<Hauke>
FIT images are now used by multiple vendors in production
<Hauke>
you can install openwrt on the buffelo device over the web ui
<dangole>
Hauke: I guess vendors will just go with what they find in $chipvendor SDK. and that should be quite up to date in case of MTK afaik.
<Hauke>
yes, if mtk uses the new U-bot by default many vendors will use that too
<dangole>
Hauke: ie. there it's all already included, U-Boot can handle FIT generated using `mkimage -E` which will allow partition parser to work with them and map squashfs (and other nice things, like having localization squashfs as well well, or DT overlay blobs added)
<dangole>
Hauke: since they now all support this "external data" FIT it finally starts to make sense. because you can actually parse it without paging around megabytes of image blob...
<dangole>
Hauke: i still believe replacing the complete bootchain can be feasible in some cases (like that linksys/belkin device which really got it wrong), and installation can be just as easy, and even reverting back doesn't need to be hard (the installer makes a backup of relevant areas of the flash and writes that into files on a dedicated volume in the newly created UBI partition)
ekathva has quit [Ping timeout: 240 seconds]
<Hauke>
ok
Acinonyx_ has joined #openwrt-devel
Acinonyx has quit [Ping timeout: 246 seconds]
<dangole>
Hauke: just the build system is not really in shape for that yet. ie. the installer generator now wraps the ImageBuilder to create custom initramfs images (which the IB by itself doesn't support yet).
<dangole>
Hauke: I've added the basics, to support generating dedicated initrd image for inclusion in FIT instead of embedding it into the kernel. but all the Makefile jungle to allow doing that also in the IB is still waiting for me.
<dangole>
Hauke: patch making U-Boot env writable looks good to me, push it now that buildbot hasn't made it beyond doing apm821xx/nand ;)
grift_ has joined #openwrt-devel
muhaha has quit [Quit: Connection closed]
falk0n has joined #openwrt-devel
sbrown has joined #openwrt-devel
grift has quit [*.net *.split]
JuniorJPDJ has quit [*.net *.split]
barhom has quit [*.net *.split]
Ivan__83 has joined #openwrt-devel
barhom has joined #openwrt-devel
JuniorJPDJ has joined #openwrt-devel
Ivan_83 has quit [Ping timeout: 272 seconds]
barhom has quit [Max SendQ exceeded]
valku has quit [Quit: valku]
lipnitsk1 has quit [Ping timeout: 240 seconds]
barhom has joined #openwrt-devel
agb[m] has quit [Ping timeout: 240 seconds]
Q_ has quit [Ping timeout: 244 seconds]
Jonny[m]1 has quit [Ping timeout: 241 seconds]
pgwipeout[m]1 has quit [Ping timeout: 249 seconds]
nick[m] has quit [Ping timeout: 249 seconds]
voltagex has quit [Ping timeout: 249 seconds]
falk0n has quit [Quit: leaving]
decke[m] has quit [Ping timeout: 247 seconds]
fblaese has quit [Ping timeout: 247 seconds]
magnusk has quit [Ping timeout: 260 seconds]
shalzz has quit [Ping timeout: 268 seconds]
MatMaul has quit [Ping timeout: 246 seconds]
aparcar[m] has quit [Ping timeout: 246 seconds]
olmari has quit [Ping timeout: 244 seconds]
JuniorJPDJ has quit [Ping timeout: 265 seconds]
Ivan__83 has quit [Ping timeout: 272 seconds]
Ivan__83 has joined #openwrt-devel
danitool has quit [Quit: Cubum autem in duos cubos, aut quadratoquadratum in duos quadratoquadratos]