<kevina>
whyrusleeping: anything else, trying to figure out the barriers to getting this merged.
chax has joined #ipfs
<kevina>
it's the last major required change. Once that merged we can start to focus on the actual filestore code
<whyrusleeping>
yeah, i'm going through and reviewing
<kevina>
thanks.
chax has quit [Remote host closed the connection]
chax has joined #ipfs
chax has quit [Ping timeout: 260 seconds]
<Mateon1>
I'm wondering, should I create an issue in ipfs/notes (or a libp2p repo) about creating a Wireshark protocol dissector? I believe we should have one (or multiple) when IPFS is production ready.
<lgierth>
Mateon1: definitely!
<lgierth>
there's --disable-transport-encryption so we can actually do a lot there
<lgierth>
you'd need dissectors for multiple layers of multistream, for the different stream muxers, for the actual swarm protocols (bitswap, identify, ping)
<Mateon1>
I'm currently looking through the specs and tring to wrap my head around how everything actually works
<lgierth>
i think multistream would be the one to start with, that's the outermost layer
<lgierth>
the secio or tls, then multistream again, then the stream muxer, then multistream again, then the swarm protocols
ianopolous has quit [Remote host closed the connection]
<whyrusleeping>
kevina: finished my review
<whyrusleeping>
not really convinced on things yet, still thinking
<kevina>
so lets talk about "This really complicates things..." with --allow-dup option.
<whyrusleeping>
so, i think i would feel better, at least for now, if we only skipped putting to the main blockstore if the main blockstore already has the block
lacour has quit [Ping timeout: 244 seconds]
<whyrusleeping>
that way we avoid the concern in my comment on the Put method
<kevina>
i'm confused ????
<whyrusleeping>
so, if the filestore has block QmABC
<whyrusleeping>
and i add a file (normally) that contains QmABC
<whyrusleeping>
it will put a block into the normal blockstore
<whyrusleeping>
and not skip adding that block because the filestore has a reference
<kevina>
I _think_ I can do that.
<kevina>
The problem is that the exchange will try to add the block _again_ before it publishes.
<kevina>
Thus when adding files to the filestore they will _also_ end up the the main blockstore.
<whyrusleeping>
hrm...
<whyrusleeping>
kevina: can we have a PR first that does the extraction of the locking logic from the blockstore?
<kevina>
whyrusleeping: sure
<apiarian>
shower thought: can findprovs be used as a proxy for the relative popularity of an object?
<whyrusleeping>
haileris: i really don't know. These are things i havent experimented with at all
<kevina>
whyrusleeping: that the easy part :) But it helps.
<kevina>
whyrusleeping: the hard part is I didn't really design it to be swappable.
<kevina>
whyrusleeping: I just need to think it through
<kevina>
whyrusleeping: I say a few days when I am not 100% sure of the work involved :)
<kevina>
whyrusleeping: but I will work on it
<haileris>
@whyrusleeping OK I'll test and get back to you
<whyrusleeping>
kevina: it should be pretty easy to drop your multiblockstore into that
<kevina>
whyrusleeping: yes, see my comments above
<haileris>
@whyrusleeping and BTW, your solution to the binding issue worked :)
<whyrusleeping>
haileris: ah, sweet :)
<haileris>
yes :) ipfs id QmcnSFQwSmGfUvWujiZ7UjPTw9fDqz5UFz9Td1abNTQUmr now shows just /ip4/127.0.0.1/... and /ip6/fd87:d87e:eb43:cafe:a090:c13d:adb2:bf86/...
<haileris>
so an ipfs branch in onionland seems doable
<kevina>
whyrusleeping: I am not 100% sure how I will use that, so hold off on merging it into master. I will try to use it and if I do base my comits on that P.R.
<Mateon1>
Okay, this time I did switch the branches, but the fix for Windows drive paths didn't work.
<whyrusleeping>
kevina: you will want to implement a SetupFilestoreOption
<whyrusleeping>
that will override the SetupBlockstore default
<whyrusleeping>
and use the multiblockstore
<kevina>
okay thanks for the tips, I am not really 100% now, so I will look at this tomorrow
<kevina>
whyrusleeping: okay with holding off?
<whyrusleeping>
yeah, i'll wait
<kevina>
thanks
ygrek has quit [Ping timeout: 260 seconds]
gmcquillan__ has quit [Quit: gmcquillan__]
xrogaan has quit [Ping timeout: 260 seconds]
pinbot has quit [Ping timeout: 260 seconds]
alanz has quit [Ping timeout: 260 seconds]
pinbot has joined #ipfs
herzmeister has quit [Quit: Leaving]
<haileris>
@whyrusleeping - belatedly, thanks very much for your help :)
xming_ has quit [Quit: No Ping reply in 180 seconds.]
herzmeister has joined #ipfs
xming has joined #ipfs
captain_morgan has quit [Ping timeout: 260 seconds]
alanz has joined #ipfs
gmcquillan__ has joined #ipfs
xrogaan has joined #ipfs
gmcquillan__ has quit [Quit: gmcquillan__]
captain_morgan has joined #ipfs
chris613 has quit [Quit: Leaving.]
sdiver has quit [Quit: WeeChat 1.6]
haileris has quit [Quit: WeeChat 1.0.1]
captain_morgan has quit [Ping timeout: 265 seconds]
sdiver has joined #ipfs
geemili has quit [Ping timeout: 268 seconds]
chriscool has quit [Ping timeout: 265 seconds]
<kevina>
whyrusleeping: you still around?
<whyrusleeping>
kevina: not for much heavy thinking
<dignifiedquire>
also pushed my latest version for js-ipfs-api, which is close to working with that pr above
<daviddias>
interface-ipfs-core 0.18.1 is out :)
jholden has joined #ipfs
<dignifiedquire>
daviddias: going to head out now, can you please review the last three remaining prs js-ipfs, js-ipfs-api and bitswap so far? there are only minor bug fixes left so would be good to know if the code looks good to you
<dignifiedquire>
if credentials are failing I probbably made a mistake when copy pasting, so either check yourself or create an issue for me on those repos
<dignifiedquire>
daviddias: also THANK YOU for being an awesome release master
<daviddias>
sounds good. Thank you for making this awesome PR mountain :D a lot of our users and contributors will be thrilled to use the stuff without webpack magic
<daviddias>
:D
cemerick has joined #ipfs
maxlath has quit [Quit: maxlath]
ivanminutillo has quit [Ping timeout: 245 seconds]
<daviddias>
dignifiedquire: yeah, I think that Saucelabs just says unauthorized when it is out of concorrent sessions to spend
<daviddias>
and since greenkeeper fires 300 at the same time..
<dignifiedquire>
no I had to redo the token
<dignifiedquire>
probably pasted it wrong
<dignifiedquire>
well that also
moimikey has joined #ipfs
moimikey has quit [Client Quit]
shizy has quit [Quit: WeeChat 1.6]
shizy has joined #ipfs
aggelos_ has joined #ipfs
gmcquillan__ is now known as gmcquilla
gmcquilla is now known as gmcquillan
Encrypt has joined #ipfs
chax has joined #ipfs
espadrine has quit [Ping timeout: 260 seconds]
shizy has quit [Quit: WeeChat 1.6]
shizy has joined #ipfs
Boomerang has quit [Ping timeout: 260 seconds]
chax has quit [Remote host closed the connection]
Boomerang has joined #ipfs
ivanminutillo has joined #ipfs
chax has joined #ipfs
chax has quit [Remote host closed the connection]
herzmeister has quit [Quit: Leaving]
herzmeister has joined #ipfs
Boomerang has quit [Ping timeout: 250 seconds]
shizy has quit [Quit: WeeChat 1.6]
Encrypt has quit [Quit: Quit]
shizy has joined #ipfs
Boomerang has joined #ipfs
G-Ray has quit [Quit: Konversation terminated!]
maxlath has joined #ipfs
maxlath has quit [Client Quit]
jholden_ has joined #ipfs
wallacoloo_ has joined #ipfs
jholden has quit [Ping timeout: 265 seconds]
DiCE1904 has quit [Read error: Connection reset by peer]
ivanminutillo has quit [Ping timeout: 245 seconds]
DokterBob has quit [Quit: DokterBob]
rendar has quit [Ping timeout: 268 seconds]
j0hnsmith has joined #ipfs
Boomerang has quit [Ping timeout: 252 seconds]
herzmeister has quit [Quit: Leaving]
herzmeister has joined #ipfs
sevcsik has quit [Ping timeout: 250 seconds]
rendar has joined #ipfs
rendar has quit [Excess Flood]
sevcsik has joined #ipfs
bastianilso__ has joined #ipfs
matoro has joined #ipfs
wak-work has quit [Ping timeout: 256 seconds]
ligi has joined #ipfs
ligi has joined #ipfs
ligi has quit [Changing host]
j0hnsmith has quit [Quit: j0hnsmith]
aggelos_ has quit [Ping timeout: 268 seconds]
captain_morgan has quit [Ping timeout: 252 seconds]
aggelos_ has joined #ipfs
rendar has joined #ipfs
Boomerang has joined #ipfs
galois_d_ has joined #ipfs
herzmeisterderw has joined #ipfs
galois_dmz has quit [Ping timeout: 260 seconds]
herzmeister has quit [Quit: Leaving]
galois_dmz has joined #ipfs
jholden_ has quit [Ping timeout: 250 seconds]
galois_d_ has quit [Ping timeout: 260 seconds]
chris613 has joined #ipfs
grosscol has quit [Quit: Leaving]
Boomerang has quit [Ping timeout: 260 seconds]
galois_dmz has quit [Remote host closed the connection]
galois_dmz has joined #ipfs
galois_dmz has quit [Read error: Connection reset by peer]
galois_d_ has joined #ipfs
polezaivsani has quit [Remote host closed the connection]
mildred1 has quit [Ping timeout: 244 seconds]
hoboprimate has joined #ipfs
hoboprimate has quit [Client Quit]
galois_d_ has quit [Read error: Connection reset by peer]
galois_dmz has joined #ipfs
hoboprimate has joined #ipfs
hoboprimate has quit [Client Quit]
wak-work has joined #ipfs
hoboprimate has joined #ipfs
Encrypt has joined #ipfs
maxlath has joined #ipfs
hoboprimate has quit [Quit: hoboprimate]
captain_morgan has joined #ipfs
hoboprimate has joined #ipfs
cemerick has quit [Ping timeout: 265 seconds]
captain_morgan has quit [Ping timeout: 260 seconds]
captain_morgan has joined #ipfs
hoboprimate has quit [Quit: hoboprimate]
ulrichard_ has joined #ipfs
Encrypt has quit [Quit: Quit]
lacour has joined #ipfs
DokterBob has joined #ipfs
jedahan has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
captain_morgan has quit [Ping timeout: 260 seconds]
hoboprimate has joined #ipfs
matoro has quit [Ping timeout: 250 seconds]
taaem has quit [Ping timeout: 244 seconds]
herzmeisterderw has quit [Quit: Leaving]
mh00 has joined #ipfs
palkeo has joined #ipfs
palkeo has joined #ipfs
palkeo has quit [Changing host]
kegsay_ has joined #ipfs
<whyrusleeping>
daviddias: dignifiedquire: i would love to merge sharding...
<dignifiedquire>
not only you
<dignifiedquire>
cloning is running well so far
<dignifiedquire>
715G
kegsay has quit [Ping timeout: 256 seconds]
<dignifiedquire>
300k of 400kchanges processed
<whyrusleeping>
and the repository its building looks correct?
<dignifiedquire>
yes but haven't done any deeper analysis on it
<dignifiedquire>
I can stop processing and run some tests tomorrow
<whyrusleeping>
eh, thats fine
<whyrusleeping>
think you could review the sharding code?
<dignifiedquire>
I can read through it yes
<dignifiedquire>
want to understand it anyway
<whyrusleeping>
cool
<dignifiedquire>
will go throught it tomorrow when async crypto is behind me
<whyrusleeping>
the sooner we merge that, the sooner i can start the process of prepping an 0.4.5 release
<dignifiedquire>
will try to have feedback for you before you wake up :)
Boomerang has joined #ipfs
<whyrusleeping>
good :)
herzmeister has joined #ipfs
jedahan has joined #ipfs
jedahan has quit [Remote host closed the connection]
jedahan has joined #ipfs
wallacoloo_ has quit [Quit: wallacoloo_]
rendar has quit [Quit: std::lower_bound + std::less_equal *works* with a vector without duplicates!]
jedahan has quit [Remote host closed the connection]
jedahan has joined #ipfs
captain_morgan has joined #ipfs
<daviddias>
whyrusleeping me too.. :)
galois_dmz has quit [Remote host closed the connection]
<daviddias>
algorithm wise, I'm happy with it, was excellent that we found something researched along the lines of our intuition
galois_dmz has joined #ipfs
<daviddias>
in terms of verifying the correctness of the implementation, nothing beats extensive tests and weird scenarios, will need a bit more time for that
<daviddias>
what about users that are putting a lot of data to IPFS?
captain_morgan has quit [Ping timeout: 260 seconds]
<daviddias>
seeding that branch to them and getting feedback might be a good way to validate it'
pfrazee has quit [Remote host closed the connection]
<whyrusleeping>
i'm fairly confident that the code works, but i just want someone to verify that my code and the algorithm i intended to implement line up
bastianilso__ has quit [Quit: bastianilso__]
ulrichard has quit [Remote host closed the connection]
ulrichard_ has quit [Remote host closed the connection]
<daviddias>
dignifiedquire: what is missing in js-ipfs-api right now?
<dignifiedquire>
daviddias: make it work in the browser
<dignifiedquire>
or more specific wreck is not correctly shimed atm when running in the browser
<lgierth>
whyrusleeping: let me start that media.ccc.de mirror right now, if i'm lucky it'll be 100 MBps and i can start adding tomorrow
<lgierth>
oh wait, that's not really applicable
<lgierth>
it's huge files, but not tons of files
<daviddias>
I see
<daviddias>
you deactivated the browser tests, that is why they are green on travis :)
<dignifiedquire>
no they were deactivated on master, I just haven't turn them on yet
<dignifiedquire>
whyrusleeping: 291239 < current number of files in /npm-registry :D
<dignifiedquire>
(folders
PseudoNoob has quit [Quit: Leaving]
<dignifiedquire>
lgierth: that's what you should aim for ;)
<daviddias>
dignifiedquire: what is the size of the IPFS Repo?
<dignifiedquire>
723G
<lgierth>
and that's before gc eh?
<dignifiedquire>
that's before flushing
<dignifiedquire>
it's not pinned yet so please no gc :P
shizy has quit [Ping timeout: 260 seconds]
Pent has quit [Read error: Connection reset by peer]
palkeo has quit [Ping timeout: 252 seconds]
ljhms has quit [Ping timeout: 265 seconds]
maxlath has quit [Remote host closed the connection]
maxlath has joined #ipfs
ljhms has joined #ipfs
Aeon has joined #ipfs
DokterBob has quit [Quit: DokterBob]
captain_morgan has joined #ipfs
Anduck has quit [Ping timeout: 252 seconds]
Anduck has joined #ipfs
Qwazerty has quit [Ping timeout: 250 seconds]
Qwazerty has joined #ipfs
ralphtheninja has quit [Ping timeout: 260 seconds]