waleee-cl has quit [Quit: Connection closed for inactivity]
yyp has joined #river
leon-p has quit [Quit: leaving]
yyp has quit [Quit: now it's safe to turn off your computer]
yyp has joined #river
gspe has joined #river
entenel has quit [Ping timeout: 248 seconds]
betawaffle has quit [Ping timeout: 248 seconds]
betawaffle has joined #river
<novakane[m]>
I really see no reasons why there is this problem, it only happens in river but I look into other compositor code and saw nothing different
<novakane[m]>
if someone got an idea to help me find where it come from
<ifreund>
I haven't had time to look closely yet, hopefully soon
<novakane[m]>
do you have an idea what I could look for in priority?
<novakane[m]>
gdb show that it happen in `xkb.Keymap.newFromNames(context, &rules, .no_flags)` but I don't see why we would have a null pointer here, and `&rules` ptr are optionals so
<novakane[m]>
I guess it could be something from zig--xkbcommon?
<ifreund>
it's possible the extern function definition in zig-xkbcommon has a typo
<ifreund>
or the semantics of the xkbcommon function have changed and passing null is no longer ok
entenel has joined #river
londoed has quit [Remote host closed the connection]
londoed has joined #river
<novakane[m]>
well I continue my investigation
<novakane[m]>
I don't know what I could pass in the case we can't pass null anymore
<novakane[m]>
doesn't look like they changed this though
londoed has quit [Quit: Leaving]
yyp has quit [Quit: now it's safe to turn off your computer]
yyp has quit [Quit: now it's safe to turn off your computer]
londoed has quit [Remote host closed the connection]
londoed has joined #river
snakedye has joined #river
gspe has quit [Quit: gspe]
snakedye has quit [Ping timeout: 240 seconds]
londoed has quit [Remote host closed the connection]
londoed has joined #river
<leon-p>
so what are the current blockers for the layout protocol PR? I am aware of the transaction issue (and the idea to have per-output atomic transaction instead of an atomic global one). I also really need to get around to removing the tag from the advertise view event. The issue snakedye found regarding the order of the layout demand and tag status events may also be nice to fix. Oh, and default options and
<leon-p>
direction options.
<ifreund>
leon-p: I'm not aware of an existing transaction issue after my commits
<leon-p>
Actually the issue of the event ordering could be worked around by the layout generator, after receiving the layout demand event, first wait for the tag status event before comitting a layout
<leon-p>
ifreund: that's good to hear.
<ifreund>
the only blocker I'm aware of is the UX surrounding per-output options, which should be fixed by my wip modifications to river-options
<ifreund>
leon-p: yeah I've been daily driving for like a month now or something :)
<leon-p>
are per-output atomic commits still planned?
<ifreund>
the only pain point is the riverctl options interface
<ifreund>
leon-p: no
<ifreund>
I decided atomicity across outputs is not that hard and worth it
<leon-p>
I see
<ifreund>
right now moving views between outputs isn't frame perfect though
<ifreund>
just pushed the wlroots 0.13.0 update by the way, going to rebase the layout branch shortly
<leon-p>
sure, I'll wait for that before removing the tags from advertise_view
<ifreund>
no conflicts, let me just test to make sure nothing broke and I'll force push
<ifreund>
yeah, all seems fine
<leon-p>
any major changes in 0.13.0 that affect river?
<ifreund>
several bug fixes!
<ifreund>
also I implemented the API we need to handle xdg/layer surface popups and subsurfaces thereof properly without duplicating lots of code
<ifreund>
I should probably just build wlroots from source for the CI tbh...
<leon-p>
by the way, is zig-waylands scanner intended to eventually also scan the license and the description? I was playing around with turning it into a man page generator (Xlib functions are documented that way as well, which was a great help) but found those to be missing.
<ifreund>
leon-p: I'd love for it to scan all the documentation text from the xml and convert that into comments/doc comments in the generated zig code
<ifreund>
It just hasn't made it to the top of my todo list yet
<leon-p>
wait, I think I actually had a valid reason to have the tags in the advertise_view events. I'll leave it in for now.
<leon-p>
oh, are custom modes now working?
londoed has quit [Remote host closed the connection]
londoed has joined #river
<ifreund>
leon-p: yeah probably, though I didn't test
<ifreund>
I'm off to bed now though o7
<leon-p>
night!
londoed has quit [Remote host closed the connection]