kentonv changed the topic of #sandstorm to: Welcome to #sandstorm: home of all things sandstorm.io. Say hi! | Have a question but no one is here? Try asking in the discussion group: https://groups.google.com/group/sandstorm-dev
frigginglorious has quit [Read error: Connection reset by peer]
xet7 has quit [Remote host closed the connection]
xet7 has joined #sandstorm
NwS has quit [Quit: See you in Isla de Muerte!]
nwf has quit [Ping timeout: 240 seconds]
nwf has joined #sandstorm
nwf has quit [Ping timeout: 264 seconds]
nwf has joined #sandstorm
NwS has joined #sandstorm
NwS has quit [Remote host closed the connection]
vertigo_38 has quit [Ping timeout: 256 seconds]
vertigo_38 has joined #sandstorm
<vertigo_38>
(trying to download = clicking on the download-button in the davros user interface)
frigginglorious has joined #sandstorm
_whitelogger has joined #sandstorm
frigginglorious1 has joined #sandstorm
frigginglorious has quit [Ping timeout: 246 seconds]
frigginglorious1 is now known as frigginglorious
<JacobWeisz[m]>
I know the upload UI button on Davros is broken, maybe that one is too. :/
<JacobWeisz[m]>
Let me see if I can find out from Michael if he has any time to patch it.
<vertigo_38>
OK, thanks for the quick response!
<JacobWeisz[m]>
github.com/mnutt/davros/106 is the issue I think is relevant.
frigginglorious has quit [Read error: Connection reset by peer]
frigginglorious has joined #sandstorm
NwS has joined #sandstorm
NwS has quit [Quit: See you in Isla de Muerte!]
ecloud_ has joined #sandstorm
ecloud has quit [Ping timeout: 258 seconds]
<isd>
Reminder: office hours tonight.
<JacobWeisz[m]>
Hey Ian, I have a stupid question from the sandstorm.conf page.
<JacobWeisz[m]>
HIDE_TROUBLESHOOTING should be deprecated, shouldn't it? Like, if it's not, we should deprecate it.
<JacobWeisz[m]>
It's redundant to the Personalization page setting, and possibly inconsistent with it, if whoever wrote one didn't account for the other.
<JacobWeisz[m]>
It actually has a hiddenByConfFile and hiddenByDbSetting
<JacobWeisz[m]>
At minimum I think we should state it's deprecated in the doc and tell people to configure it in the Personalization page. Even if we continue to check it for backwards compatibility purposes.
<JacobWeisz[m]>
But half of me says the code should set the database setting for anyone who has the config line for a few months and then stop reading the config line entirely. Presumably you can be in the weird state personalization says not to hide the troubleshooting link, so you are confused why it doesn't appear, because you forgot we used to have a config option for it.
<isd>
I had no idea that was even a thing.
<isd>
I agree with documenting it being deprecated.
<isd>
and maybe also log a warning if we see the option in a config.
<isd>
I think I like the idea of having the config option just override the db on setup, and then after a while remove the option entirely.
<isd>
s/setup/startup/
<JacobWeisz[m]>
I will PR a doc change tonight.
<isd>
cool
<JacobWeisz[m]>
Does the config file's order matter? I'm tempted to move all the deprecated items to the bottom, below the "Used rarely" items, but unsure if it matters how they're sorted.
<isd>
It shouldn't matter.
<isd>
(looking at the code, it looks like if you specify the same option twice it will silently pick the last one I guess)