00:57 <stellar-slack> <dzham> @jed: what’s the problem with source == dest? that used to work before

00:59 <stellar-slack> <jed> That wasn't actually the issue

01:00 <stellar-slack> <dzham> I noticed that, but you still mentioned it as a possible cause of the problem a couple of times. Just trying to understand why it would be a problem

01:00 <stellar-slack> <dzham> Not that you can use it for much more that proofs-of-existance

01:02 <stellar-slack> <jed> Yeah I thought it would fail. looks like it just marks it a success and returns

07:52 <stellar-slack> <sacarlson> am I incorrect to assume that orders on stellar-core would be deleted after a match for the full amount of the asset being offered has found a matching order? As I'm not sure but in my test of random created orders on my standalone core seems might differ

07:53 <stellar-slack> <sacarlson> after a few more test with static orders I'll run the test on the public testnet so test orders can be seen

08:21 <stellar-slack> <sacarlson> I have been able to verify that with 1 to 1 bid ask match that the is deleted of the order books

08:41 <stellar-slack> <sacarlson> but when I run a group of orders from two accounts something strange seems to happen and even 1 to 1 matched orders don

08:42 <stellar-slack> <sacarlson> I'll point at horizon to see if the same thing happens on testnet

09:25 <stellar-slack> <sacarlson> I've setup a currency pair of AAA and BBB with two accounts holding both. first 1 to 1 bid ask transaction worked ok

09:29 <stellar-slack> <sacarlson> I'm now setting up 20 semi random orders 10 from each account

09:40 <stellar-slack> <sacarlson> now all 20 are on the testnet order book but none of the orders fire. am I brain farting again? shouldn't at least some of these orders fire?

09:46 <stellar-slack> <sacarlson> maybe the trading rule is setup as all or nothing? if not all of an order is filled no partial orders are fired?

11:16 <stellar-slack> <fredolafritte> anyone tried to cancel an order ?

11:17 <stellar-slack> <fredolafritte> it used to be that cancelling an order was about setting the amount to 0,

11:18 <stellar-slack> <fredolafritte> now js-stellar-base complains about it: `TypeError: amount argument must be of type String and represent a positive number`

11:19 <stellar-slack> <fredolafritte> moreover, the offerId has to be a string too, is there any reason for that ?

11:20 <stellar-slack> <fredolafritte> when getting the orders for an account, it returns an integer for the orderId.

11:22 <stellar-slack> <fredolafritte> So we need to convert this integer to a string, is it really necessary ?

13:57 <stellar-slack> <fredolafritte> @scott can we get rid of --ruby-horizon-url option in horizon ? Is it still used ?

14:27 <stellar-slack> <sacarlson> so fredolafritte did you find a working method to cancel an order yet? I can' get any orders to trigger it seems unless they are a direct match and there are no other orders for the same account on the books. so I guess I need to cancel orders before I add any others

14:32 <stellar-slack> <fredolafritte> @sacarlson: for sure cancelling an order was working 2 month ago, now it doesn't. Partial order match was working too and I don't know if it is still working.

14:32 <stellar-slack> <sacarlson> ok so no work around then

14:33 <stellar-slack> <fredolafritte> well that is with the js lib, don't know anything about the ruby lib

14:33 <stellar-slack> <sacarlson> it shows on the books but the orders just aren't trigering

14:34 <stellar-slack> <sacarlson> yes I'm using ruby

14:34 <stellar-slack> <fredolafritte> what do you mean by triggering ? matched ?

14:35 <stellar-slack> <sacarlson> I mean I have orders that I would assume match with grater than price that should fire the order

14:35 <stellar-slack> <sacarlson> the image above it a shot of what I presently have on stellar testnet viewed from sqlite browser

14:37 <stellar-slack> <sacarlson> I think it might be a bug in stellar-core unless I brain farted again

14:38 <stellar-slack> <sacarlson> or I just don't know the rules of order

14:39 <stellar-slack> <nelisky> sacarlson: yeah, it's actually working as expected in not triggering matches

14:39 <stellar-slack> <nelisky> basically the price is base/counter, so taking the top entries on each direction from your png:

14:39 <stellar-slack> <sacarlson> oh ok so what is the rules then?

14:40 <stellar-slack> <nelisky> AAA/BBB price 5 == 5 BBB per AAA, or 0.2 AAA per BBB

14:40 <stellar-slack> <nelisky> BBB/AAA price 3 == 3 AAA per BBB or 0.3[3] BBB per AAA

14:41 <stellar-slack> <nelisky> all the AAA bids are > 1 BBB per AAA, where all the asks are < 1 BBB per AAA (but over 1 AAA per BBB which is what you see on the db)

14:42 <stellar-slack> <sacarlson> oh ok I'm still confused but glad to hear it's me brain farting again

14:43 <stellar-slack> <sacarlson> how about I send you funds of AAA and BBB nelisky so you can try to triger one of them

14:44 <stellar-slack> <nelisky> I'm not on testnet at all, and a little busy at the moment, but if you can't find anyone else to do it I'll step in later today, ok?

14:44 <stellar-slack> <nelisky> (I'm GMT)

14:45 <stellar-slack> <sacarlson> I'm bkk time it's getting later here already

14:45 <stellar-slack> <nelisky> I'll likely catch you in your morning time, then ;)

14:45 <stellar-slack> <sacarlson> :+1:

15:53 <stellar-slack> <scott> @fredolafritte: yep, we can remove it.

15:54 <stellar-slack> <fredolafritte> is there any config file for horizon ? or it's only cli based or environment variable ?

15:55 <stellar-slack> <scott> presently just CLI and environment. Perhaps I’ll add TOML bindings to vipe (the config library we use) in the future, but thats a nice to have

16:37 <stellar-slack> <bartek> @fredolafritte: I went to far with arguments validation. this should be fixed in stellar-base 0.4.15 (released now)