11:43 <sf-slack2> <acomodi> mithro: Ok, I have pushed a simple script that makes the conversion both in the Symbiflow and VTR PRs and updated the `run_vtr_flow.pl` script to run the conversion

14:09 <sf-slack2> <mkurc> Good time of day

14:09 <sf-slack2> <mkurc> @me1 @litghost The PR for Yosys which added support for parsing Verilog attributes on parameters has been merged to the YosysHQ/master.

14:10 <sf-slack2> <mkurc> Shall I issue a PR from YosysHQ/master to Symbiflow/Yosys/master+wip to synchronize?

14:10 <sf-slack2> <mkurc> Or make a new PR with the same changes to Symbiflow/Yosys/master+wip ?

14:14 <sf-slack2> <mkurc> @litghost I also updated the document regarding v2x FASM support: https://docs.google.com/document/d/1J8lLT4SzlK_56-vBfz0f2DaNLHPn9rABUB0Fu1ljF4M

14:14 <tpb> Title: Google Docs - create and edit documents online, for free. (at docs.google.com)

14:58 <litghost> mkurc: PR from YosysHQ/master to Symbiflow/master+wip

15:33 <sf-slack2> <acomodi> litghost, mithro: I have run less "massive" benchmarks to test mode selection in VTR. Interestingly the pack time is ~4% higher, but the whole vtr flow takes ~4% time less than master. https://github.com/verilog-to-routing/vtr-verilog-to-routing/pull/517#issuecomment-493024142

15:33 <tpb> Title: Mode selection feature by acomodi · Pull Request #517 · verilog-to-routing/vtr-verilog-to-routing · GitHub (at github.com)

15:39 <sf-slack2> <acomodi> litghost, mithro: moreover, I solved the issues on equivalent tiles after the upstream merge (a few things were modified by VTR devs regarding placement which affected my solution). Both the PRs (on symbiflow and VTR) should turn green

15:58 <litghost> acomodi: Have the VTR devs responded to either PR yet? Might be worth poking them again if they are green.

16:00 <litghost> acomodi: > updated the `run_vtr_flow.pl` script to run the conversion

16:00 <litghost> Did you add a test where run_vtr_flow runs on an arch.xml which already has tiles?

16:01 <sf-slack2> <acomodi> litghost: good suggestion, I need to add to the script a check to see if the arch.xml is already compliant with the new format

16:09 <sf-slack2> <acomodi> CI passed on VPR reg_tests, but failed on ODIN II ones. I need to apply the architecture conversion script also in there

17:52 <mithro> mkurc: Do you have the code / pull request for your attributes on parameters?

18:11 <sf-slack2> <mkurc> @me1 Yes, I have the code. I didn't issue a PR. Currently it can store attributes of parameters within the RTLIL. But it can only output them to a JSON as the only backend I modified is JSON.

18:13 <sf-slack2> <mkurc> Maybe it is a good idea to make the PR with it to Symbiflow/yosys/master+wip ?

18:13 <sf-slack2> <mkurc> Once we agree that it has all functionalities we want we can then issue a PR to the YosysHQ

18:21 <litghost> mkurc: Let's start the PR on master+wip and see if we can minimize impact to the RTLIL and yosys runtime. If we can make a "zero-cost" PR for people not using parameter attributes, maybe that will be amenable

18:22 <sf-slack2> <mkurc> Ok, then. I'll issue a WIP PR.

18:37 <sf-slack2> <mkurc> @mithro @litghost There it is: https://github.com/SymbiFlow/yosys/pull/25

18:37 <tpb> Title: [WIP] Support for attributes on parameters in Verilog by mkurc-ant · Pull Request #25 · SymbiFlow/yosys · GitHub (at github.com)

18:48 <mithro> mkurc: Great!

19:55 <hackerfoo> Does anyone else use Emacs? If so, have you gotten it to indent Verilog nicely i.e not indenting to the open parenthesis?

19:55 <hackerfoo> https://stackoverflow.com/questions/30986217/modify-verilog-mode-indentation

19:55 <tpb> Title: emacs - Modify verilog mode indentation - Stack Overflow (at stackoverflow.com)