<somlo>
daveshah: in xc7dsp, after removing line 121 in techlibs/xilinx/synth_xilinx.cc, I get this build error: https://pastebin.com/xu4aSqag
<tpb>
Title: In file included from passes/pmgen/test_pmgen.cc:30: ./passes/pmgen/ice40_dsp_p - Pastebin.com (at pastebin.com)
<daveshah>
Eddie should have pushed a fix
<daveshah>
I haven't tried it myself yet
<somlo>
oh, I see, 16 minutes ago :) Let me refresh and restart the build -- thanks!
citypw has quit [Ping timeout: 244 seconds]
<somlo>
hmm, Eddie's commit 295c18bd only seems to handle techlibs/xilinx/synth_xilinx.cc line 121;
<somlo>
the commit before that is your 6919c0f9, so I'm expecting the build to still fail with the error I linked to on pastebin
<somlo>
but I'll start the build back up regardless, just to be sure
kraiskil has quit [Ping timeout: 268 seconds]
<daveshah>
somlo: seems you need to run `make clean` first
rohitksingh has joined #yosys
adjtm has quit [Ping timeout: 244 seconds]
maikmerten has quit [Remote host closed the connection]
kraiskil has joined #yosys
<somlo>
daveshah: maybe there was more to Eddie's commit than I could tell from eyeballing, but the build is now working fine
<somlo>
re. "make clean", I'm building an RPM in Fedora mock, so it's always from 100% pristine sources
<daveshah>
Hmm
<somlo>
either way, thanks, it looks like it's building fine now
adjtm has joined #yosys
kraiskil has quit [Ping timeout: 244 seconds]
emeb_mac has joined #yosys
emeb_mac has quit [Read error: Connection timed out]
emeb_mac has joined #yosys
<somlo>
daveshah: I wonder if it's something as silly as passes/pmgen/.gitignore which in one or the other branches didn't have a newline at the end of the file (git was complaining about that in the diff, and I ignored it)
<somlo>
maybe a non-newline-terminated .gitignore caused the *_pm.h files to show up in the diff between master+merged-xc7dsp and straight-forward master, so when I applied that patch on top of master I inadvertently got the effect of a missing "make clean"...
<somlo>
that's as far as my detective skills are willing to take me, I think I'm ok with that theory as to why the weird build failure earlier :)