j_mcnally has quit [Read error: Connection reset by peer]
wmnnd has quit [Ping timeout: 260 seconds]
j_mcnally has joined #opal
wmnnd has joined #opal
f-3r has quit [Ping timeout: 265 seconds]
elia has quit [Quit: Computer has gone to sleep.]
f-3r has joined #opal
wmnnd has quit [Ping timeout: 245 seconds]
f-3r has quit [Ping timeout: 258 seconds]
meh` has quit [Ping timeout: 240 seconds]
elia has joined #opal
j_mcnally has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
gawaine has joined #opal
<adambeynon>
morning elia: why is using toString() for String#hash() a problem?
gawaine has left #opal [#opal]
wmnnd has joined #opal
j_mcnally has joined #opal
j_mcnally has quit [Ping timeout: 244 seconds]
<elia>
adambeynon, morning, I initially tried normalizing String#hash too (as "String:"+self.toString())
<elia>
the concern is about collisions
gawaine has joined #opal
<elia>
wella gawaine !
<adambeynon>
elia: ah yeah, forgot about the clashes
<elia>
adambeynon, yes, any prefix we can think of is inevitably subject to collisions, an alternative would be to have bags of hashes (via st like weakmaps) or using the same algoriths as cruby/rubinius and render the integer to hex or something
meh` has joined #opal
elia has quit [Quit: (IRC Client: textualapp.com)]
elia has joined #opal
<adambeynon>
elia: well, I think it is fair to say that strings/symbols are the most common keys, so we could have two tables, one for strings, and one for anything else
<adambeynon>
a very quick (and fast) typeof(key) === “string” would be a simple check
<elia>
adambeynon, would also make sense performance wise I think
<elia>
adambeynon, so would be something like def[] k; `k.$$is_string ? self.smap[k] : self.map[k.$hash()]` end ?
<adambeynon>
elia: yeap, exactly that
e_dub has quit [Quit: ZZZzzz…]
<elia>
k, sounds good; IMO should be a different PR
<elia>
cc meh` ^^^
f-3r has joined #opal
<meh`>
fine by me
f-3r has quit [Ping timeout: 258 seconds]
elia has quit [Ping timeout: 255 seconds]
e_dub has joined #opal
elia has joined #opal
meh` has quit [Ping timeout: 244 seconds]
f-3r has joined #opal
GitHub133 has joined #opal
<GitHub133>
[opal] elia force-pushed hash-hash from 62e07f3 to 737d522: http://git.io/BnPiqQ
<GitHub133>
opal/hash-hash d30bc16 Elia Schito: Use #hash to generate internal Hash map keys