<azonenberg>
"The only really compelling reason for #pragma pack is if you have to exactly match your C data layout to some kind of bit-level hardware or protocol requirement, like a memory-mapped hardware port, and violating normal alignment is required for that to work"
<azonenberg>
Exactly the scenario here
maartenBE has quit [Ping timeout: 264 seconds]
maartenBE has joined #scopehal
<sam210723_>
the string constructor in ReadFile was missing the size arg
<sam210723_>
so it was terminating the string at the first null byte
<sam210723_>
which was half way through the file header
<azonenberg>
ooh good catch, fix that
<azonenberg>
I guess we've never used it to read files with non-printable characters in them :p
Degi_ has joined #scopehal
Degi has quit [Ping timeout: 265 seconds]
Degi_ is now known as Degi
electronic_eel has quit [Ping timeout: 264 seconds]